editing standard pivots indicator

[pappal]

I've copied the standard Pivots indicator code to a new file I've named PivotsImproved. I am changing the formula for S3/R3 and adding midpoints, stored in variables s1m, s2m... etc.

I'm getting a flood of error messages regarding NinjaTrader.Custom.Resource. I have programmed in Java before etc, but am having difficulty with NinjaScript.

The error output is attached.
I had to try to utilize NinjaTrader.Custom.Resource.PivotsR1m (R2m.. etc) alongside of the standard code showing NinjaTrader.Custom.Resource.PivotsPP, R1, R2... etc. However, obviously this code doesn't exist, so I need to fill in for this.

There are some other errors I am unsure of. I appreciate any guidance!

[JerryWar]

If you want people to comment, Why don't you post your modified indicator.
Example. Did you add the corresponding Plots for the new variables? Its hard
to comment on just an error message.

[pappal]

Of course, thanks.

Here's a pdf of the code.

[Zeos6]

I've had a quick look at what you have posted. It's far too much to go through in detail but a few observations to help you along:

1. In your State == State.SetDefaults the name and description will not work the way you have them. It is much simpler for you to use the following:

Description = @"Displays my new improved pivot point indicator.";
Name = "MyIndicatorName";

2. You have:

[TypeConverter("NinjaTrader.NinjaScript.Indicators.PivotsTypeConverterImproved")]
public class PivotsImproved : Indicator
{ ... }

I guarantee you that NT staff did not create a Type converter of this type. You would have to write your own type converter of this type. Perhaps your code might work if you use the original type converter that came with the original indicator. If not, you might think about skipping the type converter altogether.

3. Add your own plots for your indicator. Don't use NinjaTrader.Custom.Resource.Pivots... You don't need to use these. You can simply use for example,

AddPlot(new Stroke(Brushes.Lime, DashStyleHelper.Solid, 2), PlotStyle.Line, "pivot1");

There are many ways to accomplish what you want but I am trying to keep things simple for you. Start with this and see how far you get with your indicator.

All the best

[pappal]

Thank you! I'm going to use these suggestions. I don't have a full understanding of all segments of this code, but I'll give it a shot. Will get back to you. Thanks for posting

[Zeos6]

You are welcome.
All the best

[pappal]

You are welcome.
All the best

Sweet, I got the indicator to work!

Last thing - the program uses the close as the close at 5 pm Eastern. I need it to use the close of the bar ending at 4:15 pm Eastern. What code modification would allow this? I searched the Ninjascript language page, not able to find what I need..

Cheers

[NinjaTrader_PaulH]

Hello pappal,

Thanks for your posts.

Good job creating your pivots, great community support from members JerryWar and Zeos6 to get you started.

The pivots, like all indicators, will use the trading hours of the instrument the indicator is applied to. To change the hours you would need to set the trading hours template needed for the instrument. Most instruments already have the correct trading hours defined however you can change to what you need. To change the trading hours of an instrument on a chart, right mouse click on the chart and select "data series..", in the data series window find the row "Trading Hours", left click on the drop down arrow in the current setting to select the template needed. Reference: http://ninjatrader.com/support/helpG...price_data.htm

To see the specific trading hours of a temple, in the NinjaTrader control center, go to Tools>Trading hours. Reference: http://ninjatrader.com/support/helpG...urs_window.htm