simple bar color change

[soulfx]

Hello, was just testing something in N7 before N8

any reason why this code does nothing in N7

if (((Open[0]) > (Close[0])) || ((Open[0]) < (Close[0]))) {

BarColorSeries[0] = Color.Empty;

} else {

BarColorSeries[0] = Color.Yellow;

}

ChartOnly = true and Overlay = true in the Initialise

obviously i just want to set doji style bars to yellow

tried BarColor too and that did not work so tried the Series version

i tried with on bar close = true and false

there is no plot override

am i missing something?

thanks

[eDanny]

if (Open[0] > Close[0] || Open[0] < Close[0]), easy with the parenthesis, should produce an Empty color unless Open[0] == Close[0].
What are you seeing?

Might be simpler to color the doji with if(Open[0] == Close[0])

[soulfx]

thanks but tried that approach open == close but aware of comparing double values in certain situations can have issues which is why i opted for < > check .... so didnt make difference
seeing no change ...
the logic above captures the == to situation of open=close but in different way.
thanks for suggestion ... will run again in debug tomorrow .. but if ninja has any thoughts on recommended approach to BarColor or BarColorSeries ....?
thanks

[soulfx]

update - on testing further can see now the horizontal line of doji changes color with the above.
In order to have the wick change as well do i have to do this in a plot override or another series to change? its was so faint that i couldnt see as was expecting the whole candle including wick to change color but this doesnt appear to happen in this instance. Any input?
thanks

[eDanny]

Use CandleOutlineColor or CandleOutlineColorSeries. Comparing Open[0] to Close[0] will work fine if you refine their doubles. Use Instrument.MasterInstrument.Round2TickSize in this case.

[soulfx]

thanks Danny the CandleOutline... worked ... i did try it before but must have had something else in the way. I do use the Round2TickSize for other things but didnt need in this instance with price.
thanks for help.

[NinjaTrader_AlanP]

Hello soulfx,

Thank you for your note.

If you were to add the following to your else statement it will color the candle/bar yellow upon a doji as defined by your statement.

CandleOutlineColor = Color.Yellow;

Adding to eDanny’s point, you would write the if statement like,

if (Instrument.MasterInstrument.Round2TickSize(Close[0]) == Instrument.MasterInstrument.Round2TickSize(Open[0]))
{
DrawArrowUp( "My Up arrow" + CurrentBar, false, 0 , High[0], Color.Lime);	
}

Please let us know if you need further assistance.

Thank you eDanny for your help.

[soulfx]

Hello i wondered if that was a Draw Arrow trick .. did you mean to write draw arrow in your code snippet?

[NinjaTrader_AlanP]

Hello Soulfx,

I was using the arrow to make obvious the Doji points. If you wanted yellow bars you could use,

if (Instrument.MasterInstrument.Round2TickSize(Close[0]) == Instrument.MasterInstrument.Round2TickSize(Open[0]))
{
CandleOutlineColor = Color.Yellow;
}

Please let us know if you need further assistance.