NinjaTrader Support Forum  

Go Back   NinjaTrader Support Forum > NinjaScript Development Support > Indicator Development

Indicator Development Support for the development of custom indicators using NinjaScript.

Reply
 
Thread Tools Display Modes
Old 05-18-2012, 07:48 AM   #1
tradr
Senior Member
 
Join Date: Jun 2008
Posts: 146
Thanks: 0
Thanked 6 times in 4 posts
Default Sell signals, no Buy signals and v v ???

hi, would someone be good enough to look at this code and see if it's incorrect as the
signals seem inconsistent, lots of Sell arrows but no offsetting Buy arrows, then the
reverse happens with a lot of Buy arrows but no Sell arrows

also, is there a way to have the signals on the chart but not display the macd window ?

thanks
Attached Images
File Type: jpg MACDScalpArrow.jpg (89.0 KB, 14 views)
Attached Files
File Type: zip MACDScalpArrow.zip (12.3 KB, 7 views)
tradr is offline  
Reply With Quote
Old 05-18-2012, 08:15 AM   #2
NinjaTrader_Joydeep
NinjaTrader Customer Service
 
NinjaTrader_Joydeep's Avatar
 
Join Date: Dec 2011
Location: India
Posts: 3,286
Thanks: 580
Thanked 546 times in 541 posts
Default

Hello tradr,
Thanks for writing in and I am happy to assist you.

The condition you have set does not necessarily mean that the next signal will be always a reverse. This is particularly true since your code filters it with SMA 89 which is pretty smooth and doest changes/reverses easily particularly if the price is in a strong trend.


To remove the MACD from the chart please delete the Plots in the initialize section of the code along with its corresponding properties.

You are calculating the Macd and Ema in your code. Instead of calculating it you can simply call them as
Code:
//call ema
double fastEma = EMA(fast)[0];
//call macd dif
double macdDiff= MACD(macdFast, macdSlow, macdSmooth).Diff[0];
Please let me know if I can assist you any further.
NinjaTrader_Joydeep is offline  
Reply With Quote
Old 05-18-2012, 08:35 AM   #3
tradr
Senior Member
 
Join Date: Jun 2008
Posts: 146
Thanks: 0
Thanked 6 times in 4 posts
Default

hi Joydeep, thanks for your fast reply

should have stated I'm Not a coder and not the author of the indicator

besides what you've already answered, and thanks for that, how could the indicator be
improved to provide better signals, and would you please provide the code I'd need to
change, and please explain where I'd need to change it

thanks
tradr is offline  
Reply With Quote
Old 05-18-2012, 09:31 AM   #4
NinjaTrader_Joydeep
NinjaTrader Customer Service
 
NinjaTrader_Joydeep's Avatar
 
Join Date: Dec 2011
Location: India
Posts: 3,286
Thanks: 580
Thanked 546 times in 541 posts
Default

Hello tradr,
The code is not meant to do what you are trying to do.

Unfortunately we do not do custom coding. I would suggest you contact the original developer to further customize it as per your requirement.

You can also contact any of our NinjaScript consultants to do it. You can get the list of our NinjaScript consultants from here http://www.ninjatrader.com/partners#...pt-Consultants
NinjaTrader_Joydeep is offline  
Reply With Quote
Reply

Thread Tools
Display Modes

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is On
HTML code is Off

Forum Jump

Similar Threads
Thread Thread Starter Forum Replies Last Post
Getting TS signals to someone else Atomic Automated Trading 5 01-07-2010 06:42 AM
Script is running wild: buy - sell - buy - sell ... BillCh Automated Trading 4 02-06-2009 01:01 PM
Josh: No buy signals in this strategy, why? ju1234 Strategy Development 7 12-03-2008 05:26 AM
Remove Old Strategy Buy or Sell Signals lawyse Charting 3 09-03-2008 08:11 AM
Still buy/ sell signals in my chart after removing strategy FireFly Strategy Development 6 01-23-2008 01:51 AM


All times are GMT -6. The time now is 03:37 PM.