First Add On

[NinjaTrader_ZacharyG]

Hello stephensams,

The changes should be made after a compile.

Please verify that no errors appear in the Log tab of the Control Center. Additionally, check for any output in the New -> NinjaScript Output Window.

Additionally, verify that your XAML syntax is correct. Revert back to a previously working XAML as well and test as well.

[stephensams]

With no edits to any of the sampleAddon files (4 add ons, one XAML), I got this log error...still getting it:

Error in realtime market data handling: System.NullReferenceException: Object reference not set to an instance of an object.
at NinjaTrader.NinjaScript.AddOns.SampleAddonWindowTa bPage.marketData_Update(Object sender, MarketDataEventArgs e)
at NinjaTrader.Data.MarketData.OnMarketData(Object sender, MarketDataEventArgs e)
at NinjaTrader.Cbi.Instrument.<>c__DisplayClass180_0. <OnRealtimeDataTimerElapsed>b__1(SubscribedThrea d[] threads, Int32 i, RealtimeEvents evts)

Any advice?

[NinjaTrader_ZacharyG]

Hello stephensams,

I have tested the Sample Addon on my end and was able to reproduce that run-time error.

To correct this, add a null check within the marketData_Update() method within the SampleAddonWindowTabPage for marketData.Ask and marketData.Bid:

// This event handler is called when new market data happens, the following statements are used to update the user interface. 
        private void marketData_Update(object sender, MarketDataEventArgs e)
        {
	            if (askLabel != null && marketData.Ask != null)
	            {
	                askLabel.Content = marketData.Ask.Price;
	            }
	            if (bidLabel != null && marketData.Bid != null)
	            {
	                bidLabel.Content = marketData.Bid.Price;
	            }
	            if (askVolLabel != null && marketData.Ask != null)
	            {
	                askVolLabel.Content = marketData.Ask.Volume;
	            }
	            if (bidVolLabel != null && marketData.Bid != null)
	            {
	                bidVolLabel.Content = marketData.Bid.Volume;
	            }
        }

[dalebru]

Hello stephensams,

I have tested the Sample Addon on my end and was able to reproduce that run-time error.

To correct this, add a null check within the marketData_Update() method within the SampleAddonWindowTabPage for marketData.Ask and marketData.Bid:

// This event handler is called when new market data happens, the following statements are used to update the user interface. 
        private void marketData_Update(object sender, MarketDataEventArgs e)
        {
	            if (askLabel != null && marketData.Ask != null)
	            {
	                askLabel.Content = marketData.Ask.Price;
	            }
	            if (bidLabel != null && marketData.Bid != null)
	            {
	                bidLabel.Content = marketData.Bid.Price;
	            }
	            if (askVolLabel != null && marketData.Ask != null)
	            {
	                askVolLabel.Content = marketData.Ask.Volume;
	            }
	            if (bidVolLabel != null && marketData.Bid != null)
	            {
	                bidVolLabel.Content = marketData.Bid.Volume;
	            }
        }

Thanks for this.
The syntax gets a bit nicer with C# 6.0, and there are a lot of other C# 6.0 niceties I'm missing now. What are prospects for your supporting it? Thanks.

e.g.
if (askLabel != null)
{
askLabel.Content = marketData.Ask?.Price;
}

[gregid]

if (askLabel != null)
{
askLabel.Content = marketData.Ask?.Price;
}

I believe, you could even shorten it further to:

 
askLabel?.Content = marketData.Ask?.Price;

Anyway +1 for the upgrade

My feeling is that this single feature (null conditional) will be used most extensively in NinjaScript and if it won't be upgraded to .NET 4.6 before final release it won't be upgraded at all because of fear of users' scripts compatibility issues between 4.5 and 4.6. I may be wrong - just a feeling.

[NinjaTrader_ZacharyG]

Hello,

We currently do not have any plans to implement .NET 4.6 as of yet.

[dotnet]

adding menu separator - how to apply NT theme on controls

How to apply default NT theme on the controls?
For example

Separator separator = new Separator();

existingMenuItem.Items.Add(separator);

add a windows shell style separator, and not the NT theme style.

Thanks,
dotnet

[NinjaTrader_ZacharyG]

Hello dotnet,

Here's an example of how you can create a new Separator that has the same style of NT8's menu separators:

private Separator theSeparator;

theSeparator = new Separator { Style = Application.Current.TryFindResource("MainMenuSeparator") as Style };