B4 Currency Naming Conventions

[jeronymite]

In B4, the following currencies are defined in NinjaTrader.Cbi.Currency:

AustralianDollar
BritishPound
CanadianDollar
Euro
HongKongDollar
JapaneseYen
SwissFranc
UsDollar
KoreanWon
IndianRupee
SwedishKrona
MexicanPeso
BrazilianReal
SingaporeDollar
ChinaYuan
MalaysiaRinggit
ThailandBaht
TaiwanNewDollar
NewZealandDollar
SouthAfricanRand
CzechRepublicKoruna
NorwayKrone
DenmarkKrone
HungaryForint
PolandZloty
TurkeyLira
IsraeliShekel
RussiaRuble
Unknown

This seems to be a mixture of naming conventions, including CountryName+CurrencyName, CountryAdjective+CurrencyName, CurrencyName only.

In line with NT8's admirable effort to standardise names and spelling, may I recommend consideration of the following three consistent naming conventions, with a few duplications for completeness that would obviously not need duplicate declarations:

CountryName+CurrencyName

AmericaDollar
USADollar
USDollar
AustraliaDollar
BrasilReal
BrazilReal
CanadaDollar
ChinaRenminbi
ChinaYen
ChinaYuan
CzechRepublicKoruna
DenmarkKrone
Euro
HongKongDollar
HungaryForint
IndiaRupee
IsraelShekel
JapanYen
KoreaWon
SouthKoreaWon
MalaysiaRinggit
MexicoPeso
NewZealandDollar
NorwayKrone
PolandZloty
RussiaRuble
SingaporeDollar
SouthAfricaRand
SwedenKrona
SwitzerlandFranc
TaiwanNewDollar
ThailandBaht
TurkeyLira
UKPound
UKPoundSterling
UKSterling

CountryAdjective+CurrencyName

AmericanDollar
USADollar
USDollar
AustralianDollar
BrasilianReal
BrazilianReal
CanadianDollar
ChineseRenminbi
ChineseYen
ChineseYuan
CzechRepublicKoruna
DanishKrone
Euro
HongKongDollar
HungarianForint
IndianRupee
IsraeliShekel
JapaneseYen
KoreanWon
SouthKoreanWon
MalaysianRinggit
MexicanPeso
NewZealandDollar
NorwegianKrone
PolishZloty
RussianRuble
SingaporeanDollar
SouthAfricanRand
SwedishKrona
SwissFranc
TaiwaneseNewDollar
ThaiBaht
TurkishLira
BritishPound
BritishPoundSterling
BritishSterling

CurrencyName Only

Euro

Making all the above available should cover all reasonable and often used (in conversation at least) currency variations.

I also notice that MasterInstrument.Currencies has the following currency definitions:

AED
ARS
AUD
BGN
BND
BOB
BRL
CAD
CHF
CLP
CNY
COP
CZK
DKK
EGP
EUR
FJD
GBP
HKD
HRK
HUF
IDR
ILS
INR
JPY
KES
KRW
LTL
MAD
MXN
MYR
NOK
NZD
PEN
PHP
PKR
PLN
RON
RSD
RUB
SAR
SEK
SGD
THB
TRY
TWD
UAH
USD
VEF
VND
XAG
XAU
ZAR

This list contains currencies that do not have corresponding currency names (e.g. PHP).

I recommend that all currency name and instrument definitions be made consistent and aligned. So, for example, this would mean adding definitions for PHP as PhilippinesPeso and PhilippinoPeso. It would even be worth adding the international currency abbreviations to NinjaTrader.Cbi.Currency perhaps.

Thanks.

[NinjaTrader_AlexC]

Hi jeronymite,

I have submitted your suggestion to the development team for consideration.