Bug causes NT8 B6 to crash when opening indicators in a chart

[daqu40]

I found this bug when opening the indicators window in a chart. It seems that a few of my custom indicators used the format:

bwCombo().Calculate = Calculate.OnPriceChange;

(in the SetDefaults code of OnStatChange)

to set Calculate to OnPriceChange for the indicator bwCombo. This compiles without issue, but caused NT8 to crash if open the indicator dialog in a chart.

Changing the code to the below fixes the issue.

Calculate = Calculate.OnBarClose;

Please let me know if any further details are needed.

[NinjaTrader_DaveI]

Hello,

Thank you for reporting this to us. When you set the property the first way, was bwCombo the name of the indicator you were working with, or was bwCombo being hosted within a second indicator? In other words, were you trying to set the Calculate property for the indicator in question, or for a separate indicator being added in code?

[daqu40]

bwCombo is the name of the indicator. This was probably a poor example as it does use other indicators. However as proof I had several custom indicators that each caused the crash due to the format indicatorname().Calculate = Calculate.OnPriceChange; until I fixed them.

[NinjaTrader_ZacharyG]

Hello daqu40,

The proper method of specifying an indicator's Calculate property is just by specifying Calculate in State.SetDefaults rather than IndicatorName().Calculate.

So:

// indicator's name is TheIndicator in this example

if (State == State.SetDefaults)
{
     Calculate = Calculate.OnPriceChange; // proper
     TheIndicator().Calculate = Calculate.OnPriceChange // improper
}

More information about Calculate can be found here: http://ninjatrader.com/support/helpG...?calculate.htm

Please, let us know if we may be of further assistance.

[daqu40]

You got it.

The incorrect code was created by the NT7 to NT8 conversion and the NT8 compiler accepted it.

[NinjaTrader_ZacharyG]

Hello daqu40,

The recommended method of converting scripts from NinjaTrader 7 to NinjaTrader 8 would be utilizing the Code Breaking Changes from the NinjaTrader 8 help guide to manually convert scripts over: http://ninjatrader.com/support/helpG...ng_changes.htm

There are no official automated code converters for NinjaTrader 8. The incorrect syntax generated by the converter causes a stack overflow exception.