Announcement

**NinjaTrader_Jesse** · 03-03-2016, 03:08 PM

Hello,

Thank you for the post on this.

Could you provide a full sample of this, I am not able to reproduce any error when not using the fully quallified name in the current internal build.

I would like to see the sample you have and try that in my installation to see if the error persists.

I look forward to being of further assistance.

**gregid** · 03-03-2016, 03:23 PM

Thanks Jesse.

My concern is that the enum is placed in exactly the same namespace as the indicator that uses it. And that's the part that is very confusing especially that when you create an indicator from within a folder you are given a namespace for the indicator automatically. Adding enum to the same namespace as indicator, ie: just above:

Code:

public class MyIndicator: Indicator
{
...
}

is the most intuitive.

If an user gets an error message stating the enum couldn't be found even though it is in the same namespace he needs to understand how the wrapper works in order to fix it.

**NinjaTrader_Jesse** · 03-03-2016, 03:34 PM

Hello,

I was unable to produce the result you were, I believe I was doing the same test but to be certain could you attach a full sample of what is currently not working?

In the internal build I did not get any errors, if I can test what you are it may be this is resolved or it may be we are not doing the same test.

I look forward to being of further assistance.

**gregid** · 03-03-2016, 03:48 PM

Since it won't compile with an error here it is - paste the following into your indicator and compile:

Code:

#region Using declarations
using System;
using System.Collections.Generic;
using System.ComponentModel;
using System.ComponentModel.DataAnnotations;
using System.Linq;
using System.Text;
using System.Threading.Tasks;
using System.Windows;
using System.Windows.Input;
using System.Windows.Media;
using System.Xml.Serialization;
using NinjaTrader.Cbi;
using NinjaTrader.Gui;
using NinjaTrader.Gui.Chart;
using NinjaTrader.Gui.SuperDom;
using NinjaTrader.Data;
using NinjaTrader.NinjaScript;
using NinjaTrader.Core.FloatingPoint;
using NinjaTrader.NinjaScript.DrawingTools;
#endregion

//This namespace holds Indicators in this folder and is required. Do not change it. 
namespace NinjaTrader.NinjaScript.Indicators.Custom
{
	public enum Testing{ one, two, three}
	public class EnumTest1 : Indicator
	{
		protected override void OnStateChange()
		{
			if (State == State.SetDefaults)
			{
				Description							= @"Enter the description for your new custom Indicator here.";
				Name								= "EnumTest1";
				Calculate							= Calculate.OnBarClose;
				IsOverlay							= false;
				DisplayInDataBox					= true;
				DrawOnPricePanel					= true;
				DrawHorizontalGridLines				= true;
				DrawVerticalGridLines				= true;
				PaintPriceMarkers					= true;
				ScaleJustification					= NinjaTrader.Gui.Chart.ScaleJustification.Right;
				//Disable this property if your indicator requires custom values that cumulate with each new market data event. 
				//See Help Guide for additional information.
				IsSuspendedWhileInactive			= true;
			}
			else if (State == State.Configure)
			{
			}
		}

		protected override void OnBarUpdate()
		{
			//Add your custom indicator logic here.
		}
		
        #region Properties
		[NinjaScriptProperty]
        [Display(Name = "TestingIt", Description = "TestingIt", Order = 1, GroupName = "Parameters")]
        public Testing TestingIt
        { get; set; }
		#endregion

	}
}

**gregid** · 03-03-2016, 03:56 PM

The exact steps to reproduce:
1. Create folder in "Indicators", eg. "Custom"
2. Right click on "Custom" -> New Indicator
3. Add name of the indicator, eg. "EnumTest1" and Generate
4. Add:

Code:

public enum Testing{ one, two, three}

just above:

Code:

public class EnumTest1 : Indicator

5. Add public property:

Code:

#region Properties
[NinjaScriptProperty]
[Display(Name = "TestingIt", Description = "TestingIt", Order = 1, GroupName = "Parameters")]
public Testing TestingIt
{ get; set; }
#endregion

6. Compile

Fails to find Testing every time on my end

PS. In Hindsight after giving you exactly these steps "Custom" may not be the best idea for the name of the folder as it raises some other issues. But the error still holds for other name.

**NinjaTrader_Jesse** · 03-03-2016, 04:12 PM

Hello,

Thank you for the more complete sample.

One item specific with this sample is the namespace, this is hiding the Internal namespace Custom so it is causing additional error. Renaming the folder to something else and namespace seems to prevent the Custom.Resource errors this is giving.

Regarding the NinjaScriptProperty usage, I do see the error when defined like this but is resolved when not using NinjaScriptProperty Or is resolved when using the fully qualified name. This would be expected as the wrapper code is being generated to allow the indicator to be used in multiple namespaces. In the code that is generated the exact enum name is used, so if you place the full name it would use the full name, otherwise if the short name is used it would use that which is invalid.

Because of the nature of the wrapper code I would expect that this occurs without using the fully qualified name, I will work with product management on this to see if there can be further documentation on this subject. To resolve the question, a fully qualified name should be used in this situation to allow the compiler to correctly compile the wrapper code.

Please let me know if I may be of further assistance.

**gregid** · 03-03-2016, 04:38 PM

Yeah, "Custom" was just me being "creative", so just an accident while making a quick sample for you (as noticed in my PS in last post). I do not use the folder/namespace myself.

Yes the error is only because NS wrapper while generating constructor for this specific indicator cannot find enum that should be part of this constructor (indicated by [NinjaScriptProperty] decorator.

The way I would see it solved is for the wrapper generator to look for object in indicator's own namespace as well as default "NinjaTrader.NinjaScript.Indicators"... Well, I'll let you find a solution

Thanks

**gregid** · 03-04-2016, 05:27 AM

I am afraid NS wrapper generator has some serious problems with namespaces.

I have just tried to use global qualifier to circumvent namespace conflict, eg:

Code:

[NinjaScriptProperty]
[Display(Name = "MarkEntryBy", Description = "Mark Entry By", Order = 1, GroupName = "Parameters")]
public global::g3.NinjaScript.Utility.MarkerType MarkEntryBy
{ get; set; }

The result: the script compiles just fine but the generated wrapper completely removed this property from the constructor! I consider it a bug.

Overall I spent too much time trying to resolve wrapper quirks around namespaces for simple enums - here visible with enums but I fear these problems will show up someplace else.

Edit: BTW, I would think global qualifier should be used in generated code anyway to avoid potential conflicts.

Topics	Statistics	Last Post
OnEachTick by algospoke Started by algospoke, Yesterday, 06:40 PM	2 responses 19 views 0 likes	Last Post by algospoke Today, 07:04 PM
Market Replay Data Refresh Rate by ghoul Started by ghoul, Today, 06:02 PM	3 responses 14 views 0 likes	Last Post by NinjaTrader_Manfred Today, 06:43 PM
Priceline Indicator Anomalies by jeronymite Started by jeronymite, 04-12-2024, 04:26 PM	3 responses 45 views 0 likes	Last Post by jeronymite Yesterday, 10:10 PM
postion indicator by Barry Milan Started by Barry Milan, Yesterday, 10:35 PM	7 responses 20 views 0 likes	Last Post by NinjaTrader_Manfred Today, 06:16 PM
GFF Brokers and Ninjatrader by AttiM Started by AttiM, 02-14-2024, 05:20 PM	10 responses 181 views 0 likes	Last Post by jeronymite Today, 06:11 PM

Announcement

Partner 728x90

NT8b9 NS wrapper doesn't see enums declared in "folder" namespaces

NT8b9 NS wrapper doesn't see enums declared in "folder" namespaces

Comment

Comment

Comment

Comment

Comment

Comment

Comment

Comment

Latest Posts