• If this is your first visit, you will have to register before you can post. To view messages, please scroll below and select the forum that you would like to visits. Questions? Be sure to check out the Forum FAQ.

Announcement

Collapse
No announcement yet.

Partner 728x90

Collapse

[NinjaScript Editor] String Color in Dark Skin

Collapse
X
  • Filter
  • Time
  • Show
Clear All
new posts

    [NinjaScript Editor] String Color in Dark Skin

    Hi the great support team,

    Recently I've switched to using the Slate Gray skin.
    Wow, wonderful, superb, fantastic. I love this dark theme really much.

    The only minor issue is that in NinjaScript Editor we have difficult-to-read strings when we add the "@" character before it (see the screenshot below).
    Does NT8 let us customize that color? Or can you change the color to a brighter one in the coming version, perhaps yellow or lime.

    Thank you very much for your hard work.
    Pi

    Attached Files
    ninZa
    NinjaTrader Ecosystem Vendor - Ninza

    #2
    Originally posted by ninZa View Post
    The only minor issue is that in NinjaScript Editor we have difficult-to-read strings when we add the "@" character before it (see the screenshot below).
    Does NT8 let us customize that color? Or can you change the color to a brighter one in the coming version, perhaps yellow or lime.


    should be in here some where.

    C:\Users\[your user]\Documents\NinjaTrader 8\templates\Skins\Slate Gray

    Comment


      #3
      Originally posted by sledge View Post
      should be in here some where.

      C:\Users\[your user]\Documents\NinjaTrader 8\templates\Skins\Slate Gray
      Thank you sledge.
      Perhaps it's somewhere there.
      In that folder, I can only find a helpful xaml: NinjaScriptWizard.
      However, this is its mere content:

      HTML Code:
      <ResourceDictionary xmlns="http://schemas.microsoft.com/winfx/2006/xaml/presentation"
      					xmlns:x="http://schemas.microsoft.com/winfx/2006/xaml"
      					xmlns:po="http://schemas.microsoft.com/winfx/2006/xaml/presentation/options">
      	<!--Dark Theme-->
      	<SolidColorBrush x:Key="BackgroundWizard" Color="#1e1e1e"	po:Freeze="true" />
      	<SolidColorBrush x:Key="BorderWizardInner" Color="#2D2D2F" po:Freeze="true"/>
      	<SolidColorBrush x:Key="BorderWizardOuter" Color="#3e3d42" po:Freeze="true"/>
      </ResourceDictionary>
      ninZa
      NinjaTrader Ecosystem Vendor - Ninza

      Comment


        #4
        Originally posted by ninZa View Post
        Thank you sledge.
        Perhaps it's somewhere there.
        In that folder, I can only find a helpful xaml: NinjaScriptWizard.
        However, this is its mere content:

        I found something - in BluePrint.

        You might try that DarkRed color first....

        Code:
        	<!-- NinjaScript Editor -->
        	<SolidColorBrush po:Freeze="true" x:Key="NinjaScriptEditorBackground"						          Color="#101010"		/>
        	<SolidColorBrush po:Freeze="true" x:Key="NinjaScriptEditorCommentForeground"				      Color="#7B7466"		/>
        	<SolidColorBrush po:Freeze="true"  x:Key="NinjaScriptEditorCompilerErrorForeground"		  	Color="DarkRed"	 
        	<SolidColorBrush po:Freeze="true" x:Key="NinjaScriptEditorIdentifierForeground"				    Color="#F0F0F0"		/>
        	<SolidColorBrush po:Freeze="true" x:Key="NinjaScriptEditorIndentationLineForeground"		Color="#363636"	/>
        	<SolidColorBrush po:Freeze="true" x:Key="NinjaScriptEditorKeywordForeground"				      Color="LightBlue"	/>
        	<SolidColorBrush po:Freeze="true" x:Key="NinjaScriptEditorLineNumbersBackground"			    Color="#1e1e1e"		/>
        	<SolidColorBrush po:Freeze="true" x:Key="NinjaScriptEditorLineNumbersForeground"			    Color="#E9E9E9"		/>
        	<SolidColorBrush po:Freeze="true" x:Key="NinjaScriptEditorNumberForeground"					      Color="#22CDFF"		/>
        	<SolidColorBrush po:Freeze="true" x:Key="NinjaScriptEditorStringForeground"					      Color="#0076EC"		/>
        	<SolidColorBrush po:Freeze="true" x:Key="NinjaScriptEditorSyntaxErrorForeground"			    Color="Red"			/>
        	<SolidColorBrush po:Freeze="true" x:Key="NinjaScriptEditorPlainTextForeground"				    Color="#F3F2F1"		/>
        	<SolidColorBrush po:Freeze="true" x:Key="NinjaScriptEditorErrorGridBackgroundSelectedTab"	Color="Sienna"		/>
        	<SolidColorBrush po:Freeze="true" x:Key="NinjaScriptEditorErrorGridBackgroundOtherTab"		Color="OrangeRed"	/>
        	<SolidColorBrush po:Freeze="true" x:Key="NinjaScriptEditorCaretBrush"						          Color="White"		/>
        	<SolidColorBrush po:Freeze="true" x:Key="NinjaScriptEditorWarningDotBrush"					Color="Yellow"		/>
        	<SolidColorBrush po:Freeze="true" x:Key="NinjaScriptEditorErrorDotBrush"					Color="Red"			/>
        	<SolidColorBrush po:Freeze="true" x:Key="FontSelectionBrush" Color="DimGray" />
        Last edited by sledge; 03-05-2016, 08:23 PM.

        Comment


          #5
          Originally posted by sledge View Post
          I found something - in BluePrint.

          You might try that DarkRed color first....

          Code:
          	<!-- NinjaScript Editor -->
          	<SolidColorBrush po:Freeze="true" x:Key="NinjaScriptEditorBackground"						          Color="#101010"		/>
          	<SolidColorBrush po:Freeze="true" x:Key="NinjaScriptEditorCommentForeground"				      Color="#7B7466"		/>
          	<SolidColorBrush po:Freeze="true"  x:Key="NinjaScriptEditorCompilerErrorForeground"		  	Color="DarkRed"	 
          	<SolidColorBrush po:Freeze="true" x:Key="NinjaScriptEditorIdentifierForeground"				    Color="#F0F0F0"		/>
          	<SolidColorBrush po:Freeze="true" x:Key="NinjaScriptEditorIndentationLineForeground"		Color="#363636"	/>
          	<SolidColorBrush po:Freeze="true" x:Key="NinjaScriptEditorKeywordForeground"				      Color="LightBlue"	/>
          	<SolidColorBrush po:Freeze="true" x:Key="NinjaScriptEditorLineNumbersBackground"			    Color="#1e1e1e"		/>
          	<SolidColorBrush po:Freeze="true" x:Key="NinjaScriptEditorLineNumbersForeground"			    Color="#E9E9E9"		/>
          	<SolidColorBrush po:Freeze="true" x:Key="NinjaScriptEditorNumberForeground"					      Color="#22CDFF"		/>
          	<SolidColorBrush po:Freeze="true" x:Key="NinjaScriptEditorStringForeground"					      Color="#0076EC"		/>
          	<SolidColorBrush po:Freeze="true" x:Key="NinjaScriptEditorSyntaxErrorForeground"			    Color="Red"			/>
          	<SolidColorBrush po:Freeze="true" x:Key="NinjaScriptEditorPlainTextForeground"				    Color="#F3F2F1"		/>
          	<SolidColorBrush po:Freeze="true" x:Key="NinjaScriptEditorErrorGridBackgroundSelectedTab"	Color="Sienna"		/>
          	<SolidColorBrush po:Freeze="true" x:Key="NinjaScriptEditorErrorGridBackgroundOtherTab"		Color="OrangeRed"	/>
          	<SolidColorBrush po:Freeze="true" x:Key="NinjaScriptEditorCaretBrush"						          Color="White"		/>
          	<SolidColorBrush po:Freeze="true" x:Key="NinjaScriptEditorWarningDotBrush"					Color="Yellow"		/>
          	<SolidColorBrush po:Freeze="true" x:Key="NinjaScriptEditorErrorDotBrush"					Color="Red"			/>
          	<SolidColorBrush po:Freeze="true" x:Key="FontSelectionBrush" Color="DimGray" />
          Thanks sledge. Another step, closer to the solution

          I've changed that DarkRed to Lime but seen no change.
          I use a Color Picker tool and find that the impossible-to-read color of @"text" is Maroon (hex #800000). Search the entire BluePrint.xaml for the word "maroon" or "800000" but they are not found.

          I'm opening other xaml files to check.

          Thank you very much sledge.
          ninZa
          NinjaTrader Ecosystem Vendor - Ninza

          Comment


            #6
            It might not be accessible to us Or has a name not listed here.

            Try changing the other ones to see if they have any effect. (Like the numbers).

            You did restart NT, correct?

            Comment


              #7
              Originally posted by sledge View Post
              It might not be accessible to us Or has a name not listed here.

              Try changing the other ones to see if they have any effect. (Like the numbers).

              You did restart NT, correct?
              Yes, I even restarted my computer
              I'm digging, but no hope so far

              We will have to wait for NT staff tomorrow.
              ninZa
              NinjaTrader Ecosystem Vendor - Ninza

              Comment


                #8
                Originally posted by ninZa View Post
                Yes, I even restarted my computer
                I'm digging, but no hope so far

                We will have to wait for NT staff tomorrow.
                I did a regular expression replace on every #FF...... color... to #FF00FF00

                Didn't help. So it doesn't look inherited from anything else. And I think I changed just about any other color that had Red or Orange... no luck

                oh well, tomorrow...

                Comment


                  #9
                  This may have been overlooked on our end, and may not actually be settable in skins. A developer is currently investigating where/how this color is set, and once we nail that down, I can submit a report to get this font exposed in skin files in the future. I'll keep you posted.
                  Dave I.NinjaTrader Product Management

                  Comment


                    #10
                    I've got an update on this one. We were overlooking this one, and since we are just talking about literal strings, we decided to connect the font to the existing "string foreground" key in BluePrint.xaml.

                    You should be able to control this with NinjaScriptEditorStringForeground starting with the Beta 10 build.
                    Dave I.NinjaTrader Product Management

                    Comment


                      #11
                      Originally posted by NinjaTrader_Dave View Post
                      I've got an update on this one. We were overlooking this one, and since we are just talking about literal strings, we decided to connect the font to the existing "string foreground" key in BluePrint.xaml.

                      You should be able to control this with NinjaScriptEditorStringForeground starting with the Beta 10 build.
                      Thank you for your kind response Dave.

                      However, NinjaScriptEditorStringForeground is already available for editing in the current version.

                      In the Slate Gray skin, this parameter is set to #0076EC, which is the light blue color for string without @ (e.g. "sample text"). --> this text color is okay.

                      However, I want to change the color of string with @ (e.g. @"sample text").
                      See my screenshot above, Dave.

                      Thanks.
                      ninZa
                      NinjaTrader Ecosystem Vendor - Ninza

                      Comment


                        #12
                        The two will be linked in the next release. NinjaScriptEditorStringForeground will affect both normal strings ("string") and literal strings (@"string") beginning in Beta 10.
                        Dave I.NinjaTrader Product Management

                        Comment


                          #13
                          Originally posted by NinjaTrader_Dave View Post
                          The two will be linked in the next release. NinjaScriptEditorStringForeground will affect both normal strings ("string") and literal strings (@"string") beginning in Beta 10.
                          Great. Thank you very much for adding this feature so quickly that it will be available in the next release.
                          ninZa
                          NinjaTrader Ecosystem Vendor - Ninza

                          Comment

                          Latest Posts

                          Collapse

                          Topics Statistics Last Post
                          Started by sgordet, Today, 10:31 PM
                          0 responses
                          1 view
                          0 likes
                          Last Post sgordet
                          by sgordet
                           
                          Started by Ilpropio, Today, 09:45 PM
                          0 responses
                          2 views
                          0 likes
                          Last Post Ilpropio  
                          Started by Revan, Today, 05:44 PM
                          1 response
                          14 views
                          0 likes
                          Last Post NinjaTrader_Marco  
                          Started by superg3, Today, 07:57 PM
                          0 responses
                          4 views
                          0 likes
                          Last Post superg3
                          by superg3
                           
                          Started by Longhornmark, Today, 07:06 AM
                          5 responses
                          35 views
                          0 likes
                          Last Post nkhoi
                          by nkhoi
                           
                          Working...
                          X