NT8 B11 OnRender not plotting anything

[Ricam]

My indicators that use OnRender to draw in the indicator panel no longer plot anything.

Here is one indicator that shows this problem, please let me know if you can duplicate, or if I messed something up when doing the version update.

This indicator should be placed in a subfolder named SampleCode.

[music_p13]

Ichimoku indicator stopped working with following error in log file:

Indicator 'MyIchimoku': Error on calling 'OnRender' method on bar 0: You are accessing an index with a value that is invalid since it is out-of-range. I.E. accessing a series [barsAgo] with a value of 5 when there are only 4 bars on the chart.

[Ricam]

Reverting to B10 for now

The indicator that I attached in my last post does not seem to work at all, even in B10, but all other indicators that use OnRemder resumed working normally after I rolled back from B11 to B10.

I think you need to uninstall B11 before going back to B10. The B11 SQL databases are different but the B10 installer does not replace them with the B10 databases. (The .sdf files, not the data files. The ones in MyDocuments and in ProgramFiles.)

[sledge]

The indicator that I attached in my last post does not seem to work at all, even in B10,

I also see the same. The one you posted only prints to the output window, nothing happens on the chart.

[-=Edge=-]

The indicator that I attached in my last post does not seem to work at all, even in B10, but all other indicators that use OnRemder resumed working normally after I rolled back from B11 to B10.

I use OnRender rather extensively and have not had any problems in B11... (other than making some modification to use absolute index lookups as mentioned in the code breaking changes)

http://ninjatrader.com/support/helpGuides/nt8/en-us/?8_0_0_11.htm

I didn't analyze your logic to figure out exactly what it was suppose to do, and didn't try using it in the subfolder, but removing the SampleCode from your namespace, and sticking it in the normal indy folder seems to render fine.. Maybe that is where there is a problem...

[Ricam]

Clarification

I have several other indicators besides the buggy OnRender example that worked fine on B10 and don't plot anything on B11, where the OnRender method throws out of range errors on every bar.

For now i have rolled back to B10, pending clarification from Ninjatrader..

[NinjaTrader_PatrickH]

Hello Ricam,

Thank you for your post.

Using your indicator in Beta 10 and Beta 11 I see no rendering until I apply the indicator to the Input Series' panel. Do I need to add something specific to see this work on the indicator panel?

[music_p13]

Hello Ricam,

Thank you for your post.

Using your indicator in Beta 10 and Beta 11 I see no rendering until I apply the indicator to the Input Series' panel. Do I need add something specific to see this work on the indicator panel?

Could you try Ichimoku indicator from following thread?

http://ninjatrader.com/support/forum/showthread.php?t=80674&highlight=Ichimoku

And indicator is :http://ninjatrader.com/support/forum...3&d=1452570032

Or same one is attached here.

It used to work on all Betas until B11.

In B11 I tried "Range" bar on EURUSD and got an error in log:
5/16/2016 2:48:57 PM Default Indicator 'phIchimokuCloud_R1': Error on calling 'OnBarUpdate' method on bar 10792: Index was outside the bounds of the array.


Or on minute chart I got following:
Time Category Message
5/16/2016 2:52:53 PM Default Indicator 'phIchimokuCloud_R1': Error on calling 'OnRender' method on bar 0: You are accessing an index with a value that is invalid since it is out-of-range. I.E. accessing a series [barsAgo] with a value of 5 when there are only 4 bars on the chart.

Thanks

[Ricam]

GetValueAt() fixed it

I don't see anything in the code of the sample indicator that explains why it only works in the price panel. Strange....

I think it was a Ninjatrader reference sample.

In any event, the problems with my custom indicators in B11 went away when I used GetValueAt(Bar Index) to get the values of the series, instead of just using [bars back] in brackets.

[NinjaTrader_PatrickH]

There have been changes to OnRender in Beta 11. Specifically the following in relation to Ricam's case:

In some scenarios, the OnRender() method no longer guarantees the bars indexer to be up to date before it is called. Due to the multi-threaded nature of NinjaTrader, attempting to access a series barsAgo value could return seemingly unexpected results (E.g., Close[0], SMA(20)[0], etc). This change does NOT impact data driven events, such as OnBarUpdate(), OnMarketData(), OnOrderUpdate(), etc. For all OnRender() purposes, you should consider using an absolute index lockup through Bars.GetClose(barIndex), or <series>.GetValueAt(barIndex) which are generally more reliable in non-data driven events. Please also see the new IsValidDataPointAt() which was added to help with absolute index look up.

Taken from the following link: http://ninjatrader.com/support/helpG...s/8_0_0_11.htm

[Ricam]

Code in the FormatPriceMarker method also needed to be updated.
As the release notes state, this change applies to all methods other than the most used Update ones.

You shouldn't just consider making this change... it is mandatory.

Remember that GetValueAt needs the bar INDEX, not the number of bars back from the Current Bar that you would use to get the value of a series in an expression like Values[0][BarsBack]. Bar INDEX is the CurrentBar bar number, which increases from left to right.

There seems to be an improvement in backfill speed in B11, but for now I can't be sure. It performed very well today.

[photog53]

OnRender went to heck

For the last several weeks we have (temporarily) suspended testing NT8 pending another beta....
Today I installed b11 today and all of the OnRender's freaked out. Some give a 'out of range' error...others just don't show anything.

Have not spent much time looking at it, but got one indicator working by removing the following piece of code...
Yval = chartScale.GetYByValue(Closes[0][myvalue]);


perhaps I resumed beta testing a bit too quickly.

[Ricam]

Just change lines like this

Yval = chartScale.GetYByValue(Closes[0][0]);
to
Yval = chartScale.GetYByValue(Closes[0].GetValueAt(CurrentBar));

or
Yval = chartScale.GetYByValue(Closes[0][1]);
to
Yval = chartScale.GetYByValue(Closes[0].GetValueAt(CurrentBar-1));


Bear in mind that the second subscript in the first expression counts back from the current bar, but that the argument of GetValueAt is the BAR INDEX of the bar that has the data you want.

If you are iterating an index starting from ChartBars.FromIndex and going ++ from there in an OnRender loop, use the value of the index as the argument for GetValueAt (instead of CurrrentBar)

[B][FONT="Century Gothic"]for(int idx = ChartBars.FromIndex; idx<=ChartBars.ToIndex; idx++)
{[INDENT]yHi= chartScale.GetYByValue(Highs[0].GetValueAt(idx));
yLo= chartScale.GetYByValue(Lows[0].GetValueAt(idx));
.. etc[/INDENT]
}[/FONT][/B]

NT8 capabilities and performance are easily an order of magnitude greater than those of NT7, making an emphasis on continuing to develop for NT7 ultimately self defeating.

[-=Edge=-]

Just change lines like this

 [FONT=Century Gothic]Yval = chartScale.GetYByValue(Closes[0][0]);[/FONT]
 to
[FONT=Century Gothic]Yval = chartScale.GetYByValue(Closes[0].GetValueAt(CurrentBar));[/FONT]

or
[FONT=Century Gothic]Yval = chartScale.GetYByValue(Closes[0][1]);[/FONT]
to
[FONT=Century Gothic]Yval = chartScale.GetYByValue(Closes[0].GetValueAt(CurrentBar-1));[/FONT]

I do not believe that is correct.. Please correct me if I'm wrong..

In some scenarios, the OnRender() method no longer guarantees the bars indexer to be up to date before it is called. Due to the multi-threaded nature of NinjaTrader, attempting to access a series barsAgo value could return seemingly unexpected results (E.g., Close[0], SMA(20)[0], etc).

Close[0]  becomes  Bars.GetClose(barindex) 
Closes[0][0]  becomes  BarsArray[0].GetClose(barindex) 
Closes[1][0]  becomes  BarsArray[1].GetClose(barindex)

Where barindex is the absolute index of the bar, not bars back..

[Ricam]

I do not believe that is correct.. Please correct me if I'm wrong..

I don't see how that is constructive.

I am not responsible for providing sample code or engaging in debates with other members.
Nevertheless, I will consider evaluating and correcting problem code affected by this issue.

My indicators that use OnRender work correctly.

Two of them are in panels 2 and 3 of the attached chart.

Please let me know if I may be of further assistance.