@Strategy.cs causes compilation problems

[misova]

Hi,

Problem:
I found problem with the @Strategy.cs file..
I was forced to update it with namespace, otherwise NT8 will not compile = reports error.

This strange behavior started to happen only after I added my own code files (AddOns). This problem does not exist in clean Ninja.

But we developers should not required to update @Strategy.cs, because this file is replaced with each NT8 release.
So this needs to be fixed.


FIX:
I fixed the problem by replacing 2 occurences of type:

[FONT="Courier New"]Indicator[/FONT]

with new

[FONT="Courier New"][COLOR="Red"]Indicators.[/COLOR]Indicator[/FONT]

How to reproduce:
You can easily reproduce the error.

I can send complete zipped Custom folder, that is fixed and compiles.
If you removed the my added namespace OR replace original @Strategy.cs file,
the compilation problem arises immediately.


Just send me an email, where I can send to zip file to reproduce this.

[NinjaTrader_PatrickH]

Hello misova,

Thank you for your patience.

Please send the .zip to platformsupport[at]ninjatrader[dot]com with 'ATTN: Patrick H - 1566361' in the subject line.

[misova]

Thank you.
Sent to email with required files and description of the problem...

[misova]

Ninja guys informed about result, what caused the problem:

You cannot organize your files within namespace, that contains name, that already NT8 occupies for its files.

For example file in this location will not compile:

AddOns\Algoritmix\OpportunityFramework\[COLOR="Blue"]Strategy[/COLOR]\Testing\BaseTestingStrategy.cs

Problem is with folder name "Strategy"
The same applies for folder "Indicator".

[junkone]

can NT check this as part of compilation and raise a error so we don't have to remember this. I am sure over time, somebody will do this mistake again.

[misova]

Definitely yes.

• This shoul be reported by user-friendly error message and
• requirements for naming folder should be added in the documentation

[misova]

Hi Patrick,

I have to re-open this issue again, because the same problem occurs again,
despite there is no folder named Indicator or Strategy, that are expected to conflict with NT8 folder names.

I had to modify @Strategy.cs and add the namespaces again, to make the whole NT8 project compile.

I submitted the whole Custom folder zipped to our last email communication.

It is the completely the same problem as previously. I hope it should not be too hard to find the cause.

Maybe there some other constraints, we developers, are not aware of right now.

[NinjaTrader_PatrickH]

Thank you all for your feedback.

I will look into this further and follow up here.

[misova]

Patrick resolved the problem and this is explanation:

Do not use namespace containing word Indicator, because it conflicts with NT8 files.

My problem was, that I had class using this namespace:

namespace NinjaTrader.[COLOR="Red"]Indicator[/COLOR]
{	
	public abstract class MyCustomClass{
        ....
}

The word "Indicator" in red color was the problem. When it was changed, it immediately worked again, without any changes required to do in file @Strategy.cs

So best overall recommendation is to not use words Strategy, Indicator

• do not use it for any folder
• do not use it in any C# namespace

In case you will do it despite warnings, expect, that compilation error can mislead you, by suggesting to make change (add namespace Indicator on 2 places) in @Strategy.cs file.

Changing @Strategy.cs file will fix the problem, but it is not root of the problem. You will do better, if you take it as symptom, that you created folder or namespace containing keywords like "Indicator" or "Strategy". If you fix this instead, you will solve the real problem and you will not need to change @Strategy.cs file.

Anyway, changing any file starting with @ is not recommended. These files are under management of NT8 and we should not change them - they can be replaced with each new release of NT8 you install.