Help on custom indicator

[richp6]

Hi,

I'm new to ninjascripting, so I'm sure there is a simple reason why my script isn't working as planned. All I'm trying to do is have the volume bar paint green if volume is greater than the 50 EMA AND the price bar closes in the top 2/3 of the bar, paint red if it closes in the bottom 2/3, and gray if neither of the above conditions are true.

Thanks in advance for any help.

Rich

[roonius]

Hi,

I'm new to ninjascripting, so I'm sure there is a simple reason why my script isn't working as planned. All I'm trying to do is have the volume bar paint green if volume is greater than the 50 EMA AND the price bar closes in the top 2/3 of the bar, paint red if it closes in the bottom 2/3, and gray if neither of the above conditions are true.

Thanks in advance for any help.

Rich

Your condition:
Close[0] > (High[0]-Low[0] *.65)

Two things:

1. It first multiplies Low[0] by 0.65 then then result is subtracted from High[0]. You should use Close[0] > (High[0] - Low[0]) * 0.65

2. It's still incorect since you are comparing absolute value with fraction of range.
If low is 900 and high is 1000 and close is 901 your condition is:
901 > (1000-900)*0.65 what makes it 901 > 65 which is true. ( you want it to be false)
So actually your condition has to be:
Close[0] > Low[0] + (High[0] - Low[0])*0.65
901 > 900 + (1000 -900)*0.65
901 > 965 - false

Same with other condition:

Close[0] < Low[0] + (High[0] -Low[0]) * 0.35

Final:

if (VOL()[0] > VOLMA(50)[0] && Close[0] > Low[0] + (High[0]-Low[0]) *0.65)
Up0.Set(Volume[0]);
else
if (VOL()[0] > VOLMA(50)[0] && Close[0] < Low[0] + (High[0]-Low[0]) *0.35)
Down0.Set(Volume[0]);
else
Close0.Set(Volume[0]);

Hope it helps

[richp6]

Boy I was sloppy. I was so concerned about the syntax I apparently lost all mathematical logic! Thanks for setting me straight on that one.