Crossabove makes this sense?

[Precisely]

Just want it to draw an arrow up if the last close is higher than the last 20 closes. Should work, or?

protectedoverridevoid Initialize()
{
PaintPriceMarkers = true; // Indicator plot values are displayed in the y axis
CalculateOnBarClose = true;
Overlay = true;
PriceTypeSupported = true;
}
///<summary>
/// Called on each bar update event (incoming tick)
///</summary>
protectedoverridevoid OnBarUpdate()
{
if (CrossAbove(Close, MAX(Close, period), 1))
DrawArrowUp("up arrow" + CurrentBar, true, 0, MAX(Close, period)[0], Color.Green);
　
}

[NinjaTrader_Tim]

Hi Precisely,

In the CrossAbove(), instead of MAX(Close, period),

try

MAX(Close, period)[1]

With MAX(Close, period), the current bar is being included when looking for the maximum value. So if the current close is the highest, the condition is trying to check if the current close is crossing above the current close, which will never occur.

With MAX(Close, period)[1], the MAX() looks at values starting with the previous bar, then looks back.

[Precisely]

Thank you for your reply Tim.

Don't get it to work I'm afraid. Do you mean

if (CrossAbove(Close, MAX(Close, period)[1])) ?

[NinjaTrader_Tim]

Hi Precisely,

Yes, the MAX inside of the CrossAbove.

So, something like...

(CrossAbove(Close, MAX(Close,period)[1], 1))

[Precisely]

It compiles with no errors, but no arrows I'm afraid (tried different periods).

protectedoverridevoid OnBarUpdate()
{
if (CrossAbove(Close, MAX(Close, period)[1],1))
DrawArrowUp("up arrow" + CurrentBar, true, 0, MAX(Close, period)[1], Color.Green);
}

[NinjaTrader_Tim]

Hi Precisely,

The MAX can stay the same in the DrawArrowUp, if you want it to draw at the current bar height...

if (CrossAbove(Close, MAX(Close, 5)[1],1))
DrawArrowUp("up arrow" + CurrentBar, true, 0, MAX(Close, 5)[0], Color.Green);

With that change, do you receive any errors in the Log tab in the Control Center?

[Precisely]

Yepp, I get this one:

2010-03-15 17:48:29 Default Error on calling the 'OnBarUpdate' method for indicator 'Turtle' on bar 0: Index was out of range. Must be non-negative and less than the size of the collection.
Parameter name: index

[NinjaTrader_Tim]

Hi Precisely,

You can add the following at the top of the OnBarUpdate()
if (CurrentBar < 1)
return;

To avoid this in the future, please see the following...

http://www.ninjatrader-support2.com/vb/showthread.php?t=3170

[Precisely]

Great, now it works fine. Thank you Tim.

[bert1]

Tim having trouble painting arrows on chart with RSI. Want up arrows under bars when RSI is at or above 70 and down arrows above bars when RSI is at or below 30...is this difficut? I added this code to a generic RSI code but nothing was on chart. I spent a lot of time on what seems to be easy :-( any help appreciated

Thanks!

PaintPriceMarkers = true;
DrawOnPricePanel = true;
if (CrossAbove(RSI(14, 1), 70, 1))
DrawArrowUp("rsi up" + CurrentBar, false, 0, Low[0], Color.Green);
elseif (CrossBelow(RSI(14, 1), 30, 1))
DrawArrowDown("rsi down" + CurrentBar, false, 0, High[0], Color.Red);

[Precisely]

This is the code I finally used. Maybe you can twiggle it a bit and get it to work.


protectedoverridevoid OnBarUpdate()
{
if (CurrentBar < 1)
return;
if (Close[0] > Close[1])


if (CrossAbove(Close, MAX(Close, periodup)[1],1))
DrawArrowUp("up arrow" + CurrentBar, true, 0, MAX(Close, periodup)[0], Color.Green);

if (CrossBelow(Close, MIN(Close, perioddown)[1], 1))
DrawArrowDown("down arrow" + CurrentBar, true, 0, MIN(Close, perioddown)[0]+TickSize, Color.Red);
}

[NinjaTrader_Ben]

Hello,

I saw that you are missing a bracket shown in red below:

if (Close[0] > Close[1])
{