Announcement

Collapse

Looking for a User App or Add-On built by the NinjaTrader community?

Visit NinjaTrader EcoSystem and our free User App Share!

Have a question for the NinjaScript developer community? Open a new thread in our NinjaScript File Sharing Discussion Forum!
See more
See less

Partner 728x90

Collapse

Erratic exits

Collapse
X
 
  • Filter
  • Time
  • Show
Clear All
new posts

    Erratic exits

    Hello,
    I'm having a challenge with this code I wrote and wondering if someone could take a look at it. The entries are fine, but the exits are erratic. I've used Draw() and Print() to debug. Everything draws and prints correctly, but the exit only work about half the time. Here is the code:

    currenthigh = MRO(delegate {return High[0] == CurrentDayOHL().CurrentHigh[0];}, 1, 5);
    if (currenthigh > -1 && RValueCharts(Color.Blue, 3, 3).VClose[0] <= -4 && CurrentBar - mydownConditionBar >=5)
    {
    EnterShort(DefaultQuantity, "DHReversal");
    mydownConditionBar = CurrentBar;
    DrawDiamond("DailyHighReversal" + CurrentBar,true,0,Low[0] - 1,Color.DarkMagenta);
    dailyHighReversal = true;
    Print(Time[0] + " dailyHighReversal");
    }

    dmPlusCrossUp = MRO(delegate {return CrossAbove(DM(10).DiPlus, 25, 1);}, 1, 1);
    if(dmPlusCrossUp > -1 && Falling(ADX(10)) == true)
    {
    BarColor = Color.DarkBlue;
    Print(Time[0] + " dmPlusCrossUp");
    }

    if(dmPlusCrossUp > -1 && Falling(ADX(10)) == true
    && Position.MarketPosition == MarketPosition.Short && dailyHighReversal == true)
    {
    ExitShort("Exit DHReversal", "DHReversal");
    dailyHighReversal = false;
    EarlyShortExit = false;
    }

    Any help would be greatly appreciated.

    #2
    Forget it

    Alright I did it again. I figured it out. Anyone following my 2 posts so far will see that I'm answering my own questions. I guess I just need to type the problem out to see the answer. Sorry to waste time.

    Comment


      #3
      Thanks for the update CaptainAmerica. Glad to hear you were able to sort it out and discovered something about your problem solving approach. It's true - writing everything out is powerful and can help illuminate where the issue is.
      Ryan M.NinjaTrader Customer Service

      Comment

      Latest Posts

      Collapse

      Topics Statistics Last Post
      Started by bortz, 11-06-2023, 08:04 AM
      47 responses
      1,607 views
      0 likes
      Last Post aligator  
      Started by jaybedreamin, Today, 05:56 PM
      0 responses
      9 views
      0 likes
      Last Post jaybedreamin  
      Started by DJ888, 04-16-2024, 06:09 PM
      6 responses
      19 views
      0 likes
      Last Post DJ888
      by DJ888
       
      Started by Jon17, Today, 04:33 PM
      0 responses
      6 views
      0 likes
      Last Post Jon17
      by Jon17
       
      Started by Javierw.ok, Today, 04:12 PM
      0 responses
      15 views
      0 likes
      Last Post Javierw.ok  
      Working...
      X