How can I obtain the highest unrealised profit in a trade

[kaywai]

There is a "GetProfitLoss()" that I can use, and if I were to include BarsSinceEntry(), it wouldn't include the bar in which the entry was made.

Could someone please help?

Regards

Kay Wai

[NinjaTrader_Bertrand]

Kay, for this you would need to keep track of the highest open profit seen since the trade was open, easiest done by a custom variable tracking this in your code.

[kaywai]

Hi Bertrand,

I am having trouble accessing the highest open profit since entry.

If I use barssinceentry, it can track from the bar after the entry bar.

If I wanted to track this on a real-time basis, I would have to use cobc = false if I were to use a custom variable, is that correct? That may mean re-writing my entire code!

I want to track the highest profit specifically on the entry bar so that if a desired profit is hit, I can exit the trade on that bar. Any other suggestions?

Regards

Kay Wai

[bukkan]

If I wanted to track this on a real-time basis, I would have to use cobc = false if I were to use a custom variable, is that correct? That may mean re-writing my entire code!

you can put the relevant codes in OnMarketData. this will ensure the calculations is done in rt even when cobc is set to true.

[NinjaTrader_RyanM1]

Thanks bukkan. OnMarketData is great for getting real time values.

You could use something like this for historical long positions.

Variables Region:
private double HighestHighinTrade;

if (Position.MarketPosition == MarketPosition.Long)
HighestHighinTrade = Position.GetProfitLoss(MAX(High, BarsSinceEntry() + 1)[0], PerformanceUnit.Currency);

Would use MIN and Low for shorts.

[kaywai]

Hi Ryan,

Thanks for that. Just one question pertaining to barssinceentry. It omits the entry bar but includes all future bars for the trade, right?

If that were the case, then I would only be getting unrealized profit or loss from the next bar after the entry bar if I were to use your sample code, right?

Regards

Kay Wai

[NinjaTrader_RyanM1]

BarsSinceEntry returns a value. The entry bar is when BarsSinceEntry == 0.

In the example there, it functions as a dynamic lookback value for MAX. Lookbacks should always be >= 1, hence the + 1 in the (corrected) example.

That expression will include the entry bar in its lookback.

[kaywai]

Hi Ryan,

Thank you for that piece of code. Appreciate it.

If I could just trouble with one more query.....

1) What if I only wanted to track the unrealised pnl of the bar of entry? How would I do that with your code?

Regards

Kay Wai

[NinjaTrader_RyanM1]

For long positions, would be:

double myEntryBarHigh = High[BarsSinceEntry()];

[kaywai]

No +1 needed for the lookback?

And assuming all this is done in OnMarketData, right?

[NinjaTrader_RyanM1]

No, in this case BarsSinceEntry is not used in a lookback, but in the bar indexing. Bar indexes start at 0 so no need for +1. This works in bars, most commonly accessed in OnBarUpdate(), although you can access bar objects from OnMarketData.

If you wanted to work in OnMarketData, best would be to create your own custom technique for storing values. OnMarketData is a stream of bid/ask/last updates. There's no built in indexing system for accessing prior values in OnMarketData.