Heikin Ashi Indicator

[Wi!s0n]

It appears there is a disparity between the Heikin Ashi calculation by Ninjatrader and that of Dan Valcu's original article in S&C Feb 2004. Specifically the calculation of the maximum high and minimum low as follows;
haHigh = Maximum(H, haOpen, haClose)
haLow = Minimum(L, haOpen, haClose)

The Heiken Ashi indicator in Ninjatrader does not use the haClose in these calculations. Not being a programmer, when I add the "HAClose" to lines 75 and 76, I get an error. The Math.Max and Math.Min take 2 arguments and not 3 and here I have added a 3rd. Can someone please offer a simple correction? Thanks.

[NinjaTrader_Joydeep]

Hello Wi!s0n,
Thanks for your note.

I will forward your feedback to development for future consideration.

[koganam]

It appears there is a disparity between the Heikin Ashi calculation by Ninjatrader and that of Dan Valcu's original article in S&C Feb 2004. Specifically the calculation of the maximum high and minimum low as follows;
haHigh = Maximum(H, haOpen, haClose)
haLow = Minimum(L, haOpen, haClose)

The Heiken Ashi indicator in Ninjatrader does not use the haClose in these calculations. Not being a programmer, when I add the "HAClose" to lines 75 and 76, I get an error. The Math.Max and Math.Min take 2 arguments and not 3 and here I have added a 3rd. Can someone please offer a simple correction? Thanks.

Math.Max and Math.Min are pairwise operators. You have to use successive invocations to use them to evaluate multiple values.

[FONT=Courier New]HAHigh.Set(Math.Max(HAClose[[COLOR=#800080][FONT=Courier New][COLOR=#800080]0[/COLOR][/FONT][/COLOR][/FONT][FONT=Courier New]], Math.Max(High[[/FONT][FONT=Courier New][COLOR=#800080][FONT=Courier New][COLOR=#800080]0[/COLOR][/FONT][/COLOR][/FONT][FONT=Courier New]], HAOpen[[/FONT][FONT=Courier New][COLOR=#800080][FONT=Courier New][COLOR=#800080]0[/COLOR][/FONT][/COLOR][/FONT][FONT=Courier New]]))); [/FONT][FONT=Courier New][COLOR=#008000][FONT=Courier New][COLOR=#008000]// Calculate the high[/COLOR][/FONT][/COLOR][/FONT]
[FONT=Courier New]HALow.Set(Math.Min(HAClose[[COLOR=#800080][FONT=Courier New][COLOR=#800080]0[/COLOR][/FONT][/COLOR][/FONT][FONT=Courier New]], Math.Min(Low[[/FONT][FONT=Courier New][COLOR=#800080][FONT=Courier New][COLOR=#800080]0[/COLOR][/FONT][/COLOR][/FONT][FONT=Courier New]], HAOpen[[/FONT][FONT=Courier New][COLOR=#800080][FONT=Courier New][COLOR=#800080]0[/COLOR][/FONT][/COLOR][/FONT][FONT=Courier New]]))); [/FONT][FONT=Courier New][COLOR=#008000][FONT=Courier New][COLOR=#008000]// Calculate the low[/COLOR][/FONT][/COLOR][/FONT]

However, analysis of the logic of the math of the equations shows that it really is not necessary to make that evaluation. For the HAHigh, you are seeking the maximum value of the High, HAOpen, and HAClose on the same bar. The HAClose can NEVER be higher than the High, so there is no need to evaluate if it is. Similarly, the HAClose can NEVER be lower than the Low, so there is no need to evaluate that either, for the HALow.

The fact that the original describer of the technique did not realize the redundancy in the math, does not preclude coding the conditions more efficiently.

IOW, the only reason that I posted the code, is to demonstrate how to find the Max or Min value of multiple variables. In the particular case of the Heiken Ashi, using that code goes beyond pointless: it actually increases the complexity of the evaluation, and, to boot, CPU utilization, to no effective purpose. Granted the cost of one extra evaluation is miniscule in the grand scheme of things, it is still a bad idea to write code that is absolutely useless in terms of evaluation of its ultimate goal.

[Wi!s0n]

Thank you, Koganam

Certainly a more thoughtful and respectful reply than simply, "I will forward your feedback to development for future consideration."

[NinjaTrader_Joydeep]

Hello Wi!s0n,
We modified the indicator and tested it further. However functionally we didnt find any difference.

I am attaching the modified indicator. Please let us know if you find any difference between the original HeikenAshi indicator and the modified (HeikenAshi1) indicator.

[Wi!s0n]

Thank you Joydeep.

[koganam]

Hello Wi!s0n,
We modified the indicator and tested it further. However functionally we didnt find any difference.

I am attaching the modified indicator. Please let us know if you find any difference between the original HeikenAshi indicator and the modified (HeikenAshi1) indicator.

Just curious, but what was the point? I have already given a detailed mathematical explanation of why the modification to test the Close is unnecessary. In point of fact, not just unnecessary, but actually bad practice.