I opened up an old indicator I had previously programmed to make some changes. This was one of the first I had done in NinjaScript, and at the time I had a habit of doing all my calculations, storing the result into a double, and then using Set to store the double into a DataSeries.
Like this for example....
Later, I came to believe that this step was redundant, and have since been skipping the store in double first step, like this...
The above is from the default ATR code...
So today, I had was working on my old indicator where I did my calculations outside the Set method, stored the result in a double, and then stored the double into the DataSeries with the Set method.... here's the code section...
This version of the code plotted like this....
Which I am really happy with, because it exactly matches the chart Published in Ehlers' article below:
But thinking that it was a redundant step to first store the calculation result in a double, I refactored the code to this....
if (Math.Abs(InPhase[0] + InPhase[1]) > 0)
{
tangent = Math.Abs((Quadrature[0]+Quadrature[1])/(InPhase[0]+InPhase[1]));
atanRadians = Math.Atan(tangent);
Phase.Set(atanRadians*(180/Math.PI));
}
To my shock this code plots very differently... the result is way off...
The max reading is much higher than before... especially in a percentage basis, as this indicator can only range between 6 and 50.... At Max reading on this chart, its a difference of 15.83 points...
Moving the atanRadians*(180/Math.PI) line inside the Set parens is the only change needed to make such a drastic change.
So now I am wondering why?
I know an easy answer would be, so don't do it like that then.... but I want to know why its doing it, because we often see calculations done inside the Set method line....
Like this for example....
Code:
phaseTemp = atanRadians*(180/Math.PI);
Phase.Set(phaseTemp);
Code:
Value.Set(((Math.Min(CurrentBar + 1, Period) - 1 ) * Value[1] + trueRange) / Math.Min(CurrentBar + 1, Period));
So today, I had was working on my old indicator where I did my calculations outside the Set method, stored the result in a double, and then stored the double into the DataSeries with the Set method.... here's the code section...
Code:
if (Math.Abs(InPhase[0] + InPhase[1]) > 0)
{
tangent = Math.Abs((Quadrature[0]+Quadrature[1])/(InPhase[0]+InPhase[1]));
atanRadians = Math.Atan(tangent);
phaseTemp = atanRadians*(180/Math.PI);
Phase.Set(phaseTemp);
}
Which I am really happy with, because it exactly matches the chart Published in Ehlers' article below:
But thinking that it was a redundant step to first store the calculation result in a double, I refactored the code to this....
if (Math.Abs(InPhase[0] + InPhase[1]) > 0)
{
tangent = Math.Abs((Quadrature[0]+Quadrature[1])/(InPhase[0]+InPhase[1]));
atanRadians = Math.Atan(tangent);
Phase.Set(atanRadians*(180/Math.PI));
}
To my shock this code plots very differently... the result is way off...
The max reading is much higher than before... especially in a percentage basis, as this indicator can only range between 6 and 50.... At Max reading on this chart, its a difference of 15.83 points...
Moving the atanRadians*(180/Math.PI) line inside the Set parens is the only change needed to make such a drastic change.
So now I am wondering why?
I know an easy answer would be, so don't do it like that then.... but I want to know why its doing it, because we often see calculations done inside the Set method line....
Comment