Logical OR ?

[mefTrader]

I have the following statement but the logical OR is not working - am I using the correct syntax?

if (Trend_flo == 1)
{
if ((Open[0] <= TrStop[0]) | (High[0] <= TrStop[0]) | (Low[0] <= TrStop[0]) | (Close[0] <= TrStop[0]))
{
Trend_flo =0;
BarColor = Color.Magenta;
//Print("End of Trend_flo Long: "+ Trend_flo);
Print("TrStop: Barnumber "+ CurrentBar+" is "+TrStop[0]+" Trendflo is "+Trend_flo);
}
else
{
if (LastBar < CurrentBar)
{

if (Close[0] > Close[1]) TrStop.Set(Low[0] - StDev * 1.382);
if (Low[0] - High[1] > StDev) TrStop.Set(Low[0] - StDev * 0.618);
if (TrStop[0] < TrStop[1]) TrStop.Set(TrStop[1]);
if (TrStop[0] == 0) TrStop.Set(Close[0]);
DrawDot("", true, 0, TrStop[0], Color.Orange);
BarColor = Color.Blue;
Print("TrStop: Barnumber "+ CurrentBar+" is "+TrStop[0]+" Trendflo is "+Trend_flo);
}

}
}

At Bar 22 Trendflo==1 and from BAr 23 -38 the code in orange is working correctly but at Bar Number 39 the current Low is less than Trstop '(Low[0] <= TrStop[0])' yet Trend_flo is not RESET (=0??

This is weird?

[NinjaTrader_Austin]

mefTrader, the logical OR operator uses two "pipes", not one.

||

[VTtrader]

It's 2 bars " || "

if ((Open[0] <= TrStop[0]) || (High[0] <= TrStop[0]) || (Low[0] <= TrStop[0]) || (Close[0] <= TrStop[0]))

[mefTrader]

Just tried that and does not work for me either!

if ((Open[0] <= TrStop[0]) || (High[0] <= TrStop[0]) || (Low[0] <= TrStop[0]) || (Close[0] <= TrStop[0]))
{
Trend_flo =0;
BarColor = Color.Magenta;
//Print("End of Trend_flo Long: "+ Trend_flo);
Print("TrStop: Barnumber "+ CurrentBar+" is "+TrStop[0]+" Trendflo is "+Trend_flo);
}

[NinjaTrader_Austin]

mefTrader, that is how the logical OR operator works. There is probably a bug lurking in your code somewhere. This post by Josh starts to describe the debugging process.

[mefTrader]

Yes I am using Josh's debugging process already but can not see anything glaringly obvious .

Trend_flo does not seem to get reset! when Trend_flo=1 and I have checked that all the conditions are true by printing them out to a file!

protected override void OnBarUpdate()
{
// Use this method for calculating your indicator values. Assign a value to each
// plot below by replacing 'Close[0]' with your own formula.
if (CurrentBar < length1) return;

if(Time[0].Date != Time[1].Date)
{
//Trend_flo =0;
//Print("This is a message");
//Print("Trend_flo initial condition: "+ Trend_flo);

}
double StDev = StdDev(length1)[0];
//Print("StDev: "+ StDev);
//double PerR = PercentR(length);
double HH =0.0;
double Divisor = 0.0;
HH = MAX(High, length)[0];
//Print("HH: "+ HH);
Divisor = HH - MIN(Low, length)[0];
//Print("Divisor: "+ Divisor);

if (Divisor != 0)
PercentR.Set(100 - ( ( HH - Close[0] ) / Divisor ) * 100);
else
PercentR.Set(0.0);

//Print("PercentR[0]: "+ PercentR[0].ToString());

if ((PercentR[0] >= 70) && (PercentR[1] < 70) && (Trend_flo == 0) && (Close[0] > TrStop[0]))
{
TrStop.Set(Low[0] - StDev*1.382);
DrawDot("TStop_Long", true, 0, TrStop[0], Color.Orange);
BarColor = Color.Blue;
Trend_flo = 1;
Print("This is a message");
Print("Trend_flo Long: "+ Trend_flo);
LastBar = CurrentBar;
Print("TrStop: Barnumber "+ CurrentBar+" is "+TrStop[0]+" Trendflo is "+Trend_flo);
}

if ((PercentR[0] <= 30) && (PercentR[1] > 30) && (Trend_flo == 0) && (Close[0] < TrStop[0]))
{
TrStop.Set(High[0] + StDev*1.382);
DrawDot("TStop_Short", true, 0, TrStop[0], Color.Yellow);
BarColor = Color.Red;
Trend_flo = -1;
Print("Trend_flo Short: "+ Trend_flo);
LastBar = CurrentBar;
}

if (Trend_flo == 1)
{
if ((Open[0] <= TrStop[0]) || (High[0] <= TrStop[0]) || (Low[0] <= TrStop[0]) || (Close[0] <= TrStop[0]))
{
Trend_flo =0;
BarColor = Color.Magenta;
//Print("End of Trend_flo Long: "+ Trend_flo);
Print("TrStop: Barnumber "+ CurrentBar+" is "+TrStop[0]+" Trendflo is "+Trend_flo);
}
else
{
if (LastBar < CurrentBar)
{

if (Close[0] > Close[1]) TrStop.Set(Low[0] - StDev * 1.382);
if (Low[0] - High[1] > StDev) TrStop.Set(Low[0] - StDev * 0.618);
if (TrStop[0] < TrStop[1]) TrStop.Set(TrStop[1]);
if (TrStop[0] == 0) TrStop.Set(Close[0]);
DrawDot("TStop_Long"+ CurrentBar, true, 0, TrStop[0], Color.Orange);
BarColor = Color.Blue;
Print("TrStop: Barnumber "+ CurrentBar+" is "+TrStop[0]+" Trendflo is "+Trend_flo);
}

}
}

if (Trend_flo == -1)
{
if ((Open[0] >= TrStop[0]) || (High[0] >= TrStop[0]) || (Low[0] >= TrStop[0]) || (Close[0] >= TrStop[0]))
{
Trend_flo =0;
BarColor = Color.Magenta;
Print("TrStop: Barnumber "+ CurrentBar+" is "+TrStop[0]+" Trendflo is "+Trend_flo);
}
else
{
if (LastBar < CurrentBar)
{
if (Close[0] < Close[1]) TrStop.Set(High[0] + StDev * 1.382);
if (Low[1] - High[0] > StDev) TrStop.Set(High[0] + StDev * 1.382);
if (TrStop[0] > TrStop[1]) TrStop.Set(TrStop[1]);
if (TrStop[0] == 0) TrStop.Set(Close[0]);
DrawDot("TStop_Short"+ CurrentBar, true, 0, TrStop[0], Color.Yellow);
BarColor = Color.Red;
Print("TrStop: Barnumber "+ CurrentBar+" is "+TrStop[0]+" Trendflo is "+Trend_flo);
}

}
}

// Set the plot value
Trend.Set(Trend_flo);
//Trend.Set(1);

}

[NinjaTrader_Austin]

mefTrader, unfortunately we are unable to provide debugging services due to bandwidth limitations.

[mefTrader]

The following logic works

if ((Open[0] <= TrStop[1]) || (High[0] <= TrStop[1]) || (Low[0] <= TrStop[1]) || (Close[0] <= TrStop[1])

trying to understand why Open,High, Low, Close are evaluated first and have to reference the previous TrStop state - is for timing purposes - 'race conditions on logic'? i.e. classic '<=' versus = type assignments?

BTW took my code directly from TS and seems to interpret it differently.

[NinjaTrader_Austin]

mefTrader <= means less than or equal to. It is a comparison, not an assignment (like = is).

NT and TS operate very different. I suspect that is where some of these problems are coming from.