CurrentBar processing wrong?

[BillyRayValentine]

Hi,

The attached code doesnt seem to be processing CurrentBar as I would expect. It is supposed to process each bar in a chart from left to right to detect price gaps.

When I apply this indicator to a chart (daily chart from Yahoo data) it appears (from looking at the output window) that 'CurrentBar' isnt updating after each loop. The indicator gets stuck on the first pair of bars. What am I doing wrong? I have added "prints" so I can see what the code is doing.

Thanks!

[NinjaTrader_Brett]

Hello,

Thank you for your first forum post!

Most likely you need to make sure you have enough bars before you start to calculate.

Please do the following to make sure that you have at lease 10 bars for example before you start calculating.

http://www.ninjatrader.com/support/forum/showthread.php?t=3170

Let me know if I can be of further assistance.

[BillyRayValentine]

Hi Brett,

Thanks for the reply.
I believe I am checking for case of first bar of data (indicator requires at least two bars to determine a gap).
Also, I tried this on a chart of 365 days data. No matter how many days of data are in my chart, the code processes the first two bars in the wrong order then uses the same data for each iteration of the loop for all remaining days. It it looping for the correct number of days I think, its just that the local variables are not being updated with the data from the current bar - it keeps using the price data from the first bar.

[NinjaTrader_JoshP]

BillyRayValentine,

In your code you cannot access [] index values until those bars actually exist. Each bar is processed starting from the left to right. When you are on the very very first bar of the chart no such index of [1] exists and you cannot access it. This is what you need to be mindful of in your code through the tip Brett linked. Please add checks in your code to ensure you have enough bars prior to trying to access the index values.

If you are trying to access the prior bar that means you need at least 2 bars on your chart before your code should ever do anything. That means

if (CurrentBar < 1)
     return;

[BillyRayValentine]

Ok, got it working now.

I was checking for 'CurrentBar == 0' but as you pointed out I was assigning my variables before this check.
Also, I found that I had to replace the CurrentBar dataseries with 0 and 1 for current period and previous period.

Thanks for the responses guys!