Modification of Swing Indicator

[zaza5000]

Hi,

Is it possible to modify the swing indicator, such that it will keep plotting all the swings until the market moves above / below?

In other words, when a new swing high or low is detected, that just will become a new plot, rather than becoming the new value of the current swing high/low plot.

And the plots will be removed once they are broken.

Thanks

[NinjaTrader_RyanM1]

Hi zaza5000,

It may be possible. Unfortunately we do not provide custom coding services but hopefully another community member can offer to modify for you.

If you are interested in tackling this on your own, can edit the existing swing code by clicking Tools > Edit NinjaScript > indicator > Open Swing. From the NinjaScript editor: Right Click > Save As to make a copy.

If you are interested in having this professionally developed, you may consider a NinjaScript consultant for this:

http://www.ninjatrader.com/partners#NinjaScript-Consultants

[zaza5000]

I am interested in tackling this myself, but I was just seeking advice here, not asking for some1 to do it for me.

I am just lost on how to start.

[NinjaTrader_RyanM1]

You can start by looking at the code for the default Swing indicator provided in the platform, and then checking into what the programmatic methods provide.

http://www.ninjatrader.com/support/helpGuides/nt7/swing.htm

[zaza5000]

You can start by looking at the code for the default Swing indicator provided in the platform, and then checking into what the programmatic methods provide.

http://www.ninjatrader.com/support/h.../nt7/swing.htm

I've done that. There are only 2 plots in this code, swing high and swing low.

In the indicator that I want to develop, there will be more plots. And the problem is, the number of plots will not be constant as it is in the default swing indicator. This is the part I cannot figure out; how to have multiple plots added/removed withing the onbarupdate function.

Is there a way to do that?

Regards

[eDanny]

You will have to look into using DrawLine() instead.

Dan

[zaza5000]

You will have to look into using DrawLine() instead.

Dan

Thanks, is there a function to remove the lines drawn by the DrawLine() method when necessary?

I thought that i would name the lines say 101.50 - the actual level, so it would be easy to remove them when I want in the code by using its name.

[zaza5000]

Thanks, is there a function to remove the lines drawn by the DrawLine() method when necessary?

I thought that i would name the lines say 101.50 - the actual level, so it would be easy to remove them when I want in the code by using its name.

Actually, is there a website with a list of ninjascript functions?

I somehow cannot find it...

Thanks

[NinjaTrader_RyanM1]

Yes, there is a list of NinjaScript items here:

http://www.ninjatrader.com/support/helpGuides/nt7/alphabetical_reference.htm

[zaza5000]

Thanks a lot

DrawHorizontalLine and RemoveDrawObject functions were what I needed (and toString).

Sorry for the inconvenience

[zaza5000]

Coding adding part of the lines is easy, but I am having a little trouble with coding the removal of the lines.

Each line is tagged with value.toString() function so their names are their actual value.

To remove the lines, my idea is to store all high and low values 2 lists of a certain structure that will allow a for loop of the logic below:

for every double in [high-list] {
if high[0]>value {
RemoveDrawObject(value.toString());
--and remove this value from the list --
}}

Could anyone help me how to go about this?

Thanks a lot.

[zaza5000]

I coded the indicator but its not working properly.

I added code into the onbarupdate function such that everytime a new swing high/low of appropriate strenght is found, a horizontal line would be drawn at that level.

(lines 146-151 and lines 194-198)

Also to the beginning of the onbarupdate function, I added a certain code that will remove the horizontal lines that should be removed.

(lines 87-109)

But, in any chart that I loaded my indicator (SwingMap), only the first horizontal line is drawn, but the swing plots / rest of the horizontal lines are not drawn (I did not edit any of the rest, I just added my parts).

Why could this be happening? Is the code just breaking right after the first horizontal line is drawn (line 146)?

I attached my code.

I would appreciate any help, thanks a lot.

[NinjaTrader_Bertrand]

zaza5000, unfortunately we could not debug the custom code for you - I suggest you cut it down to the bare essentials working for you and then start to add more complexity to it to see exactly where your logic breaks - http://www.ninjatrader.com/support/f...ead.php?t=3418

[zaza5000]

zaza5000, unfortunately we could not debug the custom code for you - I suggest you cut it down to the bare essentials working for you and then start to add more complexity to it to see exactly where your logic breaks - http://www.ninjatrader.com/support/f...ead.php?t=3418

OK, I figured the problem in the code, it is where I try to remove the lines:

int k=counth-1;
while (k>=0) {
x=(double)(highs[k]);
if (x<High[0]) {
RemoveDrawObject(x.ToString());
highs.RemoveAt(counth);
k--;
counth--;
}
else k=-1;
}

With this while loop, I am trying to remove swing highs that are smaller than High[0].

highs is an ArrayList, and when a line is drawn, the double value is put into the ArrayList, and then the ArrayList is sorted (no trouble in the code there).

When I comment out this part of the code, I just have all of the lines (since non are removed), and when I have this code, it draws the first line, and then the code obviously breaks when it tries to go through this loop for the first time.

So I think the problem may be with the casting line:

x=(double)(highs[k]);

All the values stored in highs are doubles, but from it's nature ArrayList has objects in it.

Is there a way to have a list that is double?

[NinjaTrader_Bertrand]

Unfortunately Arrays and Lists are outside of the scope we can support here - I don't think you would need the cast here.