Draw objects disappearing

[CaptainAmericaXX]

Hello,
I created a simple indicator using the DrawDiamond(), but the diamonds do not appear on all occurrences and then disappear when the chart is scrolled. Here is my code.

currenthigh = MRO(delegate {return High[0] == CurrentDayOHL().CurrentHigh[0];}, 1, 5);
if (currenthigh > -1
&& RValueCharts(Color.Blue, 3, 3).VClose[0] <= -4
)
{
DrawDiamond("DailyHighReversal",true,0,Low[0]-TickSize-1,Color.DarkMagenta);
}

currentlow = MRO(delegate {return Low[0] == CurrentDayOHL().CurrentLow[0];}, 1, 5);
if (currentlow > -1
&& RValueCharts(Color.Blue, 3, 3).VClose[0] >= 4
)
{ DrawDiamond("DailyLowReversal",true,0,High[0]+TickSize+1,Color.BlueViolet);
}
Any idea as to why the diamonds would disappear? Thanks

[NinjaTrader_Matthew]

Hello CaptainAmericaXX,

Thank you for your post

Please make sure you are attaching this object to each CurrentBar that the condition is true. Your current code will only display the Diamond on the last occurrence.

Please try the modified code:

currenthigh = MRO(delegate {return High[0] ==  CurrentDayOHL().CurrentHigh[0];}, 1, 5);
            if (currenthigh > -1
                && RValueCharts(Color.Blue, 3, 3).VClose[0]  <= -4 
                )
            {
                DrawDiamond("DailyHighReversal" + CurrentBar,true,0,Low[0]-TickSize-1,Color.DarkMagenta);
            }

Noticed I added "+ CurrentBar to the DailyHighReversal string. You'd want to repeat this for the DailyLow condition/string as well.

This will create unique tags in order to include the history.

[CaptainAmericaXX]

Matthew,
Thank you for the reply. I did as you suggested, but there was no change. The diamonds are still not printing on all occurrences and then disappearing when the chart is scrolled. Any other suggestions? Thanks.

[CaptainAmericaXX]

Oh I figured out what was wrong. I included the CurrentBar in the string. It has to be "DailyHighReversal" + CurrentBar. Thanks for the Help.

[CaptainAmericaXX]

A new issue

I have a new issue with the above code that I wrote. Wondering if anyone has a suggestion. I programmed the MRO() to have a lookback of 5 bars so within those 5 bars a diamond is printed every time the RValueCharts(Color.Blue, 3, 3).VClose[0] <= -4. I would like only the first occurrence to print within that 5 bar lookback. Any suggestions? Thanks.

[NinjaTrader_Matthew]

CaptainAmericaXX,

I would suggest using CrossBelow() rather than <= -4.

When using a CrossAbove / CrossBelow condition, it will only print on the instant the condition is met and not the additional instances when the condition is true.

http://www.ninjatrader.com/support/helpGuides/nt7/index.html?crossbelow.htm

[CaptainAmericaXX]

Thank you Matthew that was a good suggestion and did work in some situations. However there are times when the VChart will, for instance, close < -4[2], -3.8[1], and -4[0]. So it crosses below -4 twice within that original 5 bar lookback period. I think I need a code that will only allow one occurrence during a lookback period and then reset after that period. Unfortunately I don't know how to write that. Any suggestions.

[NinjaTrader_RyanM1]

You can do this by capturing CurrentBar at the time of a condition, and working this captured value into your condition. I would move away from MRO for this.

#region Variables
private int myConditionBar;
#endregion

if (Close[0] > Open[0] && CurrentBar - myConditionBar >=5)
{
myConditionBar = CurrentBar;
//DrawHere
}

[CaptainAmericaXX]

Ryan,
Thank you for the reply. I'm sorry for being a little slow, but that completely went over my head. I'm using the MRO because I need to capture the instance of the High/Low and then use that instance with the VChart close. I'm not sure how to work your suggestion into the equation. Could you throw me another bone?

[NinjaTrader_RyanM1]

The CurrentBar - myConditionBar >=5 check tells the script not to check until 5 bars have passed since identifying an occurrence.

I would try it and see if it works for you. Just replace Close[0] > Open[0] with your custom condition, and add your draw statements.

[CaptainAmericaXX]

Ryan,
I'm sorry, but I'm stumped I just don't understand how to put these things together. I'm sure it's simple I'm just not grasping it. Here's my code with your suggestion:
if (currenthigh > -1
&& RValueCharts(Color.Blue, 3, 3).VClose[0] <= -4)

{
DrawDiamond("DailyHighReversal" + CurrentBar,true,0,Low[0]-1,Color.DarkMagenta);
}


if (Close[0] > Open[0] && CurrentBar - myConditionBar >=5)
{
myConditionBar = CurrentBar;
//DrawHere
}
Could you put these together in the way you were describing? Thanks

[NinjaTrader_RyanM1]

if (currenthigh > -1 && RValueCharts(Color.Blue, 3, 3).VClose[0] <= -4 && CurrentBar - myConditionBar >=5)
{
myConditionBar = CurrentBar;
DrawDiamond("DailyHighReversal" + CurrentBar,true,0,Low[0]-1,Color.DarkMagenta);
}

Be sure to also declare myConditionBar in variables region.

#region Variables
private int myConditionBar;
#endregion

[CaptainAmericaXX]

That did it. Thanks Ryan you've saved me once again!