Help! TRIN/ Arms indicator wont work..

[Johan_h]

Hi,
I came across this indicator at http://www.valtinho.com/post/Arms-In...atrader-7.aspx, and i canīt get i to work. anyone care to have a look att the code to see if itīs faulty or something? My feed suports TRIN index so it isnīt that.

thanks
/J

[sledge]

Hi,
I came across this indicator at http://www.valtinho.com/post/Arms-In...atrader-7.aspx, and i canīt get i to work. anyone care to have a look att the code to see if itīs faulty or something? My feed suports TRIN index so it isnīt that.

thanks
/J

Who is your data provider , and do you have all these symbols mapped correctly?


Add("^ADV",PeriodType.Day,1); //1
Add("^DECL",PeriodType.Day,1); //2
Add("^UVOL",PeriodType.Day,1); //3
Add("^DVOL",PeriodType.Day,1); //4

[Johan_h]

I have Kinetick as data provider so all of them is supported, but how do i know if they are mapped correctly? I can load them in a chart if that means something?

[sledge]

I have Kinetick as data provider so all of them is supported, but how do i know if they are mapped correctly?

Control Center->tools-> instrument manager

They should be on the left in your instrument list.

Verify or Add if needed -> search on each one
then EDIT, misc, Kinetick should have "IINA.Z" for ADV.

If not in your instrument list, use the LEFT arrow to move to there.

If everything checks out, and still doesn't work, bring up the output window.

Tools->Output window, and tell us about any errors there.

[Johan_h]

i get this from output ---> Error on calling 'OnBarUpdate' method for indicator 'ArmsIndex' on bar 21: Index was outside the bounds of the array.

the mapping seems to be ok.

[sledge]

i get this from output ---> Error on calling 'OnBarUpdate' method for indicator 'ArmsIndex' on bar 21: Index was outside the bounds of the array.

the mapping seems to be ok.

Is this a daily chart?

How many days of data do you have loaded on your chart? Can you try increasing that #?

Are you trying to view this in Market Replay or a live connection in SIM?

You might need to put the line

 
if (CurrentBar < 30) return;

or some # other than 30 and probably higher. Maybe 6 might work though.

http://www.ninjatrader.com/support/forum/showthread.php?t=52773&highlight=Index+bounds+array

[Johan_h]

i increased the number of days from 365 to 600 and still gets the same problem.
if i use --> if (CurrentBar < 30) return; the error comes at 30 instead of 21 and itīs the same with 6.
im in sim mode real time.
itīs a daily chart.

[Johan_h]

when I changed to

 
if(CurrentBar >= BarsRequired)
return;

it doesnīt say anything in the output but there is still something wrong because itīs not jumping forward to the next step.

 
switch(BarsInProgress) 
{ 

case 0:
adv = 0;
decl = 0; 
uvol = 0;
dvol = 0;
break;

[koganam]

Is this a daily chart?

How many days of data do you have loaded on your chart? Can you try increasing that #?

Are you trying to view this in Market Replay or a live connection in SIM?

You might need to put the line

 
if (CurrentBar < 30) return;

or some # other than 30 and probably higher. Maybe 6 might work though.





http://www.ninjatrader.com/support/f...x+bounds+array

What is the timeframe of the chart on which you are placing the indicator?

[Johan_h]

Itīs a daily chart with 365 days displayed

[koganam]

Itīs a daily chart with 365 days displayed

Nothing jumps out as being out of the bounds of any array. You are going to have to put in some Print() statements to see exactly where it is bombing out.

[Johan_h]

Nothing jumps out as being out of the bounds of any array. You are going to have to put in some Print() statements to see exactly where it is bombing out.

i have done that:

 
protected override void OnBarUpdate()
{
Print("before1");
if (CurrentBar >= BarsRequired)
Print("after1");
return;

and i get 100 "before1" prints before i get alot of alternating "before1" and "after1" prints.

[koganam]

i have done that:

 
protected override void OnBarUpdate()
{
Print("before1");
if (CurrentBar >= BarsRequired)
Print("after1");
return;

and i get 100 "before1" prints before i get alot of alternating "before1" and "after1" prints.

That will be about right as you will get 5 tick events per tick (one for each barSeries), and the default value for BarsRequired is 20.

You are going to need Print() statements in the branches of the switch statement to see if they are getting executed.

If not, then you probably have to explicitly check for the barSeries' validity, even though given that all barSeries are 1-day, one would expect that that should not be necessary.

Here is the code that I use in multi-timeframe scripts:

private int _intEscapeBars = 3; //how many bars before we start  processing, usually 1, made 3 here for illustration
private bool allBarSeriesValid = false;

 
        protected override void OnBarUpdate()
        {
           if (!allBarSeriesValid)
              {
                 for (int index = 0; index < BarsArray.Length; index++) 
                  {
                      if (CurrentBars[index] < this._intEscapeBars) return;
                      allBarSeriesValid = true;
                  } 
              }
            // the rest goes here ... 
        }

When written this way, you do not have to even think about how many Bars objects you add to the indicator: the escapes will be automatically handled, dynamically, for the correct number of Bars objects.

[Johan_h]

That will be about right as you will get 5 tick events per tick (one for each barSeries), and the default value for BarsRequired is 20.

You are going to need Print() statements in the branches of the switch statement to see if they are getting executed.

If not, then you probably have to explicitly check for the barSeries' validity, even though given that all barSeries are 1-day, one would expect that that should not be necessary.

Here is the code that I use in multi-timeframe scripts:

private int _intEscapeBars = 3; //how many bars before we start  processing, usually 1, made 3 here for illustration
private bool allBarSeriesValid = false;

 
        protected override void OnBarUpdate()
        {
           if (!allBarSeriesValid)
              {
                 for (int index = 0; index < BarsArray.Length; index++) 
                  {
                      if (CurrentBars[index] < this._intEscapeBars) return;
                      allBarSeriesValid = true;
                  } 
              }
            // the rest goes here ... 
        }

When written this way, you do not have to even think about how many Bars objects you add to the indicator: the escapes will be automatically handled, dynamically, for the correct number of Bars objects.

Okey, that made a lot of difference, thanks! i simplifyed the code using ^TRIN / ^TRINQ and now it runs through the whole code, there is one little problem thou, i canīt get a Closes[1][0] value from the ^TRIN or ^TRINQ object. any ideas? iīve attached the code. i used Print(trinValue); but it just put zeros in the output window..

[koganam]

Okey, that made a lot of difference, thanks! i simplifyed the code using ^TRIN / ^TRINQ and now it runs through the whole code, there is one little problem thou, i canīt get a Closes[1][0] value from the ^TRIN or ^TRINQ object. any ideas? iīve attached the code. i used Print(trinValue); but it just put zeros in the output window..

Try moving these lines to declare the variables as class variables.

           double tr=0;
            double trq=0;

It looks to me as if they are being unconditionally reset on every tick, no matter which barSeries generated it.