Remove a DrawTriangle

[sandman]

How do I make a drawn symbol (triangle in my case) disappear when the condition was present at the beginning of the bar but changed when the bar progresses.

The BarColor I am using, as given in the piece of code below behaves correctly but not the drawn triangle. Once drawn it remains. Makes sense of course, but is there a piece of code I could add that would make it disappear when the condition changes while the bar is in progress?

if (Close[0] > Opens[0][0]
&& Rising (LinReg(BarsArray[1],4))
...
&& LinReg(BarsArray[1],4)[0] > LinReg(BarsArray[1],9)[0]
&& Rising (LinReg(BarsArray[3],4)))

{
BarColor = barUpColor;
DrawTriangleUp("My triangle" + CurrentBar, false, 0, EMA(drawplace)[0], DrawUpColor);
}

sandman

[koganam]

How do I make a drawn symbol (triangle in my case) disappear when the condition was present at the beginning of the bar but changed when the bar progresses.

The BarColor I am using, as given in the piece of code below behaves correctly but not the drawn triangle. Once drawn it remains. Makes sense of course, but is there a piece of code I could add that would make it disappear when the condition changes while the bar is in progress?

if (Close[0] > Opens[0][0]
&& Rising (LinReg(BarsArray[1],4))
...
&& LinReg(BarsArray[1],4)[0] > LinReg(BarsArray[1],9)[0]
&& Rising (LinReg(BarsArray[3],4)))

{
BarColor = barUpColor;
DrawTriangleUp("My triangle" + CurrentBar, false, 0, EMA(drawplace)[0], DrawUpColor);
}
else RemoveDrawObject("My triangle" + CurrentBar);

sandman

Added in blue.

[NinjaTrader_PaulH]

Hello sandman,
The most convenient way to remove a draw object is with RemoveDrawObject ("name");
What i suggest is to declare a private string tmp variable and inside your code:

if (Close[0] > Opens[0][0] && Rising (LinReg(BarsArray[1],4)) ...
&& LinReg(BarsArray[1],4)[0] > LinReg(BarsArray[1],9)[0] && Rising (LinReg(BarsArray[3],4)))
{
BarColor = barUpColor;
DrawTriangleUp('My triangle' + CurrentBar, false, 0, EMA(drawplace)[0], DrawUpColor);
[B][I]tmp = "My triangle" + CurrentBar;[/I][/B]
}

Later on when you want to remove

[B][I]if (condition to remove triangle)
{
 RemoveDrawObject (tmp);
}
[/I][/B]

Here is a link to RemoveObject: http://www.ninjatrader.com/support/h...drawobject.htm



Please let me know if I can be of further assistance.

[sandman]

koganam

Thanks. I tried that and get an error message as in the attached image and have no idea what it implies. (Keep in mind I am not an expert coder. I mainly use the solution-oriented trial and error method

sandman

[koganam]

koganam

Thanks. I tried that and get an error message as in the attached image and have no idea what it implies. (Keep in mind I am not an expert coder. I mainly use the solution-oriented trial and error method

sandman

That is what happens when I see an incomplete snippet of code and assume that the entire block has been posted.

The new code that you posted shows that your if block already had an attached else block: the original posted code showed only a completed if block. You will have to remove the addition that I posted. Until we see the logic of the entire if ... else block, there is little that can be said.

Regardless, the statement to remove the drawing is correct: it is a matter of where it is to be placed.

[NinjaTrader_PaulH]

Hello sandman & koganam

To complete the loop.

The reason for the error is the sequence of the if statement.

You cannot have if - else - else if, it must be if -else if- else.

Here is a reference: http://msdn.microsoft.com/en-us/library/5011f09h.aspx

Please let me know if I can be of further assistance.

[sandman]

koganam. Sorry about that. If you could look at this here and give me a suggestion where to place it. sandman

protected override void OnBarUpdate()
{
// Ignore if there are not enough bars on charts to calculate
//if (CurrentBar < 10) return;
if (CurrentBars[0] < BarsRequired || CurrentBars[1] < BarsRequired || CurrentBars[2] < BarsRequired || CurrentBars[3] < BarsRequired)
return;

if(BarsInProgress != 0) return;

// Condition set 1a - LONG
if (Close[0] > Opens[0][0]
&& Rising (LinReg(BarsArray[1],4))
&& Rising (LinReg(BarsArray[1],9))
&& Rising (LinReg(BarsArray[2],4))
&& Rising (LinReg(BarsArray[2],9))
&& LinReg(BarsArray[2],4)[0] > LinReg(BarsArray[2],9)[0]
&& LinReg(BarsArray[1],4)[0] > LinReg(BarsArray[1],9)[0]
&& Rising (LinReg(BarsArray[3],4)))

{
BarColor = barUpColor;
DrawTriangleUp("My triangle" + CurrentBar, false, 0, EMA(drawplace)[0], DrawUpColor);
}

else if (Close[0] > Opens[0][0]
&& Rising (LinReg(BarsArray[1],4))
&& Rising (LinReg(BarsArray[1],9))
&& LinReg(BarsArray[1],4)[0] > LinReg(BarsArray[1],9)[0]
&& Rising (LinReg(BarsArray[2],4))
&& Rising (LinReg(BarsArray[2],9))
&& Rising (LinReg(BarsArray[3],4)))
{
DrawTriangleUp("My triangle" + CurrentBar, false, 0, EMA(drawplace)[0], DrawUpColor);
}

else if (Close[0] > Opens[0][0]
&& Rising (LinReg(BarsArray[1],4))
&& Rising (LinReg(BarsArray[1],9))
&& LinReg(BarsArray[2],4)[0] > LinReg(BarsArray[2],9)[0]
&& Rising (LinReg(BarsArray[2],4))
&& Rising (LinReg(BarsArray[2],9))
&& Rising (LinReg(BarsArray[3],4)))
{
DrawTriangleUp("My triangle" + CurrentBar, false, 0, EMA(drawplace)[0], DrawUpColor);
}

else if (Close[0] > Opens[0][0])
{
BarColor = Color.Empty;
}

// Condition set 2a - SHORT etc.

[koganam]

koganam. Sorry about that. If you could look at this here and give me a suggestion where to place it. sandman

protected override void OnBarUpdate()
{
// Ignore if there are not enough bars on charts to calculate
//if (CurrentBar < 10) return;
if (CurrentBars[0] < BarsRequired || CurrentBars[1] < BarsRequired || CurrentBars[2] < BarsRequired || CurrentBars[3] < BarsRequired)
return;

if(BarsInProgress != 0) return;

// Condition set 1a - LONG
if (Close[0] > Opens[0][0]
&& Rising (LinReg(BarsArray[1],4))
&& Rising (LinReg(BarsArray[1],9))
&& Rising (LinReg(BarsArray[2],4))
&& Rising (LinReg(BarsArray[2],9))
&& LinReg(BarsArray[2],4)[0] > LinReg(BarsArray[2],9)[0]
&& LinReg(BarsArray[1],4)[0] > LinReg(BarsArray[1],9)[0]
&& Rising (LinReg(BarsArray[3],4)))

{
BarColor = barUpColor;
DrawTriangleUp("My triangle" + CurrentBar, false, 0, EMA(drawplace)[0], DrawUpColor);
}

else if (Close[0] > Opens[0][0]
&& Rising (LinReg(BarsArray[1],4))
&& Rising (LinReg(BarsArray[1],9))
&& LinReg(BarsArray[1],4)[0] > LinReg(BarsArray[1],9)[0]
&& Rising (LinReg(BarsArray[2],4))
&& Rising (LinReg(BarsArray[2],9))
&& Rising (LinReg(BarsArray[3],4)))
{
DrawTriangleUp("My triangle" + CurrentBar, false, 0, EMA(drawplace)[0], DrawUpColor);
}

else if (Close[0] > Opens[0][0]
&& Rising (LinReg(BarsArray[1],4))
&& Rising (LinReg(BarsArray[1],9))
&& LinReg(BarsArray[2],4)[0] > LinReg(BarsArray[2],9)[0]
&& Rising (LinReg(BarsArray[2],4))
&& Rising (LinReg(BarsArray[2],9))
&& Rising (LinReg(BarsArray[3],4)))
{
DrawTriangleUp("My triangle" + CurrentBar, false, 0, EMA(drawplace)[0], DrawUpColor);
}

else if (Close[0] > Opens[0][0])
{
BarColor = Color.Empty;
}

// Condition set 2a - SHORT etc.

That depends on what you really want to do. You can put it as the final else block, if it is what is to happen if NONE at all of all the preceding blocks is entered. If you want the Triangle removed also when you set BarColor to Color.Empty, or only when you meet that condition, then you may have to put the same statement in that block (just the bare statement, without the else; as you cannot have an else clause inside an if block.)

[sandman]

That depends on what you really want to do. You can put it as the final else block, if it is what is to happen if NONE at all of all the preceding blocks is entered. If you want the Triangle removed also when you set BarColor to Color.Empty, or only when you meet that condition, then you may have to put the same statement in that block (just the bare statement, without the else; as you cannot have an else clause inside an if block.)

koganam (and also Paul),

Now I think I have got enough information from you to test it out tomorrow.

Thank you.

sandman

[sandman]

koganam and Paul.

It was a matter of placing it in the right place in the code and after some attempts I got it figured out, tested it for a few days and it works as intended. Thanks to both of you.

Another question in this context: Is it possible to vary the size of the drawing symbol, in this case an arrow up or arrow down? I attach a screenshot which shows the arrows and the part of the code I am using to create the arrows.

sandman

[NinjaTrader_PaulH]

Hello Sandman,

Thanks for your post. Glad you have that working.

I am not aware of a way to vary the size of the symbol directly through the DrawArrow. I have seen where it is possible to use DrawText and then using a symbol type font that you can acccomplish that (by changing the font size of the drawn symbol). Here is a reference to an older thread on the subject: http://www.ninjatrader.com/support/f...nge+size+arrow.