For Loop Help With Current Check

[ij001]

Hi there,

I have a for loop below to calculate heiken shi inside bars. It works for a few bars then gives the common error on bar 50. I am not sure why on bar 50 it can't compute anymore?

The common check of BarsRequired did not work. What would make it work under these conditions?

Error on calling 'OnBarUpdate' method for indicator 'itTestCode' on bar 50: You are accessing an index with a value that is invalid since its out of range. I.E. accessing a series [barsAgo] with a value of 5 when there are only 4 bars on the chart.

if (CurrentBar < BarsRequired)
return;


#region Inside Bars

double currentBarRealBody = Math.Abs(HeikenAshi().HAClose[0] - HeikenAshi().HAOpen[0]);

for (int i = 0; currentBarRealBody < Math.Abs(HeikenAshi().HAClose[i+1] - HeikenAshi().HAOpen[i+1]); i++)
{
if (i >= 3) // if there is 3 inside bars
{
DrawArrowUp("MyArrowUp2"+CurrentBar, 0, Low[0], Color.Black);
}
}

[NinjaTrader_PatrickH]

Hello ij001,

Thank you for your post.

I do not see how this for loop would ever stop, are you using break at all?

[ij001]

No this is it. I don't follow why won't it stop once the currentBarRealBody is greater than the initial real body? Also where would break go and how does it work?

[koganam]

No this is it. I don't follow why won't it stop once the currentBarRealBody is greater than the initial real body? Also where would break go and how does it work?

Because whenever the CurrentBar is the smallest bar on the chart, your loop exit condition cannot be satisfied, and so your loop index will eventually exceed the barCount.

You should not use an uncontrolled quantity as your loop exit condition. If you must insist on what you are doing, then use your current test condition inside the loop itself, and increment a counter.

Keep your loop conditions kosher by limiting the loop iterations to the bars available to process, or less.

[NinjaTrader_PatrickH]

Hello ij001,

Thank you for your response.

You are correct, that it will continue as long as the condition is true - but this means it never stops if the condition is true. Is there a max number of inside bars you are looking for?

[ij001]

My bad, I didn't understand so I decided to go back and create an if statement and increment myself. It has worked.

if (currentbar is inside previous bar [i+1])
i++
// draw
else
i=0;

Thanks for the help!