Draw elements are pl

[Shai Samuel]

Hi,

I wrote a custom indicator that is set to show intrabar (Calc on bar closed=false). The indicator draw on the char intrabar, but the drawn elements are shown on the closed bar before the current intra bar. Attached is the screen and below is the code:

        protected override void OnBarUpdate()
        {
		//...

		if (longValue > 0)
		     this.DrawTriangleUp(this.High[0].ToString()
		         +" "+Time[0].TimeOfDay.ToString(), true, 0, Close[0], Color.White);
		if (shortValue < 0)
		     this.DrawTriangleDown(this.Low[0].ToString()
		         +" "+Time[0].TimeOfDay.ToString(), true, 0, Close[0], Color.White);
		//...
	}

I am using Range chart. The green bar which is marked on the screen as 16:14, is actually closed on 16:14:30.

Same thing happen on a 3 min chart, where the price of 2049 does not exists at the bar it shown (See the 2 images shown the min char)

[NinjaTrader_PaulH]

Hello Shai Samuel,

Thanks for your post.

Your code would print on the currently forming bar when CalculateOnBarClose is set to false.

Please verify that you do have CalculateOnBarClose set to false in the indicator panel and check your code to ensure it is not set to true elsewhere.

If you find that CalculateOnBarClose is correctly set then you may want to check your PC clock to ensure it is in sync. Please use the steps below to change/check your Time Zone and sync the PC clock:

Close NinjaTrader.
Click on the clock in the lower right corner of your desktop.
Press 'Change time zone...'.
Set the Time zone and press 'OK'.
Click on Internet Time tab.
Set the server to time.nist.gov and then click Update.
Your PC clock should now be updated.

[Shai Samuel]

Thank Paul.

I got CalculateOnBarClose is set to false in Initialize, and my clock is sync.

On live data, its draw all in place. The problem is on the historical data when the indicator starts. I let it run for a while and it draws OK, if I refresh it (F5), it redrawn all one bar back, and forward is OK.

[NinjaTrader_PaulH]

Hello Shai Samuel,

Thanks for your reply and clarifying what you are doing.

When you refresh the chart the indicator then reloads and processes all of the data from the beginning and applies the draw objects however when working on the historical data the indicator (all indicators) function as if CalculateOnbarClose = true. This is because historical data does not contain all of the ticks, only the Open, High, Low and Close are available to the indicator when processing historical data. Once the live data appears your indicator would then resume in the CalculateOnBarClose = false mode.

[Shai Samuel]

Hi Paul,

I found the problems. One issue I had, was that I work with multiple time frames, so Close[0] and Time[0] are not the right approach, and I needed to use Closes[0][0] and Times[0][0]. And to go with that, I needed to use the 3rd form of the DrawTriangleUp, which uses DateTime. Once I fixed it, it all works as expected.

I have seen the issue in other posts, such #77736, and it might be the same issue.

Anyway, thank you for your support.