Time stop active if profit is < 0?

[NinjaTrader_Bertrand]

Yes, please review this link for an example - http://www.ninjatrader-support.com/H...ncelOrder.html

[Fierze]

Below is an excerpt of my strategy. The only parts not made by the wizard is marked in red text: the variable "barNumberofOrder" and the Time Stop condition. Unfortunately the strategy does not compile and I get an error message saying that "&& is not a valid expression".

I would appreciate if someone could explain what I need to add or change in order to make this time stop work. I just want that if the three most recent bars have all closed at an unrealized profit below 0, the position should be closed.

publicclass MeanReverter2 : Strategy
{
#region Variables

privateint myInput0 = 1;
privateint barNumberOfOrder = 0;
#endregion
///<summary>

///</summary>
protectedoverridevoid Initialize()
{
CalculateOnBarClose = false;
}
protectedoverridevoid OnBarUpdate()


...



// Time Stop Condition
if (CurrentBar > barNumberOfOrder + 3) &&
(Position.GetProfitLoss(Close[CurrentBar - 1], PerformanceUnit.Points)) < 0 && (Position.GetProfitLoss(Close[CurrentBar - 2], PerformanceUnit.Points)) < 0 && (Position.GetProfitLoss(Close[CurrentBar - 3], PerformanceUnit.Points)) < 0;
{
ExitLong("", "");
ExitShort("", "");
}

[NinjaTrader_Ben]

Hello,

This compiles. Does that help?:

if (
(CurrentBar > barNumberOfOrder + 3) &&
(Position.GetProfitLoss(Close[CurrentBar - 1], PerformanceUnit.Points) < 0) &&
(Position.GetProfitLoss(Close[CurrentBar - 2], PerformanceUnit.Points) < 0) &&
(Position.GetProfitLoss(Close[CurrentBar - 3], PerformanceUnit.Points) < 0)
)
{
ExitLong("", "");
ExitShort("", "");
}

[Fierze]

Hello,

This compiles. Does that help?:

Yes that helps, thanks. However, there was still some details missing in my code. The expression "CurrentBar" is not needed for the strategy to work, and it seems that neither is the "barNumberOfOrder" variable. I also realized that if I have negative numbers X in "Close[X]" the strategy tries to look at the PnL in three future bars instead of back to the three previous bars. By changing to positive numbers, I was finally able to create the time stop the way I wanted it!

If you have any opinions about the strategy or code below, I would love to hear it.
Here is my code for a time stop that exits a position after three consecutive bars of unrealized profit below 0:


// Time Stop Condition (Exit after three bars of PnL < 0)
if (
(Position.GetProfitLoss(Close[1], PerformanceUnit.Points) < 0) &&
(Position.GetProfitLoss(Close[2], PerformanceUnit.Points) < 0) &&
(Position.GetProfitLoss(Close[3], PerformanceUnit.Points) < 0)
)
{
ExitLong("", ""); ExitShort("", "");
}

[NinjaTrader_Ben]

Hello,

I just got you to compile. What you have looks ok to me, but test it to be sure. I'll have Bert pick this convo back up now.

[Fierze]

Hello,
I just got you to compile. What you have looks ok to me, but test it to be sure. I'll have Bert pick this convo back up now.

I did test it yesterday and it works like it is supposed to. This kind of time stop will probably be a part of many other systems that I program in the future!

I still think it is strange that there are not more discussions about time stops on this forum, considering how useful they can be. In that sense, this thread adds a lot of value.