Bug in @VolumeUpdown indicator

[geoninja]

The version of the @VolumeUpdown indicator currently shipping with NT7b22 incorrectly colours doji bars where close=open. In NT charts, bars with close=open are coloured "UP" bars by default, whereas volume bars for the same bar will be coloured as "DOWN" volume bars by the indicator, erroneously.

Please, correct this bug in the indicator.

Line 41 currently reads:
if (Close[0] > Open[0])

Line 41 should correctly be:
if (Close[0] >= Open[0])


Thank you.

Geo

[NinjaTrader_ChristopherJ]

Hello Geo,

Thank you for your post.

I will forward this to our development team for review.

Please let me know if I may be of further assistance.

[ramckay]

When I try to make the change to the indicator I get a message stating "Changes will be lost, since you can not save a system indicator." I entered the change describe in this thread, compiled the script, and reopened the script. As expected - no change. How do I change a system indicator?

Thanks

[NinjaTrader_JoshP]

ramckay,

You cannot change a system indicator. What you would want to do is create yourself a duplicate indicator named something else and then you can change that instead. Right click > Save As > type in a new name and then you can make amends to that one.

geoninja,

A bar with open=close has no visible colors besides the outline color (black). Can you please clarify what your requirement is for having such a bar be green as opposed to red?

[ramckay]

Thanks Josh,

That works. My objecctive here is to change the color of the volume histogram bar to some color other than red/green for bars that have the close equal to the open. I assumed that I need to create a new pen like the red and green you created and assign it to the Values[x]

if (Close[0] == Open[0])
{
Take Action
}

I don't see where that assignment is made in the code. Would you mind giving me some direction. Thanks

[NinjaTrader_JoshP]

ramckay,

You can change it in the Initialize() method where the Plots were created. Just change the Color.LimeGreen or Color.Red to different colors and then they will be of those new colors.

Add(new Plot(new Pen(Color.Lime, 2), PlotStyle.Bar, "UpVolume"));
Add(new Plot(new Pen(Color.Red, 2), PlotStyle.Bar, "DownVolume"));

Maybe change it to blue and orange

Add(new Plot(new Pen(Color.Blue, 2), PlotStyle.Bar, "UpVolume"));
Add(new Plot(new Pen(Color.Orange, 2), PlotStyle.Bar, "DownVolume"));

[eDanny]

ramckay,
A bar with open=close has no visible colors besides the outline color (black). Can you please clarify what your requirement is for having such a bar be green as opposed to red?

Josh, to see that effect please change the bar type to OHLC and you will see all doji bars are green.

Dan

[NinjaTrader_ChristopherJ]

Josh, to see that effect please change the bar type to OHLC and you will all doji bars are green.

Dan

Hello Dan,

Thank you for the additional information and reporting this behavior. I will forward your note to our development team.

[ramckay]

Hello Josh,

I guess I didn't explain well enough what I'm trying to change. I want to see the up "Volume" bars (not price bars) as green, down Volume bars as red, and the doji Volume bars as a third color. Is that a difficult change?

Also, the color of the price bars are set by chart properties settings are they not. Mine change to whatever color I set the up/down bars color to.

Thanks

[RJay]

Hello Josh,

I guess I didn't explain well enough what I'm trying to change. I want to see the up "Volume" bars (not price bars) as green, down Volume bars as red, and the doji Volume bars as a third color. Is that a difficult change?

Also, the color of the price bars are set by chart properties settings are they not. Mine change to whatever color I set the up/down bars color to.

Thanks

Try this..

[geoninja]

geoninja,

A bar with open=close has no visible colors besides the outline color (black). Can you please clarify what your requirement is for having such a bar be green as opposed to red?

Josh,

Please, open up a 5m OHLC bar chart of ES, add the @VolumeUpdown indicator, then look for a doji bar with close = open. You will find that the doji price bar is coloured as an UP bar (green, or in my case, black), but the respective volume bar will be coloured DOWN, red. Quite disconcerting, frankly. A simple logical bug.

Thank you.

Geo

[geoninja]

When I try to make the change to the indicator I get a message stating "Changes will be lost, since you can not save a system indicator." I entered the change describe in this thread, compiled the script, and reopened the script. As expected - no change. How do I change a system indicator?

Thanks

ramckay,

It is simple, but please, be cautious with changing system indicators.

1, Exit NT.
2, Edit text of indicator file (under My Documents\NT7\bin\Custom\Indicator), use a good editor like PsPad, but Notepad works for quick hacks
3, Restart NT
4, open the - now changed - indicator in the NScript editor, and hit "Compile"....

Your system indicator has been changed.

Geo

[ramckay]

Hello geoninja & rt6716,

Thanks to both of you. Exactly the answers I was looking for.