Announcement

Collapse

Looking for a User App or Add-On built by the NinjaTrader community?

Visit NinjaTrader EcoSystem and our free User App Share!

Have a question for the NinjaScript developer community? Open a new thread in our NinjaScript File Sharing Discussion Forum!
See more
See less

Partner 728x90

Collapse

Accurate PnLs for All Trades

Collapse
X
 
  • Filter
  • Time
  • Show
Clear All
new posts

    #31
    Accurate PnLs for All Trades

    Hi Chelsea. Thanks for your comments.

    I would also be happy to submit a feature request in your behalf for a NinjaScript method that returns the unrealized PnL for an individual trade as part of the IOrder / Order classes.

    Would you like me to do this?
    Yes, please!

    Which bugs are you referring to that need to be corrected?
    The bugs are not in the code I have provided here -- they are as you previously confirmed here: http://ninjatrader.com/support/forum/showthread.php?t=65400

    I can provide you with a list of consultants who would be happy to assist you in creating this logic.

    Would you like this list?
    No, thanks. I can do that -- my goal in asking was to ensure all considerations were taken into account and the functional need and the identified bugs were clear.

    One thing you could assist with would be to let me know how to obtain the commission of an open trade.

    Thanks!
    Multi-Dimensional Managed Trading
    jeronymite
    NinjaTrader Ecosystem Vendor - Mizpah Software

    Comment


      #32
      Accurate PnLs for All Trades

      Hi Chelsea. Thanks to your kind assistance, I have now produced code that calculates accurate PnLs for all individual trades, open or closed, long or short, JPY or non-JPY, standard TickSizes or microlots, with the exception that I have not yet incorporated the commission on an open trade into the open trade calculation. If you can advise on this last point, I would be most grateful.

      Thanks!

      [EDIT: I found the Commission in the Execution, so all is done. Thanks!]
      Last edited by jeronymite; 07-09-2015, 10:28 PM. Reason: Answered!
      Multi-Dimensional Managed Trading
      jeronymite
      NinjaTrader Ecosystem Vendor - Mizpah Software

      Comment


        #33
        Hi jeronymite,

        Actually, thank you for that link. I was meaning to update you and let you know that has been fixed for Beta 3. (I confirmed this myself)

        With the execution override with the e.Rate, this is actually unsupported and I'm still not perfectly sure when this rate is calculated. But this seems to work fine for the script.
        Chelsea B.NinjaTrader Customer Service

        Comment


          #34
          Accurate PnLs for All Trades

          Thanks again, Chelsea. I appreciate the update.

          Note that this will need to be fixed in NT7 also.

          Thanks again for all your kind assistance!
          Multi-Dimensional Managed Trading
          jeronymite
          NinjaTrader Ecosystem Vendor - Mizpah Software

          Comment


            #35
            Hello jeronymite,

            This has been reported as a day one bug for NinjaTrader 7, however, it will be up to the development department to decide to correct this for NinjaTrader 7.

            Also, I have submitted a feature request to add to the IOrder object a way to track the unrealized PnL in your behalf.

            Please let me know if you have any other feature requests.
            Chelsea B.NinjaTrader Customer Service

            Comment


              #36
              Accurate PnLs for All Trades

              Thanks again, Chelsea.
              This has been reported as a day one bug for NinjaTrader 7, however, it will be up to the development department to decide to correct this for NinjaTrader 7.
              Given that Ray has indicated that NT7 will be downloadable for years, I would hope that the requirement for this fix would not be in any doubt. Thanks.
              Multi-Dimensional Managed Trading
              jeronymite
              NinjaTrader Ecosystem Vendor - Mizpah Software

              Comment


                #37
                Accurate PnLs for All Trades

                Just seeking an update on this. Thanks.
                Multi-Dimensional Managed Trading
                jeronymite
                NinjaTrader Ecosystem Vendor - Mizpah Software

                Comment


                  #38
                  Hello jeronymite,

                  It is up to our development to decide if and when a feature request will be implemented. Not all feature requests will be implemented.

                  This request is being tracked with ID #SFT-520 and has not been implemented at this time but may still be possibly implemented in the future.
                  Chelsea B.NinjaTrader Customer Service

                  Comment

                  Latest Posts

                  Collapse

                  Topics Statistics Last Post
                  Started by jeronymite, 04-12-2024, 04:26 PM
                  3 responses
                  39 views
                  0 likes
                  Last Post jeronymite  
                  Started by bill2023, Today, 08:51 AM
                  2 responses
                  15 views
                  0 likes
                  Last Post bill2023  
                  Started by sidlercom80, 10-28-2023, 08:49 AM
                  167 responses
                  2,260 views
                  0 likes
                  Last Post jeronymite  
                  Started by warreng86, 11-10-2020, 02:04 PM
                  7 responses
                  1,362 views
                  0 likes
                  Last Post NinjaTrader_Manfred  
                  Started by Perr0Grande, Today, 08:16 PM
                  0 responses
                  5 views
                  0 likes
                  Last Post Perr0Grande  
                  Working...
                  X