simple calculation

[Laimis]

Hi,

Could anybody help me, I'm stuck in simple code and simple math
I want to calculate how many up close and down close bars appeared in current session. And then I want to have one number like a somekind of coef, how many up close bars were in this session compared to all bars in this session.

so far what I get in output window is correct calculations for aboveS and belowS, but i get zeros for double sessionClose. So the code is not working.

In my deffence I'm total beginner in programming so any help or suggestions are wellcome. And maybe there's a more effective ways do that kinds of calculations.

Thank you all in advance.


private int numberOfBars = 0;
private int aboveS = 0;
private int belowS = 0;
private double sessionClose = 0.00;

protected override void OnBarUpdate()
{


if (Bars.FirstBarOfSession)
{
numberOfBars = 0;
private int aboveS = 0;
private int belowS = 0;
sessionClose = 0.00;
}
numberOfBars++;

if(numberOfBars <1) return;

if (Close[0] > Close[1])
aboveS++;

if (Close[0] < Close[1])
belowS++;

sessionClose = aboveS/(aboveS + belowS);

Print("Current session number of bars = " + numberOfBars.ToString() + “ // “ +“ sessionClose = “ + sessionClose.ToString()+ “ // “ + "Date = " + ToDay(Time[0]).ToString() + " // " + “Time = “ + ToTime(Time[0]).ToString());

}

[NinjaTrader_Jesse]

Hello,

Thank you for the post.

I noted one problem in the syntax, the following items should not be marked private while inside of a method:

if (Bars.FirstBarOfSession)
{
numberOfBars = 0;
[B]private[/B] int aboveS = 0;
[B]private[/B] int belowS = 0;
sessionClose = 0.00;
}

these should instead be:

if (Bars.FirstBarOfSession)
{
numberOfBars = 0;
aboveS = 0;
belowS = 0;
sessionClose = 0.00;
}

using private inside of a method such as OnBarUpdate should throw a compile error, additionally you have declared the variable in the variables section, the reset on the first bar of session would need to be just the variable name to associate the correct variable.

The second item I noted is the math you are using, int being used with double. Generally you would need to cast the int to a double to ensure the math is correct as well.

int math in C# can be deceiving or you can end up with rounded values in the case the value was between 0 and 1. you can test adjusting the type of the two variables to a double instead:

private double aboveS = 0;
private double belowS = 0;
private double sessionClose = 0.00;

below is the corrected syntax, I did print the values and see it is a value between 0 and 1, so using int specifically would cause rounding in this situation.

private int numberOfBars = 0;
private double aboveS = 0;
private double belowS = 0;
private double sessionClose = 0.00;

protected override void OnBarUpdate()
{
	if (Bars.FirstBarOfSession)
	{
		numberOfBars = 0;
		aboveS = 0;
		belowS = 0;
		sessionClose = 0.00;
	}
	numberOfBars++;

	if (numberOfBars < 1) return;

	if (Close[0] > Close[1])
		aboveS++;

	if (Close[0] < Close[1])
		belowS++;

	sessionClose = aboveS / (aboveS + belowS);

	Print("Current session number of bars = " + numberOfBars.ToString() + " sessionClose: " + sessionClose);

}

I look forward to being of further assistance.

[Laimis]

it works perfectly! thank you so much

[koganam]

it works perfectly! thank you so much

Doubles do not make lexical sense for counting what are essentially integers, and they take more resources (no matter how small) to boot. In this simple case, that may not be important: it can become important in large programs.

You are better off using your original code, and casting the integers in the final calculation where you need a double.

sessionClose = (double)aboveS / (double)(aboveS + belowS);

It is also more elegant.

NB: I always cast both, simply because it makes it more understandable when I come to read it later, but it is really only necessary to cast one quantity in an expression. Arithmetic that involves a mixture of double and int, will return a double.