NinjaTrader generated indicator code should use namespace in the cache vars

[aslane]

There are name clashes in the Indicator partial class if you redefine an indicator name within your own workspace. As a simple example, if I create an SMA indicator in a workspace (i.e. WS), I will get a a name clash because cacheSMA is already defined in the Indicator partial class.

This would be solved if the generated code used the namespace (i.e. cacheWSSMA). Then I could have two SMA indicators that would not clash and could be called out via namespaces.

Please consider fixing this.

[NinjaTrader_Jesse]

Hello aslane,

In your example it is not the namespace which is the problem but the name of the generated cache variable, the namespace is being used in the generated code:

private [B]CustomFolder[/B].SMA[] cacheSMA;

Adding the namespace wouldn't help here, a unique variable name would still be needed as this is a variable of the partial class. The SMA has the same named cacheSMA variable in its partial class causing an error.

For your specific example there is also now logic in the newest update to prevent this situation. Using system indicator names like SMA specifically is not a valid name that you can use so this generates a warning now. This does not currently happen with custom indicator names so I will put in a feature request to have the wizards prevent you from creating an item that uses an existing name.

If the goal is to have two SMA indicators which do not clash you would need to use two unique names such as SMA1 and SMA2 or you can use the existing SMA and a unique named type SMA1.


Please let me know if I may be of further assistance.

[aslane]

Right, but you made my point. The cache var should be "cacheCustomFolderSMA", then it would be unique.

Anyway, does not matter, I suspected you would not support.