Extending ChartTrader as an Add-On

[jalley]

I was wondering if you could provide an example of just the bare bones skeleton of getting the ChartTrader window reference as an Add-On? Basically I want to extend ChartTrader but not via an indicator, because I want to place orders through it with some new added buttons. Also how can I get a reference to OnBarUpdate() from within this Add-On?

I wrote it as an indicator initially but I cannot place orders from it that way. I started from the examples you had of customizing it but they were all indicator based and not add-on based.

Thanks in advance.

[NinjaTrader_Jesse]

Hello jalley,

To append to a chart window without an indicator would require using an Addon and the OnWindowCreated override.
There is a sample of getting the chart trader control here: https://ninjatrader.com/support/foru...t=7#post752775

You would do exactly the same process in an addon but rather than using the ChartControl to locate the window you would just use the passed in window from OnWindowCreated.

chartTrader = window.FindFirst("ChartWindowChartTraderControl") as ChartTrader;

You can find some examples of modifing the chart trader control here: https://ninjatrader.com/support/foru...ions#post96376

I look forward to being of further assistance.

[jalley]

I did what you said and finished the visual part of the controls for my extended ChartTrader but now I need to be able to place orders.

What is the best way from an Add-On to get the selected instrument, price (bid and ask) and selected qty?

How do you intercept OnBarUpdate() or even process tick by tick within an Add-On? I know how to do this from a strategy or indicator but haven't done it before with an Add-On...

Thanks again!

[NinjaTrader_Jesse]

Hello jalley,

Your addon won't be able to just get data from a window, you would need to do a BarsRequest if you need data of some kind. https://ninjatrader.com/support/help...ub=barsrequest

If you want to use the charts instrument selector you would have to additionally locate that control and then get the selected instrument. You can find an example of working with the instrument selector in the addon sample basic. Once you have found the control using FindFirst you could work with it like shown in the sample: https://ninjatrader.com/support/help...t_overview.htm

To find different controls in the user interface you would need to use Microsofts tool named Inspect.

https://ninjatrader.com/support/forum/forum/historical-beta-archive/version-8-beta/90509-is-it-possible-to-enter-a-position-using-an-indicator-and-not-a-strategy?postcount=7#post752775

That will allow you to see automation ID's for controls like the chart trader or instrument selector. There are also existing samples for these type of items if you search the forums for the concept you are asking about. https://ninjatrader.com/support/help...ub=barsrequest

I look forward to being of further assistance.

[jalley]

I was able to get my custom ChartTrader working for the first chart I open and only if I start it with a data provider already connected.

Issues I'm having...

Any other chart I open it doesn't show the customization.
If I start not connected to a data provider it shows customization controls fine but after connecting to a data provider it is throwing thread errors trying to remove event handlers etc...
Throws these thread errors when starting other charts after the first one. I added null checks but that's only a bandage to not crash the system.

What insight could you give me? Below is sort of the main control section of the code where the thread errors happen. Thank in advance!

protected override void OnWindowDestroyed(Window w)
{
// if(w.IsEnabled) return;
Cleanup(w);
}

protected override void OnWindowCreated(Window window)
{
if (window != null)
{
window.Dispatcher.InvokeAsync((Action)(() =>
{
AddButtonsMethod(window);
}));
}
}

// Called by TabControl when tab is being removed or window is closed
public void Cleanup(Window w)
{
// Make sure to unsubscribe to the market data subscription
if (marketData != null)
marketData.Update -= OnMarketData;
// Make sure to unsubscribe to the bars request subscription
if (barsRequest != null)
{
barsRequest.Update -= OnBarUpdate;
barsRequest.Dispose();
barsRequest = null;
}
RemoveWPFControls();
}

private bool TabSelected()
{
bool tabSelected = false;

// loop through each tab and see if the tab this indicator is added to is the selected item
foreach (TabItem tab in chartWindow.MainTabControl.Items)
if ((tab.Content as Gui.Chart.ChartTab).ChartControl is ChartControl && tab == chartWindow.MainTabControl.SelectedItem)
tabSelected = true;

return tabSelected;
}

private void TabChangedHandler(object sender, SelectionChangedEventArgs e)
{
if (e.AddedItems.Count <= 0)
return;

tabItem = e.AddedItems[0] as TabItem;
if (tabItem == null)
return;

chartTab = tabItem.Content as Gui.Chart.ChartTab;
if (chartTab == null)
return;

if (TabSelected())
InsertWPFControls();
else
RemoveWPFControls();
}
}

protected void GetChartTraderParameters()
{
if (chartTrader != null)
{
instrument = chartTrader.Instrument;
myAccount = chartTrader.Account;
selector = chartTrader.FindFirst("ChartTraderControlATMStrate gySelector") as NinjaTrader.Gui.NinjaScript.AtmStrategy.AtmStrateg ySelector;
qty = chartTrader.Quantity;
tickSize = chartTrader.Instrument.MasterInstrument.TickSize;
}
else
{
chartTrader = currentWindow.FindFirst("ChartWindowChartTraderCon trol") as ChartTrader;
if (chartTrader != null)
{
GetChartTraderParameters();
}
}
}

// This method is fired on market data events
protected void OnMarketData(object sender, MarketDataEventArgs e)
{
// Do something with market data events
if ((marketData != null) &&
(marketData.Last != null))
{
price = marketData.Last.Price;
}
}

[jalley]

I got a little further and now I'm not getting the same problems but have a new one. All the charts now display my added controls but click events etc, and edit control values are being shared by all charts so if I change one chart, the rest are changing as well and I want them to each be unique.

Also is there an easy way from an addOn to tie into the chart's onBarUpdate event without having to do a seperate bar request and calculate range etc? I just need to know when the chart starts the plot of the next bar to get previous close. This way it would work with any bar type or time range.

I fixed most of the past posts by disabling checking of tabcontrol state etc.. was avoiding dynamically inserting wpf controls onto the additional charts. I also added a reference count for the += OnMarketData event handler and check that before trying to remove one that doesn't exist. I'm sure I'm not doing it the right way but at least I'm not seeing errors now when connecting data provider or adding new charts.

[NinjaTrader_Jesse]

I got a little further and now I'm not getting the same problems but have a new one. All the charts now display my added controls but click events etc, and edit control values are being shared by all charts so if I change one chart, the rest are changing as well and I want them to each be unique.

It sounds like you may have declared some class level variables or did not do your action per each window instance individually. From the code you provided earlier I can't really tell. If you can provide a updated sample as an attachment instead of pasting it that would be helpful.

Also is there an easy way from an addOn to tie into the chart's onBarUpdate event without having to do a seperate bar request and calculate range etc? I just need to know when the chart starts the plot of the next bar to get previous close. This way it would work with any bar type or time range.

This would not be something you can access from the addon, you would generally need to apply an indicator to the chart if you want to work with the charts data/events. Your addon is its own tool and it would have to subscribe to its own data.

I look forward to being of further assistance.

[jalley]

I saw in another post in the forum that you can't place orders from an indicator and that is the goal of my add-on.

[NinjaTrader_Jesse]

Hello jalley,

An indicator can place orders, you would have to use the Addon account methods for that.

https://ninjatrader.com/support/helpGuides/nt8/account_class.htm

https://ninjatrader.com/support/helpGuides/nt8/submit.htm

This is the same concept that the addon would otherwise use to submit orders.

I look forward to being of further assistance.

[jalley]

Perfect! Thank you for your patience!