riskmanager AddOn help needed

[vesipeto]

Hi

disclaimer: I'm quite new to c# and handling orders in ninjatrader.

I try to build a risk manager that flattens my trade if the positions are too much in loss. Currently I'm using OnAccountItemUpdate event for checking if the account is below my allowed limit and if yes then I try to flatten the trades. unfortunately something is wrong with my code is I just got ninjatrader in a state that I couldn't flatten my trades by anymeans from ninjatrader UI. The error can be in many places and now I start to narrow it down. I don't know if my general idea is a correct one, so please let me know if this should work as intended or is there better way to approach this issue?:

private void OnAccountItemUpdate(object sender, AccountItemEventArgs e)
{

lock (m_account.Positions)
{


foreach (Position position in m_account.Positions)
{

double profitLoss = position.GetUnrealizedProfitLoss(PerformanceUnit.C urrency);
if(profitLoss <= singlePositionMaxRisk)
{

NinjaTrader.Code.Output.Process(string.Format("Ris kManager Max trade loss triggered at loss of: {0} at price of {1}", profitLoss, position.AveragePrice), PrintTo.OutputTab1);


flattenAllTrades();// kill the trades
m_status = string.Format("Position max loss reached. 5min cooloff time started at {0} ",DateTime.Now);
PlaySound(@"F:\TRADING\NinjaTrader\riskManagerAudi o\maxStopAmountHit.wav");
}


}
}//END of LOCK
}

and for flattening the trades I have this method:

private void flattenAllTrades() //kill all trades
{
NinjaTrader.Code.Output.Process(string.Format("fla ttenAllTrades called"), PrintTo.OutputTab1);

foreach (Position position in m_account.Positions)
{

NinjaTrader.Code.Output.Process(string.Format("fla ttening trade on instrument {0} ", position.Instrument), PrintTo.OutputTab1);
m_account.Flatten(new [] {position.Instrument});
m_account.CancelAllOrders(position.Instrument);
}

}​

thanks

[NinjaTrader_Jesse]

Hello vesipeto,

When you say that you couldn't use the UI to flatten, what was the reason that the UI was unusable? Was there popup error messages or was it frozen?

From the given code I don't see anything that would specifically be a problem. Depending on what the issue you observed was may help to better understand if this code relates to the issue.

[vesipeto]

Hey

what seems to happen is that there is tons of overllapping close orders that are pending and Ninjatrader just freezes and the UI is not usable any more I need to restart and reset the sim account to get rid of the orders. I try to understand what is happening and one thought is that since I'm using OnaccountItemUpdate to send the flatten order then maybe there is multiple orders send before the orders are executed and that is causing some jamming. Btw, I'm using rhitmic as my data source atm if that makes any difference.

[NinjaTrader_Jesse]

Hello vesipeto,

Are you calling the logic to close orders many times? You should only see close orders for the positions that are open and not multiple times. If you are calling that more that once in a small amount of time that may be leading to a problem.