Xml Error when opening NTWindow

[toptrader]

I'm creating an addon to run in the background of NT8. I have attached the code for the Add On. When I click the MenuItem to display my custom NTWindow, I am receiving the following error:

System.Xml.XmlException: The '+' character, hexadecimal value 0x2B, cannot be included in a name.

This only happens every other time I try to open the NTWindow. Every other time it will open and so far it seems to work as expected. Is there an error in my code?

[NinjaTrader_JessicaP]

Hello toptrader, and thank you for your question.

I noticed your strategy contains characters outside the ASCII range between lines 177 and 181, and between lines 231 and 241, which are not part of your strategy logic. I am returning a copy of your strategy with these characters removed. This should resolve your query.

Please let us know if there are any other ways we can help.

[toptrader]

Thank you for your reply. I do not see any differences in your code and my original code. I copy and pasted the code from your sample in my Add On, but I am still receiving the same error.

[NinjaTrader_JessicaP]

The differences are likely being caused by your code editor, and this may also be why characters outside the 0x00 - 0x7F range are invisible to you. I would like to recommend reviewing your code with an editor such as the freely and publicly available Notepad++, available here,

https://notepad-plus-plus.org/

Once you have an editor which will reveal unprintable characters, please review your code around the lines I mentioned previously.

[toptrader]

I downloaded Notepad++, but I am still not seeing any extra characters.

[NinjaTrader_JessicaP]

The editor I typically use, gvim when I am on windows, reveals the attached image. The left image is your original code, the right image is the modified code that I returned to you. For your benefit, I am also attaching hex dumps of both files to this reply. There are interesting characters around byte 0x1800.

Please ensure that you are loading the file you originally attached to your first reply into Notepad++ should you test in Notepad++, and not any files you have modified or copy / pasted into. It is important to do so, because it may be the case that your compiler or editor is adding garbage characters.

Have you had the same results when you use the code I sent you directly, rather than copying and pasting in?

[toptrader]

OK. I have completely removed the lines of code where you are seeing extra characters, but I am still seeing the issue. I have attached the latest code I am using.

[NinjaTrader_JessicaP]

Thank you for this update, toptrader. It looks like we have successfully removed the unprintable characters from your code. Since you are still seeing these messages, this means that your compiler is probably adding these characters. We can try to repair your compiler with a complete reinstall.

Please follow these steps to completely uninstall and reinstall NinjaTrader 8 on your system.

• Download a fresh copy of NinjaTrader 8 from ninjatrader.com
• Close NinjaTrader 8
• Rename your (My) Documents\NinjaTrader 8\db\NinjaTrader.sdf file so it becomes (My) Documents\NinjaTrader 8\db\NinjaTrader.20161122.sdf
• Rename your (My) Documents\NinjaTrader 8 folder so it becomes (My) Documents\NinjaTrader 8 - 20161122
• Use the installer you downloaded to uninstall, and then reinstall, NinjaTrader 8
• Copy these files and folders from your NinjaTrader 8 - 20161122 folder to your NinjaTrader 8 folder, under (My) Documents. If asked to replace files, always select "yes"
• • Config.xml
  • UI.xml
  • workspaces
  • templates
  • all .dll files in bin\Custom except these :
  • • NinjaTrader.Custom.dll
    • NinjaTrader.Vendor.dll
    
    
  • all .cs files in bin\Custom except these :
  • • NinjaTrader.Custom.cs
    • NinjaTrader.Vendor.cs
    • AssemblyInfo.cs
    
    
  • any subfolder of bin\Custom that has a .cs file that does not start with an @ sign
  
  
• Start NinjaTrader 8. You will receive some dialogs about Ninja being unable to start because it needed to recompile some dlls. OK out of these dialogs
• Start NinjaTrader 8 once more

[toptrader]

I followed your instructions, but I did not receive any dialogs about needing to recompile any dlls. I am still getting the same error after the uninstall and reinstall. Are you seeing the error on your end if you try to run the add on?

[NinjaTrader_JessicaP]

Thank you for your report, and for the updated code.


This behavior was confirmed on our end. We will be investigating this further. Please keep an eye on the NinjaTrader 8 Release Notes page for updates and bugfixes.

http://ninjatrader.com/support/helpGuides/nt8/en-us/release_notes.htm

Tracking ID: NTEIGHT-10802

[NinjaTrader_JessicaP]

I have an update regarding NTEIGHT-10802. We have encountered a limitation in the underlying C# technology which we will be clearly documenting :

1. any class which derives from NTWindow or implements IWorkspacePersistance cannot be a nested class of another class
2. any class which derives from NTWindow or implements IWorkspacePersistance must have a default constructor

By default constructor, we mean a constructor which takes no arguments. In your code you will see a nested class near line 329. You will need to refactor your code so that this class is in another file, or so its code is part of your outer class.


Please let us know if there are any other ways we can help.

[fx.practic]

Hello
I have absolutely same problem in 8.0.16.2 64-bit today.
Does bus still not fixed, of am I just not lucky?

[NinjaTrader_ChelseaB]

Hello fx.practic,

NTEIGHT-10802 is not marked as corrected and was not listed in the release notes as corrected. This is marked as expected.

To confirm, your addon class is a subclass is this correct?

As this was marked as expected, I am happy to submit a feature request to allow classes that implement IWorkspacePersistance to be sub classes if you would like.

[fx.practic]

Hello Chelsea, thank You for the answer.

I don't want to implement IWorkspacePersistance, only derive from NTWindow.
I move my class outside Indicator class, inside Indicators namespace and it starts work.
I was able to make my class private and to use parameters in window constructor.

And Yes, please, submit feature to let custom classes, derived from NTWindow and implemented IWorkspacePersistance, to be nested (at least, inside Indicator and Strategy class).

I believe this would be a good approach meaning encapsulation ideology.

[NinjaTrader_ChelseaB]

Hello fx.practic,

I'm not certain that I am understanding. You are trying to make an Addon that inherits from NTWindow and also have this be in the NinjaScript.Indicator namespace?

This is not supported and not advised.

Are you trying to open an addon window from a indicator? (I have an example that demonstrates this)