how to use absolute value method

[guidoisot]

hello
please can you help in how to get this indicator compiling which should be signalling when there is a wide body candle next to a small body candle.
Thank you.

#region Using declarations
using System;
using System.Collections.Generic;
using System.ComponentModel;
using System.ComponentModel.DataAnnotations;
using System.Linq;
using System.Text;
using System.Threading.Tasks;
using System.Windows;
using System.Windows.Input;
using System.Windows.Media;
using System.Xml.Serialization;
using NinjaTrader.Cbi;
using NinjaTrader.Gui;
using NinjaTrader.Gui.Chart;
using NinjaTrader.Gui.SuperDom;
using NinjaTrader.Gui.Tools;
using NinjaTrader.Data;
using NinjaTrader.NinjaScript;
using NinjaTrader.Core.FloatingPoint;
using NinjaTrader.NinjaScript.DrawingTools;
#endregion

//This namespace holds Indicators in this folder and is required. Do not change it.
namespace NinjaTrader.NinjaScript.Indicators
{
public class abaBodiesModified : Indicator
{
private EMA EMA1;
private ROC ROC1;
private ABS ABS1;
private ABS ABS2;

protected override void OnStateChange()
{
if (State == State.SetDefaults)
{
Description = @"Enter the description for your new custom Indicator here.";
Name = "abaBodiesModified";
Calculate = Calculate.OnBarClose;
IsOverlay = true;
DisplayInDataBox = true;
DrawOnPricePanel = true;
DrawHorizontalGridLines = true;
DrawVerticalGridLines = true;
PaintPriceMarkers = true;
IsAutoScale = true;
ScaleJustification = NinjaTrader.Gui.Chart.ScaleJustification.Right;
//Disable this property if your indicator requires custom values that cumulate with each new market data event.
//See Help Guide for additional information.
IsSuspendedWhileInactive = true;
First_body_size_Min = -0.01;
First_body_size_Max = 0.01;
Second_Bar_Multiplier = 8.0;
AddPlot(Brushes.DodgerBlue, "Pinch");

}
else if (State == State.Configure)
{
EMA1 = EMA(Close, 8);
ROC1 = ROC(Close, 1);
abs1 = abs(Close[0] - Open[0]);
abs2 = abs(Close[1] - Open[1]);

EMA1.Plots[0].Brush = Brushes.Goldenrod;

}
}

protected override void OnBarUpdate()
{
if (CurrentBars[0] < 4)
return;
{
Value[0] = +0;
}



// Set 1
if (
// conditions for SMALL BODY bar for LONGs
// using ROC indicator in order to set percentage value of the body of 1st candle. for ex +- 0.01%
(
(ROC1[1] < First_body_size_Max)
&& (ROC1[1] > First_body_size_Min))

// conditions for WIDE BODY bar for LONGs
// using absolute value because 1st bar can be either upbar or down bar,
// ie value of 1st bar body can be either positive or negative

&& (Close[0] > Open[0])
&& abs1 > (abs2*Second_Bar_Multiplier)
)
{
BackBrush = Brushes.ForestGreen;
}

// Set 2
if (
// conditions for SMALL BODY bar for SHORTs
(
(ROC1[1] < First_body_size_Max)
&& (ROC1[1] > First_body_size_Min))
// conditions for WIDE BODY bar for SHORTs
&& (Close[0] < Open[0])
&& abs1 > (abs2*Second_Bar_Multiplier)
)
{
BackBrush = Brushes.OrangeRed;
}

}

public override void OnCalculateMinMax()
{
MinValue = - 1;
MaxValue = + 1;
}

#region Properties
[NinjaScriptProperty]
[Range(-99, double.MaxValue)]
[Display(Name="First_body_size_Min", Order=1, GroupName="Parameters")]
public double First_body_size_Min
{ get; set; }

[NinjaScriptProperty]
[Range(-99, double.MaxValue)]
[Display(Name="First_body_size_Max", Order=2, GroupName="Parameters")]
public double First_body_size_Max
{ get; set; }



[NinjaScriptProperty]
[Range(-99, double.MaxValue)]
[Display(Name="Second_Bar_Multiplier", Order=6, GroupName="Parameters")]
public double Second_Bar_Multiplier
{ get; set; }
#endregion

}
}

[guidoisot]

searching on internet I found out that the name of the method for getting the absolute value is Math.Abs.
So I think I was able to compile the indicator, that appears to be owrking correctly.
I attach it here for anyone interested in using it and/or anyone willing to improve it.
I would be grateful if anyone could modify it so that the input parameters could be inserted with numbers shown in percentage format (as shown in yellow on the attached chart image).
Modifying the script in such a way is way too difficult for me.
Thanks.

[koganam]

searching on internet I found out that the name of the method for getting the absolute value is Math.Abs.
So I think I was able to compile the indicator, that appears to be owrking correctly.
I attach it here for anyone interested in using it and/or anyone willing to improve it.
I would be grateful if anyone could modify it so that the input parameters could be inserted with numbers shown in percentage format (as shown in yellow on the attached chart image).
Modifying the script in such a way is way too difficult for me.
Thanks.

Just multiply your calculated values by 100 to turn them into percentages. That is the definition of percent.

e.g.,
instead of:

Math.Abs((Close[1]-Open[1])/Open[1]) < MaxSizeFirstCandleBody_as_perc_of_Price

use:

Math.Abs((Close[1]-Open[1]) * 100/Open[1]) < MaxSizeFirstCandleBody_as_perc_of_Price

The left hand side of that inequality is now expressed as a percentage.

Do the same for other calculations that you will use as comparators.

[guidoisot]

thank you.
your suggestion is very helpful because it allows to take off two zeros. From your reply, I understand it is not possible to have the % symbol on the fields where I wrote the % numbers in yellow, because these fields can only accept doubles.

[koganam]

thank you.
your suggestion is very helpful because it allows to take off two zeros. From your reply, I understand it is not possible to have the % symbol on the fields where I wrote the % numbers in yellow, because these fields can only accept doubles.

I would not say that it is impossible: it is just a bit convoluted, to little purpose, I would say. Essentially you would need to make that parameter text, rather than a double, then parse the text into a double before using it. You would also need to modify the PropertyGrid itself to place text (namely the "%" sign) after the input.

It might make more sense to simply place a "%" sign in brackets as part of the label (sort of as a hint), then place a more elaborate statement in the description of the parameter. Just my suggestion. You may be able to see that I have been down this road before.

[NinjaTrader_Kate]

Hello guidoisot,

Thank you for your post.

ABS is not an indicator and cannot be referenced as such. It can be called like this:

private EMA EMA1;
private ROC ROC1;
//create new series to hold our abs values
private Series<double> Abs1;
private Series<double> Abs2;

protected override void OnStateChange()
{
    if (State == State.SetDefaults)
    {
    Description = @"Enter the description for your new custom Indicator here.";
    Name = "abaBodiesModified";
    Calculate = Calculate.OnBarClose;
    IsOverlay = true;
    DisplayInDataBox = true;
    DrawOnPricePanel = true;
    DrawHorizontalGridLines = true;
    DrawVerticalGridLines = true;
    PaintPriceMarkers = true;
    IsAutoScale = true;
    ScaleJustification = NinjaTrader.Gui.Chart.ScaleJustification.Right;
    //Disable this property if your indicator requires custom values that cumulate with each new market data event.
    //See Help Guide for additional information.
    IsSuspendedWhileInactive = true;
    First_body_size_Min = -0.01;
    First_body_size_Max = 0.01;
    Second_Bar_Multiplier = 8.0;
    AddPlot(Brushes.DodgerBlue, "Pinch");

    }
    else if (State == State.Configure)
    {
    EMA1 = EMA(Close, 8);
    ROC1 = ROC(Close, 1);
    Abs1[0] = Math.Abs(Close[0] - Open[0]);
    Abs2[0] = Math.Abs(Close[1] - Open[1]);

    EMA1.Plots[0].Brush = Brushes.Goldenrod;

    }
    else if (State == State.DataLoaded)
    {                
        Abs1 = new Series<double>(this);
        Abs2 = new Series<double>(this);
    }
}


protected override void OnBarUpdate()
{
if (CurrentBars[0] < 4)
{
    Value[0] = +0;
    return;
}



// Set 1
if (
// conditions for SMALL BODY bar for LONGs
// using ROC indicator in order to set percentage value of the body of 1st candle. for ex +- 0.01%
(
(ROC1[1]< First_body_size_Max)
&& (ROC1[1] > First_body_size_Min))

// conditions for WIDE BODY bar for LONGs
// using absolute value because 1st bar can be either upbar or down bar,
// ie value of 1st bar body can be either positive or negative

&& (Close[0] > Open[0])
&& Abs1[0] > (Abs2[0] * Second_Bar_Multiplier)
)
{
BackBrush = Brushes.ForestGreen;
}

// Set 2
if (
// conditions for SMALL BODY bar for SHORTs
(
(ROC1[1] < First_body_size_Max)
&& (ROC1[1] > First_body_size_Min))
// conditions for WIDE BODY bar for SHORTs
&& (Close[0] < Open[0])
&& Abs1[0] > (Abs2[0] * Second_Bar_Multiplier)
)
{
BackBrush = Brushes.OrangeRed;
}

}

Here is a link to our help guide on System.Math():
https://ninjatrader.com/support/help...m_highlightsub =math

Please let us know if we may be of further assistance to you.