Error handling issue in NT8 for Bar period

[asmmbillah]

Hi,

I am using below code, so that unless user uses 15 min or daily or weekly or monthly time frame; it is going to show error message to prompt to correct the time period :

else if (State == State.Historical)
{

if ((BarsPeriod.Value != 15 && BarsPeriod.BarsPeriodType == BarsPeriodType.Minute)||
(BarsPeriod.BarsPeriodType != BarsPeriodType.Day)||(BarsPeriod.BarsPeriodType != BarsPeriodType.Week)||
(BarsPeriod.BarsPeriodType != BarsPeriodType.Month))
{
Draw.TextFixed(this, "Error", "change to 15 Min/Daily/ Weekly/ Monthly/", TextPosition.Center);
Log("change to 15 Min/ Daily/ Weekly/ Monthly", LogLevel.Error);
}
}

But for some strange reason, it is not working as expected. so far I could find in ref guide and in forum examples, that is the way. Anyone can suggest what might be missing or wrong there?

[NinjaTrader_ChrisL]

Hi asmmbillah, thanks for your note.

This is happening because your conditions are linked together. If you had a 15 minute chart, that would be fine, but thats still not a 1 Month or Weekly chart so you still get the error message. You should check for each legal bar type individually.

Best regards.

[asmmbillah]

Thanks for your reply. I have separated them like below:

else if (State == State.Historical)
{

if (BarsPeriod.Value != 15 && BarsPeriod.BarsPeriodType == BarsPeriodType.Minute)
{
Draw.TextFixed(this, "Error", "Please change the Bar Type", TextPosition.Center);
Log("Please change the Bar Type", LogLevel.Error);
}

if (BarsPeriod.BarsPeriodType != BarsPeriodType.Day)
{
Draw.TextFixed(this, "Error", "Please change the Bar Type", TextPosition.Center);
Log("Please change the Bar Type", LogLevel.Error);
}
if (BarsPeriod.BarsPeriodType != BarsPeriodType.Week)
{
Draw.TextFixed(this, "Error", "Please change the Bar Type", TextPosition.Center);
Log("Please change the Bar Type", LogLevel.Error);
}
if (BarsPeriod.BarsPeriodType != BarsPeriodType.Month)
{
Draw.TextFixed(this, "Error", "Please change the Bar Type", TextPosition.Center);
Log("Please change the Bar Type", LogLevel.Error);
}
#endregion
}

But still same. When I keep and comment out rest, first one works, but when I start using 2nd one and rest, then same issue. Any advice?

[NinjaTrader_ChrisL]

Hi asmmbillah, thanks for your reply.

You should check this from OnBarUpdate and return from the method if one of your conditions becomes true. e.g.:

if (BarsPeriod.Value != 15 && BarsPeriod.BarsPeriodType == BarsPeriodType.Minute)
{
Draw.TextFixed(this, "Error", "Please change the Bar Type", TextPosition.Center);
Log("Please change the Bar Type", LogLevel.Error);
return;
}

[asmmbillah]

Thanks for your response. But still same. No change. I have checked them from OnBarUpdate and return from the method individually as per your example, but no luck. Anything else?

[NinjaTrader_ChrisL]

Hi asmmbillah, thanks for your reply.

I was able to get it to work from State.Historical. It proved to be a little more challenging since we need to accept more than one type of bar:

else if (State == State.Historical)
            {
                if((BarsPeriod.BarsPeriodType == BarsPeriodType.Minute) && BarsPeriod.Value != 15)
                {
                    Draw.TextFixed(this, "Error", "change minute chart to 15 Min chart", TextPosition.Center);
                    return;
                }
                else if((BarsPeriod.BarsPeriodType == BarsPeriodType.Day) && BarsPeriod.Value != 1)
                {
                    Draw.TextFixed(this, "Error", "change minute chart to 15 Min chart", TextPosition.Center);
                    return;
                }
                else if((BarsPeriod.BarsPeriodType == BarsPeriodType.Week) && BarsPeriod.Value != 1)
                {
                    Draw.TextFixed(this, "Error", "change minute chart to 15 Min chart", TextPosition.Center);
                    return;
                }
                else if((BarsPeriod.BarsPeriodType == BarsPeriodType.Month) && BarsPeriod.Value != 1)
                {
                    Draw.TextFixed(this, "Error", "change minute chart to 15 Min chart", TextPosition.Center);
                    return;
                }

            }

[asmmbillah]

Thanks for your suggestion and it worked.