Simple MACD indicator question

[tvaughan4]

So I'm just trying to make a simple indicator for my market analyzer telling me whether or not the MACD diff is larger or smaller than it was 1 bar ago. But it's not returning any data? Wondering what I'm doing wrong. Thanks.

namespace NinjaTrader.NinjaScript.Indicators.MyIndicators
{
public class myMACDdiff : Indicator
{
protected override void OnStateChange()
{
if (State == State.SetDefaults)
{
Description = @"Enter the description for your new custom Indicator here.";
Name = "myMACDdiff";
Calculate = Calculate.OnPriceChange;
IsOverlay = false;
DisplayInDataBox = true;
DrawOnPricePanel = true;
DrawHorizontalGridLines = true;
DrawVerticalGridLines = true;
PaintPriceMarkers = true;
ScaleJustification = NinjaTrader.Gui.Chart.ScaleJustification.Right;
//Disable this property if your indicator requires custom values that cumulate with each new market data event.
//See Help Guide for additional information.
IsSuspendedWhileInactive = true;

AddPlot(Brushes.Orange, "MACDdiff");
}
else if (State == State.Configure)
{
}
}

protected override void OnBarUpdate()
{
double currentdiff = MACD(6, 20, 9).Diff[0];
double olddiff = MACD(6, 20, 9).Diff[1];
Value [0] = currentdiff - olddiff;


}
}
}

[NinjaTrader_ChelseaB]

Hello tvaughan4,

Do you see any errors appear in the Log tab of the Control Center when running this script?

I see that an index of 1 barsAgo is used without any check that there is a bar 1 bar ago.

https://ninjatrader.com/support/helpGuides/nt8/currentbar.htm

As a tip, to export a NinjaTrader 8 NinjaScript so this can be shared and imported by the recipient do the following:

1. Click Tools -> Export -> NinjaScript...
2. Click the 'add' link -> check the box(es) for the script(s) and reference(s) you want to include
3. Click the 'Export' button
4. Enter a unique name for the file in the value for 'File name:'
5. Choose a save location -> click Save
6. Click OK to clear the export location message

By default your exported file will be in the following location:

• (My) Documents/NinjaTrader 8/bin/Custom/ExportNinjaScript/<export_file_name.zip>

Below is a link to the help guide on Exporting NinjaScripts.

http://ninjatrader.com/support/helpGuides/nt8/en-us/export.htm

[tvaughan4]

the CurrentBar check was the issue, thank you, attached the code

different issue now. it seems the output is slightly different from what I get on the graph on the chart. So right now I'm getting a difference reading of 2.28 on my market analyzer for this code. But if I do it manually on the histogram on the chart, it comes out to 2.83. Any idea why the two readings are different? should be the same I would think?

[tvaughan4]

nevermind, it was a data series issue, they match up now