• If this is your first visit, you will have to register before you can post. To view messages, please scroll below and select the forum that you would like to visits. Questions? Be sure to check out the Forum FAQ.

Announcement

Collapse
No announcement yet.

Partner 728x90

Collapse

Save As in Editor no longer changes Name and Public Class

Collapse
X
 
  • Filter
  • Time
  • Show
Clear All
new posts

    Save As in Editor no longer changes Name and Public Class

    Hey fellas -

    I'm reporting a bug using the latest version (8.0.15.1). In the Ninjascript Editor, open an existing script and then Save As a different name. The new script still has the Public Class and Name of the older script.

    When using an older version (8.0.14), the Public Class and Name automatically changed to your new name.

    #2
    Hello PN720,
    Thanks for your post.

    When I right-click>save-as to create a copy of a NinjaScript I would only expect for the class name to be changed. I can recall multiple times in the past having to manually change the "Name" property in SetDefaults.

    Are you seeing that the class name is not being changed?
    Josh G.NinjaTrader Customer Service

    Comment


      #3
      Right, I tested this:

      8.0.15.1 changes neither of those fields.
      8.0.14.2 changed both of those fields.

      Comment


        #4
        I do not see the same on my end using 8.0.15.1. Mine changes the class name just as I would expect it to. Please write in to PlatformSupport(AT)NinjaTrader(DOT)com and reference this forum post. Please include your log and trace files so that I may investigate. You may do so my following the steps below.
        1. Open your NinjaTrader folder under My Documents.
        2. Right click on the 'log' and 'trace' folders and select Send To> Compressed (zipped) Folder.
        3. Send the 2 compressed folders as attachments to this email.
        4. Once complete, you can delete these compressed folders.
        Josh G.NinjaTrader Customer Service

        Comment


          #5
          Hello PN720,

          Thank you for your patience.

          A fix is expected for implementation in the next release of NinjaTrader 8.

          Please let me know if you have any questions.
          Patrick H.NinjaTrader Customer Service

          Comment


            #6
            Hello Ninja!

            When I copy a file with "save as" or rename a file with "Rename" in NT 8.0.15.1, then the file name and class name changes but not the 'Name property' in OnStateChange. Is this the expected behavior?
            Last edited by poseidon_sthlm; 08-30-2018, 12:50 PM.

            Comment


              #7
              If you try this with the prior 8.0.14 version, it changes them both.

              Comment


                #8
                Hey guys,
                Just FYI...
                Using the newest version, 8.0.16.1, the Editor renames the 'Name' field correctly but the public class is still the old name. Again, this used to work correctly in 8.0.14 where both the public class and Name were successfully renamed.

                Comment


                  #9
                  Hello PN720,

                  From the editor you are right clicking in the script>save as> saving as a new name and you're seeing the class name at the top of the file stick to the old name?

                  Is this an indicator, strategy or addon or are you seeing it on all?

                  I look forward to your reply.
                  Alan P.NinjaTrader Customer Service

                  Comment


                    #10
                    Hi Alan,

                    Yes, I'm using the right click Save As on my custom strategy.

                    I just tried with the SampleMACrossover and it changed both the public class name and the Name.

                    Comment


                      #11
                      Hello PN720,

                      Thank you for your note.

                      Without the full code we're unable to test on our end.

                      If you'd like to upload the full code I can take a look and see if anything jumps out. Or if you'd prefer to email a copy, send to platformsupport[at]ninjatrader[dot]com with Attn: Alan P in the Subject line. Also within the email please include a link to this thread, and the files.

                      I look forward to your reply.
                      Alan P.NinjaTrader Customer Service

                      Comment


                        #12
                        Hi Alan,

                        Sorry to bump this old thread but I noticed that this issue still occurs with some of the code I downloaded from the Ninjatrader User Apps site.

                        For example using NJT 8.0.17.0:

                        1. https://ninjatraderecosystem.com/use...indicator-nt8/
                        2. After importing, you'll see it listed in Ninjascript Editor as 'SRSI'.
                        3. Right click on it and name it 'TestSRSI'.
                        4. Double click on the newly created 'TestSRSI'.
                        5. You'll notice the editor refresh and the public class will change to the new name but the 'Name' listed under SetDefaults will stay as the old name.

                        Comment


                          #13
                          Hello PN720,

                          Thank you for the post.

                          I will provide these details to development for further review.



                          I look forward to being of further assistance.
                          JesseNinjaTrader Customer Service

                          Comment

                          Latest Posts

                          Collapse

                          Topics Statistics Last Post
                          Started by sandman, Today, 02:32 PM
                          0 responses
                          1 view
                          0 likes
                          Last Post sandman
                          by sandman
                           
                          Started by ksarin, Today, 12:39 PM
                          3 responses
                          12 views
                          0 likes
                          Last Post NinjaTrader_PatrickG  
                          Started by ttodua, Today, 12:03 PM
                          1 response
                          6 views
                          0 likes
                          Last Post NinjaTrader_ChelseaB  
                          Started by tomtr27, Today, 11:35 AM
                          1 response
                          10 views
                          0 likes
                          Last Post NinjaTrader_ChelseaB  
                          Started by Uregon, Today, 07:30 AM
                          2 responses
                          13 views
                          0 likes
                          Last Post bltdavid  
                          Working...
                          X