• If this is your first visit, you will have to register before you can post. To view messages, please scroll below and select the forum that you would like to visits. Questions? Be sure to check out the Forum FAQ.

Announcement

Collapse
No announcement yet.

Partner 728x90

Collapse

GetDayBar - Not working as expected. How to get last working day OHLC Data?

Collapse
X
 
  • Filter
  • Time
  • Show
Clear All
new posts

  • NinjaTrader_ChrisL
    replied
    Hi,

    My apologies, the value can be null since Bar is nullable. I suspect the problem was from for (int i = 0; i < 10; i++) rather than for (int i = 1; i <= 10; i++). GetDayBar will only return prior daily bars. You can step through the code using Visual Studio debugging to find exactly when the return value is null.

    The CurrentDayOHL() indicator documentation can be found here:
    https://ninjatrader.com/support/help...nt_day_ohl.htm

    It is an indicator, so the source code can be viewed from the NinjaScript Editor. There is also the PriorDayOHLC indicator that might be of use.

    Please let me know if I can assist any further.

    Leave a comment:


  • raaxus
    replied
    Hi,

    Thanks it worked perfectly fine.

    But why my code wasn't working, because Bar is a class type and should be able to hold null values?

    CurrentDayOHL():
    Do you have any link for documentation of these kind of functions where i can reference? I hope this is an indocator?

    Thanks,

    Leave a comment:


  • NinjaTrader_ChrisL
    replied
    Hi raaxus, thanks for your note.

    You should check if the Bar return is null before assigning it. The index should also not go below 1. This method is used to get historical day bars. To get the current day bar use CurrentDayOHL() e.g. This will get the past 10 days:

    Code:
    protected override void OnBarUpdate()
            {
    
                Bars b = BarsArray[0];
    
                Bar d = null;
    
                for (int i = 1; i <= 10; i++)
                {
                    if (Bars.GetDayBar(i) != null)
                    {
                        d = Bars.GetDayBar(i);
                        Print(d.Close);
                    }
                }
            }
    Please let me know if I can assist any further.

    Leave a comment:


  • GetDayBar - Not working as expected. How to get last working day OHLC Data?

    Hi,

    I want to get the OHLC data for last trading day. while searching Ninja Help Guide, i get to know Bars.GetDayBar() which suits my requirement.

    But i tired calling this functions with possible combinations, but it is raising exception. Below is the code which i tried using.

    Bars b = BarsArray[0];

    Print(b.Count.ToString()); //Prints 2556 bars which is approx 10 days of data

    Bar day = null;

    for (int i = 0; i < 10; i++)
    {
    try
    {
    day = b.GetDayBar(i); //Always raise exception
    }
    catch { }

    if (day != null)
    break;
    }

    if (day == null)
    Print("Day is null"); //Always prints null


    Please tell me the best way to get previous OHLC data?

    Thanks

Latest Posts

Collapse

Topics Statistics Last Post
Started by TAJTrades, Today, 05:11 AM
0 responses
2 views
0 likes
Last Post TAJTrades  
Started by poeds, Today, 05:08 AM
0 responses
1 view
0 likes
Last Post poeds
by poeds
 
Started by Oliver81594, Today, 04:09 AM
0 responses
6 views
0 likes
Last Post Oliver81594  
Started by Nate G, Yesterday, 05:27 PM
1 response
14 views
0 likes
Last Post MojoJojo  
Started by Mindset, Yesterday, 10:35 PM
1 response
8 views
0 likes
Last Post Mindset
by Mindset
 
Working...
X