Is this a Ninjascript bug?

[cryfgg]

Why is Ninjascript not executing the logic of code below? The Draw.VerticalLine(see below) is not drawn even though the conditions are true, leading to that block of code with the Draw.VerticalLine. See attached pic for more info,

if((Close[0] < Open[0])
&& (Close[1] < Open[1])
&& (Close[2] > Open[2])
&& (Close[3] > Open[3])

)

{
HSBear11 = true;
HSBear1 = High[1];

}


if((Close[0] > Open[0])
&& (Close[1] > Open[1])
&& (Close[2] < Open[2])
&& (Close[3] < Open[3])
&& (HSBear11 == true)
&& (High[1] < HSBear1 )
)

{
HSBear12 = true;
HSBear2 = Low[1];

}


if((Close[0] < Open[0])
&& (Close[1] < Open[1])
&& (Close[2] > Open[2])
&& (Close[3] > Open[3])
&& (HSBear11 == true)
&& (HSBear12 == true)
&& (High[1] > HSBear1) //****
)

{
HSBear13 = true;
HSBear3 = High[1];
Draw.VerticalLine(this, @"Vertical line_1"+CurrentBar, 0, Brushes.Indigo, DashStyleHelper.Solid, 4);
}

[NinjaTrader_BrandonH]

Hello cryfgg,

Thanks for your post.

If the indicator is not working as expected, it is likely that the condition to draw the vertical line is not becoming true. You would need to add debugging prints to the script to ensure that the logic to draw the vertical line is being reached.

In the indicator, add prints to the script (outside of the condition) that print out each condition being used in your script to draw the vertical line and the Time of the bar. This will allow you to see if the conditions in your script are not becoming true. Prints will appear in a New > NinjaScript Output window.

Also, note the Log tab of the Control Center for any error messages that may appear when running your indicator.

Below is a link to a forum post that demonstrates how to use prints to understand behavior.

https://ninjatrader.com/support/foru...121#post791121

Let me know if I may assist further.

[cryfgg]

Hello cryfgg,

Thanks for your post.

If the indicator is not working as expected, it is likely that the condition to draw the vertical line is not becoming true. You would need to add debugging prints to the script to ensure that the logic to draw the vertical line is being reached.

In the indicator, add prints to the script (outside of the condition) that print out each condition being used in your script to draw the vertical line and the Time of the bar. This will allow you to see if the conditions in your script are not becoming true. Prints will appear in a New > NinjaScript Output window.

Also, note the Log tab of the Control Center for any error messages that may appear when running your indicator.

Below is a link to a forum post that demonstrates how to use prints to understand behavior.

https://ninjatrader.com/support/foru...121#post791121

Let me know if I may assist further.

I already did everything you said above but the Draw.VerticalLine isn't drawing because of the code below on the 3rd <If (statement)> See original post.

&& (High[1] > HSBear1)

As you can see from the pic I attached, the above code should return TRUE because that condition has been met. I'm not sure what I'm doing wrong or if Ninjascript is screwing with me.

[NinjaTrader_BrandonH]

Hello cryfgg,

Thanks for your note.

To clarify, you added prints to the script that print out 'High[1] > HSBear1', such as Print("High[1] > HSBear1: " + (High[1] > HSBear1) + " Time: " + Time[0]);, and the print in the Output window is reporting True for that condition at that time? Or, is this condition reporting False?

Please add prints to the script that print out each condition used to draw the vertical line on the chart and share a screenshot of the Output window prints showing all the conditions to draw the vertical line are becoming true so I may investigate further.

• To send a screenshot with Windows 10 or newer I would recommend using the Windows Snipping Tool.
  • Click here for instructions
• Alternatively to send a screenshot press Alt + PRINT SCREEN to take a screenshot of the selected window. Then go to Start--> Accessories--> Paint, and press CTRL + V to paste the image. Lastly, save it as a jpeg file and send the file as an attachment.
  • Click here for detailed instruction

I look forward to assisting further.

[cryfgg]

Hello cryfgg,

Thanks for your note.

To clarify, you added prints to the script that print out 'High[1] > HSBear1', such as Print("High[1] > HSBear1: " + (High[1] > HSBear1) + " Time: " + Time[0]);, and the print in the Output window is reporting True for that condition at that time? Or, is this condition reporting False?

Please add prints to the script that print out each condition used to draw the vertical line on the chart and share a screenshot of the Output window prints showing all the conditions to draw the vertical line are becoming true so I may investigate further.

• To send a screenshot with Windows 10 or newer I would recommend using the Windows Snipping Tool.
  • Click here for instructions
• Alternatively to send a screenshot press Alt + PRINT SCREEN to take a screenshot of the selected window. Then go to Start--> Accessories--> Paint, and press CTRL + V to paste the image. Lastly, save it as a jpeg file and send the file as an attachment.
  • Click here for detailed instruction

I look forward to assisting further.

I followed your recommendation, and was able to find out the issue. How do i solve the issue below.

Here is my current code (simplified)

If (A)
{
B = high[0]
A1 = True
}

If ((A) // that is, if "A" happens again
&& A1 == True
&& High > B ) // which never returns - True. Always, returning False.
{
B1 = True
}

The problem with the above code is this line "&& High > B". It is never true because whenever "A" is True it assigns the High[0} to B. Thus, the High[0] is never greater than "B".

How do I keep track of multiple instances of "A" occurring? I'm trying to track each instances of "A" occurring independently.

For example, I want to track each occurrence of the below code separately:
if((Close[0] < Open[0])
&& (Close[1] < Open[1])
&& (Close[2] > Open[2])
&& (Close[3] > Open[3])
)

Your assistance will be greatly appreciated. I'm new to NinjasSript.

[NinjaTrader_ChelseaB]

Hello cryfgg,

To confirm, you need for a condition to evaluate as true and then later for a second condition to evaluate as true, before triggering an action, is this correct?

You can use a bool or set of bools to track this.

When the first condition is true, set the bool to true as a trigger. When the second condition is true and the bool is true, then trigger the action.

Below is a link to an example.

https://ninjatrader.com/support/forum/forum/ninjatrader-8/strategy-development/1130921-entering-trade-when-conditions-don-t-happen-simultaneasly?p=1131172#post1131172