Help for the blind. I just don't my error.

[ct]

I have been working on Ninja 7 for over a decade but am transitioning to Ninja 8.

I have a set of conditional code but I don't see any error in my code. I am guessing something is different on Ninja 8.

What I am trying to achieve: I added several time frames but only want to process these additional time frames after I hit a Session begin for BarsInProgress == 1. I am using the variable BarsinProgress1SessionStart to designate I hit a session begin. At first I used a bool but after having issues I tried an integer but currently it is a string.

here is some code snippets:
// Declare the variable
private string BarsinProgress1SessionStart ="0";

----------------------------

// set the variable default to "0" like a bool.
protected override void OnStateChange()
{
if (State == State.SetDefaults)
{
BarsinProgress1SessionStart = "0";

//Set the variable to "1" when IsFirstBarOfSession && BarsInProgress == 1). This code works fine.
if (Bars.IsFirstBarOfSession && BarsInProgress == 1)//if New session - reset counters - Reset Arrays
{
Print("2.1 "+ Volume[0] + " , " + Bars.IsFirstBarOfSession + " , " + CurrentBar + " ," + BarsinProgress1SessionStart + " , " + Time[0] + " , " + BarsInProgress);
BarsinProgress1SessionStart = "1";//Flag You have received an session begin
--------------------

// Skip any ticks if the Session Start has not been hit
if (BarsinProgress1SessionStart == "0");// If you have not received a session start or it is BarsInProgress == 0
{
if (DebugCount < 20)//Only print the first 20 ticks showing BarsInProgress and the value of BarsinProgress1SessionStart
{
DebugCount ++;
Print("2.2a " + BarsInProgress + " , " + BarsinProgress1SessionStart);
}
return;//Exit - skip ticks until otherwise false
}

// Her is a debug listing from the above code, you can clearly seethe 2.2a BarsinProgress1SessionStart is "1" but the "if" logic clearly says only do if: if (BarsinProgress1SessionStart == "0").
The value is "1" but executes the code when it should not be.
2.1 1 , True , 0 ,0 , 1/24/2023 2:20:00 AM , 1
2.2a 1 , 1
2.2a 1 , 1
2.2a 2 , 1
2.2a 1 , 1
2.2a 1 , 1
2.2a 1 , 1
2.2a 1 , 1
2.2a 2 , 1
2.2a 5 , 1
2.2a 2 , 1

Any help or suggestions for a blind guy? I have been a software developer for multiple decades so am not a newbie. I just don't see what I am doing wrong.

Cheers

[bltdavid]

Have you tried moving the processing code to OnBarUpdate?

I mean, after initializing your SessionStart variable to '0', the
remainder of that code has no business being executed in
OnStateChange.

Isn't that code already in OnBarUpdate in your NT7 code?

Think about it, at each bar close, you want to know if that bar
was the start of the session, right? You want to repeat this
check each time a bar closes. That screams locating that
code in OnBarUpdate, not OnStateChange.

Make sense?

[bltdavid]

As you move forward, you'll learn very little code needs to go
into OnStateChange().

These general rules may help:
Your NT7 Initialize() code goes into State.SetDefaults.
Your NT7 OnStartUp() code goes into State.DataLoaded.
Your NT7 OnTermination() code goes into State.Terminated.
Your NT7 OnBarUpdate() code stays in OnBarUpdate.

Hang in there!

[bltdavid]

Early in the NT8 beta period, someone wrote
an NT7 to NT8 conversion utility.

It was a C# program executed by LINQPad.

I thought it worked pretty darn well.

Let me find the link ...

[bltdavid]

Found it.

Study this thread.

[NinjaTrader_ChelseaB]

Hello bltdavid,

Thank you for providing the great advice!

ct,

bltdavid is correct. BarsInProgress, Bars.IsFirstBarOfSession, CurrentBar, Time[0], and Volume[0] are all series related and cannot be used in OnStateChange(). Move this code to OnBarUpdate().

https://ninjatrader.com/support/helpGuides/nt8/onbarupdate.htm

https://ninjatrader.com/support/helpGuides/nt8/currentbar.htm

https://ninjatrader.com/support/helpGuides/nt8/isfirstbarofsession.htm

https://ninjatrader.com/support/helpGuides/nt8/iseriest.htm

https://ninjatrader.com/support/helpGuides/nt8/iseries_time.htm

https://ninjatrader.com/support/helpGuides/nt8/iseries_volume.htm

Below is a link to a forum post on porting scripts.

https://ninjatrader.com/support/forum/showthread.php?p=490313#post490313

As well as a link to a forum post with helpful resources on getting started with NinjaScript 8 scripts.

https://ninjatrader.com/support/forum/forum/ninjatrader-8/indicator-development/97575-sample-scripts#post786040

[ct]

To bltdavid I wish to say this blind moron says "thank you very much". You are an absolute star! I get it now. I feel like a rookie.