Settings in Grid - Array of Enums not supported ?

[misova]

Hi guys,

in NT7 - one could configure List/Array of enums in grid with settings.

This is not possible to configure in NT8 anymore.
The grid with enum settings display correct values set from code.
User can change value for existing enum (existing enums = added from code),
but one cannot add additional enum (or remove existing enum).
But the Array / List of enums are expected to be configurable - the same way like it worked with NT7.

See screenshot in NT8 and see,
there is no way to Add / Remove from collection of selected enums.




In NT7 it worked correctly this way:
One could

• Add enum
• Remove enum
• Modify enum to different value

[NinjaTrader_JessicaP]

Thank you for your question misova. I was unable to locate a FaAsset tool online for NinjaTrader. While we can not provide support for this custom software directly, it may help users familiar with this software if you could provide a link showing where you got this tool from in NinjaTrader 7 and NinjaTrader 8.

If you are the developer of the FaAsset tool, I'd like to recommend reviewing the following links which should help you set up a custom properties grid in NT8.

http://ninjatrader.com/support/forum/showthread.php?p=494289#post494289

http://ninjatrader.com/support/forum/showthread.php?t=3420

http://ninjatrader.com/support/forum/showthread.php?t=97919

We are happy to help with any questions that come up.

[misova]

Hi,

this is misunderstanding.
FaAsset is not an external tool - it is simple enum used in my custom strategy

public enum FaAsset
{
        // Currencies
        USD, EUR, GBP, CHF, NZD, AUD, CAD, JPY, CNY,
        // Commodities - Metals
        GOLD, SILVER, COPPER,
        // Commodities - Energy
        CRUDE_OIL, HEATING_OIL, NATURAL_GAS,
        // Commodities - Grains
        CORN, SOYA_BEAN, WHEAT,
        // Commodities - Softs
        COFFEE, COCOA, COTTON, SUGAR, LUMBER, ORANGE_GUICE,
        // Commodities - Meat
        LEAN_HOGS, LIVE_CATTLE, FEEDER_CATTLE
}

My strategy exposes settings in - and one of the property is of type FaAsset.
I simply exposed it as property of my strategy. This way in code

private FaAsset[] blockTrading_aroundFa_1_assets = new FaAsset[] { FaAsset.EUR, FaAsset.USD };

[NinjaScriptProperty]
[Display(GroupName = "2b1. Market context # Block trading around Fa - Volatility", Name = "Assets", Order = 2, Description = "")]
public FaAsset[] BlockTrading_AroundFa_1_Assets
{
   get { return blockTrading_aroundFa_1_assets; }
   set { blockTrading_aroundFa_1_assets = value; }
}

This is, what you see in screenshot.

Please reproduce with attached strategy.
I modified SampleMaCrossOver - so it demonstrates the problem in minimalistic example.

Please try to add / remove element in the settings - and you will see, it is not possible. It is possible to only modify existing element - that was previously added from the code.

Simply said, there NT8 does not have any working Collection / List / Array Editor in the Settings Grid, that could Add / Remove elements.

The same scenario is correctly working in NT7 = it is possible to add / remove / modify any element in GUI settings.

[misova]

I can confirm, that official reference example also does not work for Collection editor.

I attach oficial reference example indicator for reproducing the problem.
(Source of this indicator is NT8 here: http://ninjatrader.com/support/forum...ad.php?t=97919 )

Please use attached indicator - and check Scenario #5, which is editing Collection.
It simply does not work and shows just empty box.

This happens on current latest: NT8 v8.0.6.1

Look at the problem on screenshot below

[misova]

As an aditional example, to show, that Collection editor does not work,
I am attaching minimalistic example - modified @SampleMACrossOver.cs

@SampleMACrossOver.cs

Exception is thrown:

[NinjaTrader_JessicaP]

Thank you misova. In my earlier post I had some posts related to this that I would like to add again to this post.

http://ninjatrader.com/support/forum/showthread.php?p=494289#post494289

http://ninjatrader.com/support/forum/showthread.php?t=3420

http://ninjatrader.com/support/forum/showthread.php?t=97919

For reference I was also able to locate on the internet the publicly available resource you were referencing in your first post

https://www.codeproject.com/Articles/24332/Creating-a-Custom-Collection-for-Use-in-a-Property

The reason you are seeing this is because NT8 does not use WinForms technology the way the linked CodeProject sample does. Instead, NT8 uses WPF UI technology. Please review the three linked posts for examples on using the properties grid in NT8. As a convenience I have attached the SampleIndicatorTypeConverter_NT8.zip from the third link to this post directly.

[misova]

Thank you Jessica,

I used SampleIndicatorTypeConverter_NT8.zip from your last post,
and there is still the same problem.

Confirm please, if you can reproduce the problem on NT8 v8.0.6.1

I have reviewed provided links, but still cant make it work.
If possible,provide me with some minimalistic working example, where collection editor works please.

It just does not work correctly.
See this screenshot please.

[NinjaTrader_JessicaP]

Thank you misova. I have seen the same on our end. I am reviewing our code samples and will return when I have more information. In the meantime this page has the best explanation as to what is happening.

http://ninjatrader.com/support/forum/showthread.php?t=77400

[misova]

Thank you Jessica, I am looking forward for the result,
because this is blocking our migration from NT7 to NT8.

Working CollectionEditor is a must have for configuration all of our strategies.

[NinjaTrader_JessicaP]

I was able to determine that, between when that sample was posted and today, there was a code breaking change which keeps the sample from working. I have approached the responsible teams.

I have attached a working version of this tool to this post so you have it right away. Please let us know if there are any other ways we can help.

[misova]

I was able to determine that, between when that sample was posted and today, there was a code breaking change which keeps the sample from working. I have approached the responsible teams.

I have attached a working version of this tool to this post so you have it right away. Please let us know if there are any other ways we can help.

Excellent, thank you Jessica for providing us with the solution!

[misova]

Hi Jessica,

I tested provided solution.

• I can confirm - it works on Indicators really well.
• But it does not work, when applied to Strategies.

Result looks broken - there is no editing capabalities and it fails on exception finally.
See the screenshot


After closing the dialog, this exception is thrown:


Please

• download my minimalistic example = modified @SampleMACrossOver.cs,
• and confirm, if you can reproduce it.

If possible, it would be really nice, if you could provide us also with similar handy solution,
that works for Strategies, because they are of our primary concern in our transition from NT7 to NT8..

Best regards
Misova

[NinjaTrader_JessicaP]

This behavior was confirmed on our end. We will be investigating this further. Please keep an eye on the NinjaTrader 8 Release Notes page for updates and bugfixes.

http://ninjatrader.com/support/helpGuides/nt8/en-us/release_notes.htm

Tracking ID:
NTEIGHT-11645

[NinjaTrader_JessicaP]

I have some more information regarding this. I have attached a work-around. There is an internal limitation similar to these :

AddOn Classes which derive from NTWindow or implements IWorkspacePersistance CANNOT be a nested type of another class and MUST have a default constructor

Note: AddOn Classes which derive from NTWindow or implements IWorkspacePersistance CANNOT be a nested type of another class and MUST have a default constructor

The way to work around this is to move PercentWrapper directly into the Strategy namespace. The attached example does this.

[misova]

Hi Jessica,

please add a request, that for enum classes should be handled automatically - without need to code custom Wrapper classes.

As enums are frequently used for selection and they are now supported in NT7 out of the box,
they should be supported also for NT8 out of the box = without need to write custom Wrappers around enum classes.

Coding custom wrappers make sense in case of our very custom classes, but not for standardized class like enums. Such basic scenario should be supported automatically for convenience of the developers, without requiring them more work, than is really needed..

Internal implementation can be:
Some default EnumWrapper should be automatically used, in case enum class is used, so there is no need to add our own Wrapper.