NT7 conversion

[2Look4me]

Hi,
* In my NT7 strategy I'm calling another indicator without any problems, but as I convert the strategy to NT8 I get the following error: "No overload for method "...xyz" takes 1 arguments" in another instance I get "No overload for method "..abc" takes 2 arguments.

* For NT7 I have if(!Historical)...., what's the NT8 conversion?
* For NT7 I have "+ (SystemPerformance.RealtimeTrades.Count)", what's the NT8 conversion?
* For NT7 I have "+ ((int)SystemPerformance.RealtimeTrades.TradesPerfo rmance.Currency.DrawDown)", what's the NT8 conversion?

Thanks

[NinjaTrader_ChrisL]

Hello 2Look4me,

Thanks for the note.

For the indicator arguments, you can type the name of the indicator, then add a '('. After this, you will see a list of valid argument overloads in the NinjaScript editor.

Historical has been replaced with the state State.Historical. In NinjaTrader 8, you would check for the historical state like so: if(State == State.Historical)

The SystemPerformance class remains. The Count property is now TradesCount.

https://ninjatrader.com/support/help...collection.htm - TradeCollection

Drawdown still exists in the TradePerformanceValues class:

https://ninjatrader.com/support/help...ancevalues.htm

The code-breaking changes page is a good resource for finding these items:

https://ninjatrader.com/support/help...ng_changes.htm

Please let me know if I can assist further.

[2Look4me]

Chirs, thanks for the speedy reply.

After making the changes to:
Draw.TextFixed(this,"Drawdown", "Drawdown: " + (SystemPerformance.AllTrades.TradesPerformance.Cur rency.DrawDown), TextPosition.TopLeft);
I'm getting the following error: NinjaTrade.Cbi.TradesPerformanceValues does not contain a definition for “DrawDown” and no extension……

Thanks

[NinjaTrader_ChrisL]

Hello 2Look4me ,

Thank you for the reply.

It looks like the 'd' in "down" is not capital, changing that should work.

Drawdown

Please let me know if I can assist further.

[2Look4me]

That shouldn't make a difference in the error message since "Drawdown" is a text inside quote marks.

[NinjaTrader_ChrisL]

Hello 2Look4me ,

Thanks for the reply.

The correct syntax would be written like so:

Draw.TextFixed(this,"Drawdown", "Drawdown: " + (SystemPerformance.AllTrades.TradesPerformance.Currency.Drawdown), TextPosition.TopLeft);

Please let me know if I can assist further.

[2Look4me]

Thanks Chris that worked. Also with regards to one of my initial questions, In NT7 I'm calling an indicator (ATR as a trailing indicator)
double ATRtrail = ATRTrailStop(4,3).ATRstop[0]; Where 4=double multi, 3=int period.

In the conversion to NT8, as I call the indicator the following error appears: "No overload for method "....." takes 2 arguments . The valid argument overload in the NinjaScript editor is " (ISeries<double>input)". What is that referring to and how to get rid of the error in NT8?

[NinjaTrader_ChrisL]

Hello 2Look4me,

Thanks for the reply.

The argument list needs a series to process. For example: ATRTrailStop(Close, 4,3).ATRstop[0]

That should fix it. Please let me know if I can assist further.

[2Look4me]

Sorry Chris, but ATRTrailStop(Close,4,3).ATRstop[0] didn't help because the error now is that it takes 3 arguments. "No overload for method "....." takes 2 arguments

[NinjaTrader_ChrisL]

Hello 2Look4me,

Thank you for the reply.

When you type "ATRTrailStop(", what do you see for the first parameter list?

I look forward to your reply.

[2Look4me]

When typed "ATRTrailStop(" the first parameter that shows up is " (ISeries<double>input)"

[NinjaTrader_ChrisL]

Hello 2Look4me,

Thanks for the reply.

There should be other overloads for the proper arguments to provide. Please try using the arrow keys on your keyboard to find the proper overload (One that includes the series and both of the other parameters).

Is the ATRTrailStop open source? If so could you export it then post it here?

I look forward to your reply.

[2Look4me]

Thanks again, I'm including the attachment.
ATRTrailStop2.zip

[NinjaTrader_ChrisL]

Hello 2Look4me,

Thanks for the reply.

Your properties do not have the [NinjaScriptProperty] decorator. This must be present, then you will see the properties in the argument list of ATRTrailStop.

  [Description("ATR period")]
        [Category("Parameters")]
        [NinjaScriptProperty]
        public int Period
        {
            get { return period; }
            set { period = Math.Max(1, value); }
        }

        [Description("ATR multiplication")]
        [Category("Parameters")]
        [NinjaScriptProperty]
        public double Multi
        {
            get { return multi; }
            set { multi = Math.Max(0, value); }
        }

Please let me know if I can assist futher.

[2Look4me]

Chris, I'm still a bit confused after reading the NinjaScripProperty Attribute help guide. Upon calling a custom indicator when and what determines the use of this attribute? Because I have other indicators that are being called, but I'm not having any issues without the NinjaScriptProperty attribute added.

Also, I'm getting the following error after adding the attribute to the indicator : " The indicator is inaccessible due to its protection level".

Thanks