Announcement

Collapse

Looking for a User App or Add-On built by the NinjaTrader community?

Visit NinjaTrader EcoSystem and our free User App Share!

Have a question for the NinjaScript developer community? Open a new thread in our NinjaScript File Sharing Discussion Forum!
See more
See less

Partner 728x90

Collapse

Iteration failure

Collapse
X
 
  • Filter
  • Time
  • Show
Clear All
new posts

    Iteration failure

    I have the code below and I expected at the beginning of each bar to have " i " increasing by 1, but it is always 0. What am I doing wrong here?
    Thank you

    Code:
    protected override void OnStateChange()
            {
                ....
    
                else if (State == State.Configure)                
                {
                    AddDataSeries(Data.BarsPeriodType.Tick, 1);
                    AddDataSeries(Data.BarsPeriodType.Minute, 5);               
                }    
    protected override void OnBarUpdate()
            {  
    if (BarsInProgress == 2)
                {
    i                       =  0;
    if (IsFirstTickOfBar)
                    {            // Finding Price swings High and Low                    
                                if (Highs[2][i+1] < Highs[2][i+2] && Highs[2][i+2] > Highs[2][i+3] && Math.Abs(Highs[2][i+1] - Highs[2][i+2]) > TickSize && Math.Abs(Highs[2][i+2] - Highs[2][i+3]) > TickSize) 
                                {
                                    HSwPrice[i] = Highs[2][i+2];
                                    HSwPriceBar = CurrentBar - 2;
                                    HSwPriceSeriesBar = i;
                                 }
    ......................
                      }
    i++;
                    }

    #2
    Hi itrader46, thanks for your note.

    It looks like your setting i = 0 on every OnBarUpdate call. Right below BarsInProgress == 2 there is i = 0;

    Set up int i; on the class level to create a class member then increment it in OnBarUpdate. e.g.

    public class MyCustomStrategy4 : Strategy
    {
    int i = 0;
    ...
    OnBarUpdate()
    {
    i++;
    }

    Best regards,

    -ChrisL
    Chris L.NinjaTrader Customer Service

    Comment

    Latest Posts

    Collapse

    Topics Statistics Last Post
    Started by giulyko00, Yesterday, 12:03 PM
    2 responses
    10 views
    0 likes
    Last Post giulyko00  
    Started by r68cervera, Today, 05:29 AM
    0 responses
    3 views
    0 likes
    Last Post r68cervera  
    Started by geddyisodin, Today, 05:20 AM
    0 responses
    6 views
    0 likes
    Last Post geddyisodin  
    Started by JonesJoker, 04-22-2024, 12:23 PM
    6 responses
    35 views
    0 likes
    Last Post JonesJoker  
    Started by GussJ, 03-04-2020, 03:11 PM
    12 responses
    3,241 views
    0 likes
    Last Post Leafcutter  
    Working...
    X