It contains property MarketPosition, which can have 3 possible values:
- Long // this looks logical, if execution was in Long direction
- Short // this looks logical, if execution was in Short direction
- Flat // this does'n give me any sense for execution
Execution is always filled in Long or Short direction. Cannot be filled in "Flat" direction. But the API says, it is potential value for execution.
Flat position is logical in context of measuring position for the whole strategy,
but does not make sense in context of execution. API provides invalid potential values and users can expect and check execution against Flat value, which is logical nonsense introduced by not best API design.
I suggest, we need right enum called:
enum Direction{ Long, Short }
In case the MarketPosition enum was used to simply reuse some existing type,
it is wrong reuse, which leads to invalid and misleading concept, that execution direction
can be Flat. In my opinion, this is nonsense and should be fixed.
Best regards
Misova
Comment