Announcement

Collapse
No announcement yet.

Partner 728x90

Collapse

Custom Bar Types Not working in NT 8.0.0.0.9

Collapse
X
 
  • Filter
  • Time
  • Show
Clear All
new posts

    Custom Bar Types Not working in NT 8.0.0.0.9

    A couple of custom bar types namely Unrenko, and BetterRenko will not compile under new NT8, Beta 9. These were previously installed under Beta 8 and were working just fine. Wonder if other custom bar types will work under beta 9.

    Cheers!

    #2
    Originally posted by aligator View Post
    A couple of custom bar types namely Unrenko, and BetterRenko will not compile under new NT8, Beta 9. These were previously installed under Beta 8 and were working just fine. Wonder if other custom bar types will work under beta 9.

    Cheers!
    There were some code breaking changes related to the Session Iterator in B9 which were noted in the code breaking changes to help 3rd party developers as they update. This could potentially cause issues with your custom scripts until the 3rd party developers work on them.

    If you have access to these files and are willing to share, you can upload them to our forums so we can review to ensure the code breaking changes are properly reflecting these changes.
    MatthewNinjaTrader Product Management

    Comment


      #3
      Originally posted by NinjaTrader_Matthew View Post
      There were some code breaking changes related to the Session Iterator in B9 which were noted in the code breaking changes to help 3rd party developers as they update. This could potentially cause issues with your custom scripts until the 3rd party developers work on them.

      If you have access to these files and are willing to share, you can upload them to our forums so we can review to ensure the code breaking changes are properly reflecting these changes.

      Hi Matthew,

      Here sharing the Unirenko and BetterRenko Bar types for NT8. They did work on Beta 8 but will not work on Beta 9. Please review for a fix.

      Thanks.
      Attached Files

      Comment


        #4
        Thanks. These are a result of the code breaking changes noted in the release notes.

        I was able to resolve these for you and the attached should work once you re-import.

        For any developers, it was just a matter of creating a SessionIterator from the incoming bars object:

        Code:
        protected override void OnDataPoint(Bars bars, double open, double high, double low, double close, DateTime time, long volume, bool isBar, double bid, double ask)
        {
        	if (this.SessionIterator == null)
        		this.SessionIterator = new SessionIterator(bars);
        
        
        }
        Then replace any bars.SessionIterator instances with this.SessionIterator

        Edit: Files updated in post #7 http://ninjatrader.com/support/forum...74&postcount=7
        Last edited by NinjaTrader_Matthew; 02-24-2016, 10:47 AM.
        MatthewNinjaTrader Product Management

        Comment


          #5
          Can anyone confirm if this updated unirenko works on Beta 9 ?
          ( I dont get compile errors but chart is wrong )
          pmaglio
          NinjaTrader Ecosystem Vendor - The Indicator Store

          Comment


            #6
            Hello pmaglio,

            Thank you for your post.

            Are the bars different from NinjaTrader 7? Can you attach a screenshot of what is wrong and what it should look like?
            Last edited by NinjaTrader_PatrickH; 02-24-2016, 10:49 AM.

            Comment


              #7
              Originally posted by pmaglio View Post
              Can anyone confirm if this updated unirenko works on Beta 9 ?
              ( I dont get compile errors but chart is wrong )
              I've attached an updated copy which should fix the issues with break end of day.
              Attached Files
              MatthewNinjaTrader Product Management

              Comment


                #8
                Thanks Patrick, I downloaded the last version available on the forum and it works now
                pmaglio
                NinjaTrader Ecosystem Vendor - The Indicator Store

                Comment


                  #9
                  Hello,

                  is there somebody who is willing to check and fix the unirenko bars. There are several changes in the following betas and final release. The versions posted on the forum is not working on the charts and also in the backtest.

                  Thank you

                  Miroslav

                  Comment


                    #10
                    Originally posted by miroslav View Post
                    Hello,

                    is there somebody who is willing to check and fix the unirenko bars. There are several changes in the following betas and final release. The versions posted on the forum is not working on the charts and also in the backtest.

                    Thank you

                    Miroslav
                    UniRenko seems to be working fine on my side (8.0.1.0 64-bit =
                    pmaglio
                    NinjaTrader Ecosystem Vendor - The Indicator Store

                    Comment


                      #11
                      Originally posted by pmaglio View Post
                      UniRenko seems to be working fine on my side (8.0.1.0 64-bit =
                      Hello, the version from this forum or the version created by sim22. In the version from sim22 there is one issue with phantom bar on the opening of the session of the last trading day. You can easily reproduce it:

                      1. connect+reload historical data
                      2. close NT
                      3. open NT and have a look on the last trading day you will see difference between what you saw when closing NT and the new opening of NT.

                      When new trading day/session is created you will not see the phantom bar on that day but on the new one. Same applies to backtesting.

                      Miroslav

                      Comment


                        #12
                        Hello miroslav,

                        Thank you for your post.

                        I don't believe I am seeing what you detail. Can you provide a before shut down and after start up screenshot set?

                        Comment


                          #13
                          Originally posted by NinjaTrader_PatrickH View Post
                          Hello miroslav,

                          Thank you for your post.

                          I don't believe I am seeing what you detail. Can you provide a before shut down and after start up screenshot set?
                          Hello Patrick,

                          see attached files. It is only occurring on the last trading day. I am using this unirekno script:



                          The one on this thread is not working on my end. It says unhandled exception while loading charts and in backtest object not set as instance.
                          Attached Files

                          Comment


                            #14
                            Hello miroslav,

                            Thank you for your patience.

                            I am unable to recreate this on my end. Are you running R1? Can you provide a screenshot of the Data Series menu?

                            Comment


                              #15
                              Originally posted by NinjaTrader_PatrickH View Post
                              Hello miroslav,

                              Thank you for your patience.

                              I am unable to recreate this on my end. Are you running R1? Can you provide a screenshot of the Data Series menu?
                              Hello Patrick,

                              sure.

                              I am running on the version 8.0.1 (final release).

                              See attached picture. Btw. you can ask also Jason who confirmed occurrance. Initialy, I was dealing with the open of the session.

                              Miroslav
                              Attached Files

                              Comment

                              Latest Posts

                              Collapse

                              Topics Statistics Last Post
                              Started by kujista, Today, 05:44 AM
                              0 responses
                              5 views
                              0 likes
                              Last Post kujista
                              by kujista
                               
                              Started by ZenCortexCLICK, Today, 04:58 AM
                              0 responses
                              5 views
                              0 likes
                              Last Post ZenCortexCLICK  
                              Started by sidlercom80, 10-28-2023, 08:49 AM
                              172 responses
                              2,281 views
                              0 likes
                              Last Post sidlercom80  
                              Started by Irukandji, Yesterday, 02:53 AM
                              2 responses
                              18 views
                              0 likes
                              Last Post Irukandji  
                              Started by adeelshahzad, Today, 03:54 AM
                              0 responses
                              8 views
                              0 likes
                              Last Post adeelshahzad  
                              Working...
                              X