Announcement

**koganam** · 06-04-2018, 11:44 PM

Originally posted by cbadr View Post

Hi,

I have an issue to declare

HTML Code:

SetStopLoss(CalculationMode.Ticks, stopLossTicks)

on OnStateChange() .

The problem is that the stopLossTicks is not a fixed but obtained from the ATR(4)[0]. Every bar the value of stopLossTicks change.

I've put the logic in OnBarUpdate() to get a dynamic StopLoss Modification to BreakEven and then TrailingStop based on the attached file.

Do you have any idea how can i give the stopLossTicks variable into
State.Configure?

Code:

protected override void OnStateChange()
   {
   if (State == State.SetDefaults)
   {
      Description   = ........

       AddPlot(new Stroke(Brushes.Lime, 2), PlotStyle.Hash, "ProfitTarget");
       AddPlot(new Stroke(Brushes.Red, 2), PlotStyle.Line, "StopLoss");
     }
     else if (State == State.Configure)
      {                            
      SetStopLoss(CalculationMode.Ticks, stopLossTicks);
      }
 }


protected override void OnBarUpdate()
 {
int ATR_VAL                 =     (int)(ATR(4)[0]/ TickSize); 
int stopLossTicks             =   (int)(ATR_VAL * 2.6);

if ( Position.MarketPosition == MarketPosition.Flat 
      && Close[1] < Close[0])     
      {    
       EnterLongLimit(1, Close[0], "LongEntry");            
      }
          
       switch (Position.MarketPosition)
         {            
           case MarketPosition.Flat:
                    SetStopLoss(CalculationMode.Ticks, stopLossTicks);
                    previousPrice = 0;
                    stopPlot = 0;
                    break;               
                       
             case MarketPosition.Long:                        
                    if (previousPrice == 0)
                    {
                     stopPlot = Position.AveragePrice - stopLossTicks * TickSize;  // initial stop plot level
                     }
                    
                     if (Close[0] > Position.AveragePrice + 5 * TickSize  && previousPrice == 0)
                    {
                        initialBreakEven = Position.AveragePrice + 3 * TickSize;
                        SetStopLoss(CalculationMode.Price, initialBreakEven);
                        previousPrice = Position.AveragePrice;
                        stopPlot = initialBreakEven;
                    }                    
                    else if (previousPrice    != 0 
                             && GetCurrentAsk() > previousPrice + 7 * TickSize )
                    {
                        newPrice = previousPrice + 2 * TickSize;     /
                        SetStopLoss(CalculationMode.Price, newPrice);           
                        previousPrice = newPrice;                                
                        stopPlot = newPrice;                                      
                     }
                    
                     StopLoss[0]     = stopPlot;

                    break;

                default:
                break;
            }            

        }

1. Declare both of these as class variables, not local to OnBarUpdate():

Code:

int ATR_VAL                 =     0; 
int stopLossTicks             =   0;

2. Add an initialStopLossTicks value to use to reset when Flat

Code:

int initialStopLossTicks = 13 //say, or whatever value you prefer to use

3. In State.Configure, set the initialStopLoss

Code:

...
     else if (State == State.Configure)
      {                            
      SetStopLoss(CalculationMode.Ticks, initialStopLossTicks);
      }

4. Update them on each pass in OnBarUpdate(), without redeclaring them:

Code:

ATR_VAL                 =     (int)(ATR(4)[0]/ TickSize); 
stopLossTicks             =   (int)(ATR_VAL * 2.6);
...

5. When Flat, reset the StopLossTicks:

Code:

...
           case MarketPosition.Flat:
                    SetStopLoss(CalculationMode.Ticks, initialStopLossTicks);
                    previousPrice = 0;
                    stopPlot = 0;
                    break;

**cbadr** · 06-05-2018, 05:37 AM

Thanks for the answer.
When you say to declare in a class shall i put something like that just before OnStateChange():

Code:

private InnerClass inner = new InnerClass();          

private class InnerClass
{
int ATR_VAL                   =   0;  
int stopLossTicks           =   0; 
int initialstopLossTicks   =   13; 
}

**NinjaTrader_Jesse** · 06-05-2018, 07:18 AM

Hello cbadr,

I believe koganam just meant for you to declare the variables inside of the indicators class or at class level. You wouldn't need to make any new objects here, so like the following in your existing file:

Code:

	public class Test : Indicator
{
	int ATR_VAL                 =     0; 
	int stopLossTicks             =   0;

I look forward to being of further assistance.

Topics	Statistics	Last Post
BuySellVolumeOneTick not accurate on range charts by EB Worx Started by EB Worx, 04-04-2023, 02:34 AM	7 responses 161 views 0 likes	Last Post by VFI26 Today, 07:52 AM
OIF File Error from Tradestation - System.IO.IOException was Thrown by Mizzouman1 Started by Mizzouman1, Today, 07:35 AM	1 response 6 views 0 likes	Last Post by NinjaTrader_Gaby Today, 07:49 AM
Additional Data Series (higher time frame) in the Strategy Builder by Radano Started by Radano, 06-10-2021, 01:40 AM	20 responses 616 views 0 likes	Last Post by NinjaTrader_BrandonH Today, 07:40 AM
modify UI elements on Chart Trader by i019945nj Started by i019945nj, 12-14-2023, 06:41 AM	6 responses 68 views 0 likes	Last Post by i019945nj Today, 07:35 AM
How can I set a take profit and stop loss for this position in Ninjascript by aa731 Started by aa731, Today, 02:54 AM	1 response 8 views 0 likes	Last Post by NinjaTrader_BrandonH Today, 07:28 AM

Announcement

Looking for a User App or Add-On built by the NinjaTrader community?

Partner 728x90

Probleme variable OnStateChange()

Probleme variable OnStateChange()

Comment

Comment

Comment

Latest Posts