Go Back   NinjaTrader Support Forum > NinjaTrader 8 > Indicator Development

Indicator Development Support for the development of custom indicators using NinjaScript.

NinjaTrader
Reply
 
Thread Tools Display Modes
Old 01-02-2018, 10:43 AM   #1
nkhoi
Senior Member
 
Join Date: Nov 2004
Location: , ,
Posts: 186
Thanks: 10
Thanked 38 times in 27 posts
Default opacity - good practice?

This code works but is it good practice to have it in on bar update?

protected override void OnBarUpdate()
...
double opacity = .25

if(trendUP)
{
BackBrush = BgColorUp;
Brush newBrush = BackBrush.Clone();
newBrush.Opacity = opacity;
newBrush.Freeze();
BackBrush = newBrush;
}

else if(trendDOWN)
{
BackBrush = BgColorDown;
Brush newBrush = BackBrush.Clone();
newBrush.Opacity = opacity;
newBrush.Freeze();
BackBrush = newBrush;
}
nkhoi is offline  
Reply With Quote
Old 01-02-2018, 10:52 AM   #2
NinjaTrader_ChelseaB
NinjaTrader Customer Service
 
NinjaTrader_ChelseaB's Avatar
 
Join Date: Dec 2012
Location: Denver, CO
Posts: 9,165
Thanks: 130
Thanked 2,036 times in 1,884 posts
Default

Hello nkhoi,

This would be inefficient.

Instead of creating a new brush on every new bar, it would be more efficient to declare the variable of the brush within the scope of the class and initialize the brush once as the script starts in State.DataLoaded.

If you have two brushes, create two variables that are initialized in State.DataLoaded, and then switch between the variables in the logic of OnBarUpdate().
NinjaTrader_ChelseaB is offline  
Reply With Quote
Old 01-05-2018, 04:21 PM   #3
nkhoi
Senior Member
 
Join Date: Nov 2004
Location: , ,
Posts: 186
Thanks: 10
Thanked 38 times in 27 posts
Default

Quote:
Originally Posted by NinjaTrader_ChelseaB View Post
Hello nkhoi,

This would be inefficient.

Instead of creating a new brush on every new bar, it would be more efficient to declare the variable of the brush within the scope of the class and initialize the brush once as the script starts in State.DataLoaded.

If you have two brushes, create two variables that are initialized in State.DataLoaded, and then switch between the variables in the logic of OnBarUpdate().

I am not C programmer but I understand the point of not to call newBrush every bar. This is what I came up with. Will this be the same as what you mention?
-------------------------
private System.Windows.Media.Brush bgColorUp = Brushes.RoyalBlue;
private System.Windows.Media.Brush newBrushA, newBrushB, newBrushC, newBrushD ;
....
.....
protected override void OnBarUpdate()
{
//Add your custom indicator logic here.

if (newBrushA == null)
{
BackBrushAll = BgColorUp;
newBrushA = BackBrushAll.Clone();
newBrushA.Opacity = opacity;
newBrushA.Freeze();
}
.....
//
if (trendUP)
BackBrushAll = newBrushA;
nkhoi is offline  
Reply With Quote
Old 01-08-2018, 10:07 AM   #4
NinjaTrader_ChelseaB
NinjaTrader Customer Service
 
NinjaTrader_ChelseaB's Avatar
 
Join Date: Dec 2012
Location: Denver, CO
Posts: 9,165
Thanks: 130
Thanked 2,036 times in 1,884 posts
Default

Hello nkhoi,

No, I am suggesting that you do the initialize or clone in OnStateChange when State is State.DataLoaded.

Below is a publicly available link to the help guide on OnStateChange().
https://ninjatrader.com/support/help...tatechange.htm

private Brush newBrushA;

else if (State == State.DataLoaded)
{
newBrushA = BackBrush.Clone();
newBrushA.Opacity = opacity;
newBrushA.Freeze();
}

protected override void OnBarUpdate()
{
if (trendUP)
BackBrushAll = newBrushA;
}
NinjaTrader_ChelseaB is offline  
Reply With Quote
Reply

Tags
opacity

Thread Tools
Display Modes

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is On
HTML code is Off

Forum Jump

Similar Threads
Thread Thread Starter Forum Replies Last Post
Plots Opacity GrumpyTrader Indicator Development 3 11-15-2017 09:28 AM
Coding opacity sandman Indicator Development 7 09-28-2015 11:21 AM
Background Opacity mainstream General Development 5 04-20-2011 07:41 AM
Suggestion: BackColor Opacity jatubio Suggestions And Feedback 3 05-10-2010 10:50 AM
rectangle Opacity Property mikeytrader General Development 1 05-09-2009 02:08 PM


All times are GMT -6. The time now is 12:56 PM.

Futures, foreign currency and options trading contains substantial risk and is not for every investor. An investor could potentially lose all or more than the initial investment. Risk capital is money that can be lost without jeopardizing ones financial security or lifestyle. Only risk capital should be used for trading and only those with sufficient risk capital should consider trading. Past performance is not necessarily indicative of future results. View Full Risk Disclosure.

CFTC Rules 4.41 - Hypothetical or Simulated performance results have certain limitations, unlike an actual performance record, simulated results do not represent actual trading. Also, since the trades have not been executed, the results may have under-or-over compensated for the impact, if any, of certain market factors, such as lack of liquidity. Simulated trading programs in general are also subject to the fact that they are designed with the benefit of hindsight. No representation is being made that any account will or is likely to achieve profit or losses similar to those shown.

This website is hosted and operated by NinjaTrader, LLC (“NT”), a software development company which owns and supports all proprietary technology relating to and including the NinjaTrader trading platform. NT is an affiliated company to NinjaTrader Brokerage (“NTB”), which is a NFA registered introducing broker (NFA #0339976) providing brokerage services to traders of futures and foreign exchange products. This website is intended for educational and informational purposes only and should not be viewed as a solicitation or recommendation of any product, service or trading strategy. No offer or solicitation to buy or sell securities, securities derivative or futures products of any kind, or any type of trading or investment advice, recommendation or strategy, is made, given, or in any manner endorsed by any NT affiliate and the information made available on this Web site is not an offer or solicitation of any kind. Specific questions related to a brokerage account should be sent to your broker directly. The content and opinions expressed on this website are those of the authors and do not necessarily reflect the official policy or position of NT or any of its affiliates. 

Vendors along with their websites, products and services, collectively referred to as (“Vendor Content”), are independent persons or companies that are in no manner affiliated with NT or any if its affiliates. NT or any of its affiliates are not responsible for, do not approve, recommend or endorse any Vendor Content referenced on this website and it’s your sole responsibility to evaluate Vendor Content. Please be aware that any performance information provided by a vendor should be considered hypothetical and must contain the disclosures required by NFA Rule 2-29(c). If you are interested in learning more about, or investigating the quality of, any such Vendor Content you must contact the vendor, provider or seller of such Vendor Content. No person employed by, or associated with, NT or any of its affiliates is authorized to provide any information about any such Vendor Content.