Go Back   NinjaTrader Support Forum > NinjaTrader 7 > Strategy Development

Strategy Development Support for the development of custom automated trading strategies using NinjaScript.

NinjaTrader
Reply
 
Thread Tools Display Modes
Old 02-25-2008, 06:16 AM   #1
jlm0@infionline.net
Member
 
Join Date: Sep 2007
Posts: 99
Thanks: 0
Thanked 0 times in 0 posts
Default Stopping Strategy

The code below is from the reference sample "HaltBasicStrategy":

if
(Performance.AllTrades.TradesPerformance.Currency. CumProfit > 1000

How can I change this to be 100 pips, plus be sure it includes unrealized as well as realized profit?
Thanks,
Jim
jlm0@infionline.net is offline  
Reply With Quote
Old 02-25-2008, 06:41 AM   #2
NinjaTrader_Dierk
Administrator
 
NinjaTrader_Dierk's Avatar
 
Join Date: Mar 2005
Location: Bamberg, Germany
Posts: 10,084
Thanks: 2
Thanked 32 times in 25 posts
Default

>> plus be sure it includes unrealized as well as realized profit?
Unfortunately this is not supported.
NinjaTrader_Dierk is offline  
Reply With Quote
Old 02-25-2008, 06:49 AM   #3
jlm0@infionline.net
Member
 
Join Date: Sep 2007
Posts: 99
Thanks: 0
Thanked 0 times in 0 posts
Default Stopping Strategy

Are you saying that "pips" is not supported, which I assume I could use "ticks" instead, oR the Unrealized Plus Realized profit?
jlm0@infionline.net is offline  
Reply With Quote
Old 02-25-2008, 06:56 AM   #4
NinjaTrader_Dierk
Administrator
 
NinjaTrader_Dierk's Avatar
 
Join Date: Mar 2005
Location: Bamberg, Germany
Posts: 10,084
Thanks: 2
Thanked 32 times in 25 posts
Default

Both are not supported.
NinjaTrader_Dierk is offline  
Reply With Quote
Old 02-25-2008, 07:15 AM   #5
jlm0@infionline.net
Member
 
Join Date: Sep 2007
Posts: 99
Thanks: 0
Thanked 0 times in 0 posts
Default

I was given this at one time in the past, for currency basis.
Is it no longer valid?

if ((Performance.RealtimeTrades.TradesPerformance.Cur rency.CumProfit + Position.GetProfitLoss(Close[0], PerformanceUnit.Currency) >= 200)
jlm0@infionline.net is offline  
Reply With Quote
Old 02-25-2008, 07:17 AM   #6
NinjaTrader_Dierk
Administrator
 
NinjaTrader_Dierk's Avatar
 
Join Date: Mar 2005
Location: Bamberg, Germany
Posts: 10,084
Thanks: 2
Thanked 32 times in 25 posts
Default

Right, forgot about that. Since you aware of this feature: why do you ask if it's available?
NinjaTrader_Dierk is offline  
Reply With Quote
Old 02-25-2008, 07:24 AM   #7
jlm0@infionline.net
Member
 
Join Date: Sep 2007
Posts: 99
Thanks: 0
Thanked 0 times in 0 posts
Default

I had problems getting it to work in the past, but there are new features in the reference sample that I need to use, that hopefully will allow it to work.
Also, was really wanting to use "ticks", rather than a currency amount.
jlm0@infionline.net is offline  
Reply With Quote
Old 02-25-2008, 07:27 AM   #8
NinjaTrader_Dierk
Administrator
 
NinjaTrader_Dierk's Avatar
 
Join Date: Mar 2005
Location: Bamberg, Germany
Posts: 10,084
Thanks: 2
Thanked 32 times in 25 posts
Default

GetProfitLoss() works with parameters documented here: http://www.ninjatrader-support.com/H...rofitLoss.html
NinjaTrader_Dierk is offline  
Reply With Quote
Old 02-25-2008, 07:45 AM   #9
jlm0@infionline.net
Member
 
Join Date: Sep 2007
Posts: 99
Thanks: 0
Thanked 0 times in 0 posts
Default

So, PerformanceUnit.Points, could only be used with the Unrealized p&l, and not the realized?
Is that correct, which still would not give me what I was hoping for.
jlm0@infionline.net is offline  
Reply With Quote
Old 02-25-2008, 07:48 AM   #10
NinjaTrader_Dierk
Administrator
 
NinjaTrader_Dierk's Avatar
 
Join Date: Mar 2005
Location: Bamberg, Germany
Posts: 10,084
Thanks: 2
Thanked 32 times in 25 posts
Default

Sure you can use Points like
Performance.AllTrades.TradesPerformance.Points.Cum Profit
NinjaTrader_Dierk is offline  
Reply With Quote
Old 02-25-2008, 08:03 AM   #11
jlm0@infionline.net
Member
 
Join Date: Sep 2007
Posts: 99
Thanks: 0
Thanked 0 times in 0 posts
Default

Great!
Thank you for the help.
Jim
jlm0@infionline.net is offline  
Reply With Quote
Old 02-25-2008, 08:19 AM   #12
jlm0@infionline.net
Member
 
Join Date: Sep 2007
Posts: 99
Thanks: 0
Thanked 0 times in 0 posts
Default

getting error message about the "+" when trying this.

if
((Performance.RealtimeTrades.TradesPerformance.Poi nts + Position.GetProfitLoss(Close[0],PerformanceUnit.Points) >= 100))
jlm0@infionline.net is offline  
Reply With Quote
Old 02-25-2008, 08:21 AM   #13
jlm0@infionline.net
Member
 
Join Date: Sep 2007
Posts: 99
Thanks: 0
Thanked 0 times in 0 posts
Default

Found my error, left out .Cumprofit
jlm0@infionline.net is offline  
Reply With Quote
Old 02-28-2008, 08:30 AM   #14
jlm0@infionline.net
Member
 
Join Date: Sep 2007
Posts: 99
Thanks: 0
Thanked 0 times in 0 posts
Default Stop strategy

The below code is not working.
Was up 24 pips, and never closed out and stopped.

// If the profit on real-time trades = 10 pips stop trading
if ((Performance.RealtimeTrades.TradesPerformance.Poi nts.CumProfit + Position.GetProfitLoss(Close[0],PerformanceUnit.Points) >= 10))

{
StopStrategy();
return;
}
jlm0@infionline.net is offline  
Reply With Quote
Old 02-28-2008, 08:33 AM   #15
NinjaTrader_Dierk
Administrator
 
NinjaTrader_Dierk's Avatar
 
Join Date: Mar 2005
Location: Bamberg, Germany
Posts: 10,084
Thanks: 2
Thanked 32 times in 25 posts
Default

Not sure what you mean by "pips". You code below works based on points not "pips".

Also: not sure what "StopStrategy" does. This is not a NinjaScript but a custom method. I suggest debugging your code as per here: http://www.ninjatrader-support.com/v...ead.php?t=3418
NinjaTrader_Dierk is offline  
Reply With Quote
Reply

Thread Tools
Display Modes

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is On
HTML code is Off

Forum Jump

Similar Threads
Thread Thread Starter Forum Replies Last Post
Problems stopping NT from running craigsn Platform Technical Support 4 06-03-2005 03:44 AM


All times are GMT -6. The time now is 07:22 AM.

Futures, foreign currency and options trading contains substantial risk and is not for every investor. An investor could potentially lose all or more than the initial investment. Risk capital is money that can be lost without jeopardizing ones financial security or lifestyle. Only risk capital should be used for trading and only those with sufficient risk capital should consider trading. Past performance is not necessarily indicative of future results. View Full Risk Disclosure.

CFTC Rules 4.41 - Hypothetical or Simulated performance results have certain limitations, unlike an actual performance record, simulated results do not represent actual trading. Also, since the trades have not been executed, the results may have under-or-over compensated for the impact, if any, of certain market factors, such as lack of liquidity. Simulated trading programs in general are also subject to the fact that they are designed with the benefit of hindsight. No representation is being made that any account will or is likely to achieve profit or losses similar to those shown.

This website is hosted and operated by NinjaTrader, LLC (“NT”), a software development company which owns and supports all proprietary technology relating to and including the NinjaTrader trading platform. NT is an affiliated company to NinjaTrader Brokerage (“NTB”), which is a NFA registered introducing broker (NFA #0339976) providing brokerage services to traders of futures and foreign exchange products. This website is intended for educational and informational purposes only and should not be viewed as a solicitation or recommendation of any product, service or trading strategy. No offer or solicitation to buy or sell securities, securities derivative or futures products of any kind, or any type of trading or investment advice, recommendation or strategy, is made, given, or in any manner endorsed by any NT affiliate and the information made available on this Web site is not an offer or solicitation of any kind. Specific questions related to a brokerage account should be sent to your broker directly. The content and opinions expressed on this website are those of the authors and do not necessarily reflect the official policy or position of NT or any of its affiliates. 

Vendors along with their websites, products and services, collectively referred to as (“Vendor Content”), are independent persons or companies that are in no manner affiliated with NT or any if its affiliates. NT or any of its affiliates are not responsible for, do not approve, recommend or endorse any Vendor Content referenced on this website and it’s your sole responsibility to evaluate Vendor Content. Please be aware that any performance information provided by a vendor should be considered hypothetical and must contain the disclosures required by NFA Rule 2-29(c). If you are interested in learning more about, or investigating the quality of, any such Vendor Content you must contact the vendor, provider or seller of such Vendor Content. No person employed by, or associated with, NT or any of its affiliates is authorized to provide any information about any such Vendor Content.