Go Back   NinjaTrader Support Forum > NinjaTrader 8 > Indicator Development

Indicator Development Support for the development of custom indicators using NinjaScript.

NinjaTrader
Reply
 
Thread Tools Display Modes
Old 01-30-2018, 05:35 AM   #16
gma17
Junior Member
 
Join Date: Sep 2012
Posts: 23
Thanks: 6
Thanked 0 times in 0 posts
Default

Hello Chris!

Thank you very much for the support.
Any estimations when new update will be released?
gma17 is offline  
Reply With Quote
Old 01-30-2018, 07:44 AM   #17
NinjaTrader_ChrisL
NinjaTrader Customer Service
 
NinjaTrader_ChrisL's Avatar
 
Join Date: Apr 2017
Location: Denver, CO
Posts: 763
Thanks: 18
Thanked 162 times in 159 posts
Default

Hello,

Thank you for the reply.

There should be an update rolling out early next month or so. I will update this forum post once it is released.

Please let me know if I may be of any further assistance.
NinjaTrader_ChrisL is offline  
Reply With Quote
The following user says thank you to NinjaTrader_ChrisL for this post:
Old 02-02-2018, 11:22 AM   #18
NinjaTrader_ChrisL
NinjaTrader Customer Service
 
NinjaTrader_ChrisL's Avatar
 
Join Date: Apr 2017
Location: Denver, CO
Posts: 763
Thanks: 18
Thanked 162 times in 159 posts
Default

Hello,

NinjaTrader 8 R12 was released. This issue has been fixed.

https://ninjatrader.com/support/help.../?8_0_12_0.htm
NinjaTrader_ChrisL is offline  
Reply With Quote
Old 03-13-2018, 05:43 PM   #19
gma17
Junior Member
 
Join Date: Sep 2012
Posts: 23
Thanks: 6
Thanked 0 times in 0 posts
Default

Hello Chris!

Sorry for the long delay with reply. I’ve been testing different ways to ensure proper termination of my indicators, what has taken time. Let me know, if I need to create another thread.

After R12 update, I can see OnWindowDestroy for Control Center window. Thank you. At the same time there is still one issue: Control Center OnWindowDestroy can come at any time: before termination message is sent to all indicators or after it was sent to some. So, if AddOn cleanup is done in OnWindowDestroy (as it is recommended in documentation) and indicators need to use functions from AddOn in their State.Terminated, you can’t be sure that required resources are still exist in AddOn. This makes code much more complicated (corresponding checks, locks etc) and is increasing running time of the code in State.Terminated
Therefore the question:
Can you consider the possibility to send OnWindowDestroy of Control Center window after all other windows are closed or, to be more precise, after State.Terminated is finished in all indicators?


In fact, all my issues are happening because State.Terminated is not always arriving to the indicators as well as to the AddOn (see first post in this thread) . To illustrate this, I’ve modified an example from the first post.
Closing NT8 while attached code is running on 10+ charts will show that State.Terminated is not send to all indicators or, sometimes, even it has arrived, its execution is not finished. Hence another set of questions:
1. Is that a correct behavior of NT8 that State.Terminated is not always arriving to the indicators?
2. Is that a correct behavior of NT8 that State.Terminated is not always finished (I suspect the thread is closed).

Thank you very much in advance
GmA
Attached Files
File Type: cs TaskTest1.cs (11.7 KB, 7 views)
gma17 is offline  
Reply With Quote
Old 03-14-2018, 02:05 PM   #20
NinjaTrader_ChrisL
NinjaTrader Customer Service
 
NinjaTrader_ChrisL's Avatar
 
Join Date: Apr 2017
Location: Denver, CO
Posts: 763
Thanks: 18
Thanked 162 times in 159 posts
Default

Hello.

Thanks for the follow up.

I am inquiring with our product management team to see if this behavior is expected. I can confirm that the termination state was not complete for an instrument in my testing of your script.

I will reply with my findings shortly.
NinjaTrader_ChrisL is offline  
Reply With Quote
The following user says thank you to NinjaTrader_ChrisL for this post:
Old 03-15-2018, 08:40 AM   #21
gma17
Junior Member
 
Join Date: Sep 2012
Posts: 23
Thanks: 6
Thanked 0 times in 0 posts
Default

Hello Chris!

Thank you.
Will be waiting for your reply

Kind regards
GmA
gma17 is offline  
Reply With Quote
Old 03-16-2018, 01:33 PM   #22
gma17
Junior Member
 
Join Date: Sep 2012
Posts: 23
Thanks: 6
Thanked 0 times in 0 posts
Default

Hello Chris!

One additional observation.
I am using 3 data connections: Continuum (for futures), FXCM (for forex) and Kinetick (for End of Day).
After loading Test indicator on 15 charts (5 per each data feed) I've disconnected all 3 data feed and have connected them back in few minutes. State.Terminated has been received by only 10 charts.

Not sure if this is important, but better I'll share it.

Thank you
GmA
gma17 is offline  
Reply With Quote
Old 03-21-2018, 07:51 AM   #23
gma17
Junior Member
 
Join Date: Sep 2012
Posts: 23
Thanks: 6
Thanked 0 times in 0 posts
Default

Hello Chris!

Sorry for bothering.
Any update from product management team?

Thank you very much in advance
GmA
gma17 is offline  
Reply With Quote
Old 03-21-2018, 12:36 PM   #24
NinjaTrader_ChrisL
NinjaTrader Customer Service
 
NinjaTrader_ChrisL's Avatar
 
Join Date: Apr 2017
Location: Denver, CO
Posts: 763
Thanks: 18
Thanked 162 times in 159 posts
Default

Hello.

Thanks for the follow up.

We are still waiting on a confirmation to see if this is expected or not. If it turns out to be expected, I would submit a feature request to have this changed.

Please let us know if you have any questions.
NinjaTrader_ChrisL is offline  
Reply With Quote
The following user says thank you to NinjaTrader_ChrisL for this post:
Old 03-28-2018, 04:58 AM   #25
gma17
Junior Member
 
Join Date: Sep 2012
Posts: 23
Thanks: 6
Thanked 0 times in 0 posts
Default

Hello Chris!

Any further update?

Thank you in advance
GmA
gma17 is offline  
Reply With Quote
Old 03-29-2018, 06:33 AM   #26
NinjaTrader_ChrisL
NinjaTrader Customer Service
 
NinjaTrader_ChrisL's Avatar
 
Join Date: Apr 2017
Location: Denver, CO
Posts: 763
Thanks: 18
Thanked 162 times in 159 posts
Default

Hello.

Sorry, but there is no update for this item at this time. I will update this thread when I learn any news.

Please let us know if you have any questions.
NinjaTrader_ChrisL is offline  
Reply With Quote
Old 04-16-2018, 03:39 PM   #27
gma17
Junior Member
 
Join Date: Sep 2012
Posts: 23
Thanks: 6
Thanked 0 times in 0 posts
Default

Hello Chris!

Did you get any update from Product Management Team?

Thank you in advance
GmA
gma17 is offline  
Reply With Quote
Old 04-17-2018, 11:23 AM   #28
NinjaTrader_ChrisL
NinjaTrader Customer Service
 
NinjaTrader_ChrisL's Avatar
 
Join Date: Apr 2017
Location: Denver, CO
Posts: 763
Thanks: 18
Thanked 162 times in 159 posts
Default

Hello gma17,

Thanks for the follow up.

This item has been reported to the development team and will be changed in later revisions.

When this issue gets solved it will be posted on our release notes page below:

https://ninjatrader.com/support/help...ease_notes.htm

Please refer to that page whenever an update is released to keep track of bug fixes and feature additions.

Please let us know if you have any questions.
NinjaTrader_ChrisL is offline  
Reply With Quote
The following user says thank you to NinjaTrader_ChrisL for this post:
Reply

Thread Tools
Display Modes

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is On
HTML code is Off

Forum Jump

Similar Threads
Thread Thread Starter Forum Replies Last Post
NT8 suggestion: new State before State.Terminated fx.practic Suggestions And Feedback 3 08-22-2017 03:29 PM
(State == State.Terminated) ChartControl == null ren37 Indicator Development 9 07-07-2017 04:00 PM
State.Terminated PaulZ Strategy Development 3 02-22-2017 09:45 AM
State.Terminated problem bluueskyy Platform Technical Support 3 12-07-2016 09:19 AM
State.Terminated and ChartControl AlexGn Version 8 Beta 10 11-19-2015 09:48 AM


All times are GMT -6. The time now is 08:50 AM.

Futures, foreign currency and options trading contains substantial risk and is not for every investor. An investor could potentially lose all or more than the initial investment. Risk capital is money that can be lost without jeopardizing ones financial security or lifestyle. Only risk capital should be used for trading and only those with sufficient risk capital should consider trading. Past performance is not necessarily indicative of future results. View Full Risk Disclosure.

CFTC Rules 4.41 - Hypothetical or Simulated performance results have certain limitations, unlike an actual performance record, simulated results do not represent actual trading. Also, since the trades have not been executed, the results may have under-or-over compensated for the impact, if any, of certain market factors, such as lack of liquidity. Simulated trading programs in general are also subject to the fact that they are designed with the benefit of hindsight. No representation is being made that any account will or is likely to achieve profit or losses similar to those shown.

This website is hosted and operated by NinjaTrader, LLC (“NT”), a software development company which owns and supports all proprietary technology relating to and including the NinjaTrader trading platform. NT is an affiliated company to NinjaTrader Brokerage (“NTB”), which is a NFA registered introducing broker (NFA #0339976) providing brokerage services to traders of futures and foreign exchange products. This website is intended for educational and informational purposes only and should not be viewed as a solicitation or recommendation of any product, service or trading strategy. No offer or solicitation to buy or sell securities, securities derivative or futures products of any kind, or any type of trading or investment advice, recommendation or strategy, is made, given, or in any manner endorsed by any NT affiliate and the information made available on this Web site is not an offer or solicitation of any kind. Specific questions related to a brokerage account should be sent to your broker directly. The content and opinions expressed on this website are those of the authors and do not necessarily reflect the official policy or position of NT or any of its affiliates. 

Vendors along with their websites, products and services, collectively referred to as (“Vendor Content”), are independent persons or companies that are in no manner affiliated with NT or any if its affiliates. NT or any of its affiliates are not responsible for, do not approve, recommend or endorse any Vendor Content referenced on this website and it’s your sole responsibility to evaluate Vendor Content. Please be aware that any performance information provided by a vendor should be considered hypothetical and must contain the disclosures required by NFA Rule 2-29(c). If you are interested in learning more about, or investigating the quality of, any such Vendor Content you must contact the vendor, provider or seller of such Vendor Content. No person employed by, or associated with, NT or any of its affiliates is authorized to provide any information about any such Vendor Content.