Help Converting NT 7 Indicator to NT 8

[Taddypole]

I'm attempting to convert an NT 7 indicator to NT 8.

I have created a new indicator in NT 8 and have copied properties and Plots from the NT 7 indicator.

Next I'm working on "On Bar Update".

I'm bringing in the following code:

LinRegCurve.Set(LinReg(base.Input,length)[0]);



I have made the code breaking changes to yield the following :

LinRegCurve(0) = LinReg(base.Input,length)[0];


The compiler error when running this is "the name LinRegCurve" does not exist.

In NT 7 I had:

Private DataSeries LinRegCurve (in the Variables )

LinRegCurve = new DataSeries(this); (in the Initialize)


Where do these go in NT 8?


Thanks
taddypole...

[sidlercom80]

Hi, DataSeries should be in "State.DataLoaded", in "OnStateChange".

if (State == State.DataLoaded)
{
LinRegCurve = new DataSeries(this);
}

[bltdavid]

Hi, DataSeries should be in "State.DataLoaded", in "OnStateChange".

if (State == State.DataLoaded)
{
LinRegCurve = new DataSeries(this);
}

LinRegCurve = new Series<double>(this);

[Taddypole]

per the attachment...
I still get LinRegCurve does not exist..????

[bltdavid]

The compiler error when running this is "the name LinRegCurve" does not exist.

In NT 7 I had:

Private DataSeries LinRegCurve (in the Variables )

LinRegCurve = new DataSeries(this); (in the Initialize)

Where do these go in NT 8?

private Series<double> LinRegCurve; // in the variables, at the top

[Taddypole]

Thanks for the suggestions above... I am not on my way to converting this indicator....


I have another question. How do I deal with color variables?


see attachment:

[NinjaTrader_ChelseaB]

Hello Taddypole,

NinjaTrader 8 uses Series<double> as the variable type and new Series<double> to instantiate a custom series within State.DataLoaded and AddDataSeries() for adding another instrument or timeframe as dataseries.

https://ninjatrader.com/support/helpGuides/nt8/seriest.htm

https://ninjatrader.com/support/helpGuides/nt8/adddataseries.htm

Colors, once used for Forms, is now Brushes with WPF (Windows Presentation Foundation).

https://ninjatrader.com/support/helpGuides/nt8/working_with_brushes.htm

[bltdavid]

I have another question. How do I deal with color variables?

I suggest you look at the source code for the indicator @VolumeZones.cs.
Study this standard indicator in your NT8 indicators folder.

Why that indicator?
Because that indicator shows how to define user-defined colors as properties,
which in NT8 is technically user-defined brushes. You get several benefits by
seeing how the brushes are used in various circumstances.

But the really great thing?
You can also look at the older NT7 version of the same indicator, and get a
feel how it was changed to work with NT8.

You can also try studying @VolumeProfile.cs.
As well as NT7's @CustomPlotSample.cs vs NT8's @SampleCustomRender.cs.

Good luck!

[Taddypole]

I'm advancing through my code and all your help is greatly appreciated.

In the first attachment I have two lines of code for DrawLine and DrawText. They are not compiling and I think its due to the StTermColor term.

In the second attachment I show where I tried to define the Color (Brushes) parameters.

Any suggestions that might help me compile without errors?

[NinjaTrader_ChelseaB]

Hello Taddypole,

Below is a link to a forum post on porting scripts. Be sure to look up items in the Code Breaking Changes in the help guide.

https://ninjatrader.com/support/forum/showthread.php?p=490313#post490313

DrawLine() is now Draw.Line().

https://ninjatrader.com/support/helpGuides/nt8/draw_line.htm

DrawText() is now Draw.Text().

https://ninjatrader.com/support/helpGuides/nt8/draw_text.htm

Colors are now Brushes. See post #7.

[Taddypole]

I fixed the Draw.Text and Draw.Line and am still left with the StTermColor not being able to be converted.

[bltdavid]

I fixed the Draw.Text and Draw.Line and am still left with the StTermColor not being able to be converted.

What, specifically, is your question?

[Taddypole]

I'm thinking my declaration of StTermColor is not correct for NT 8 and that is the reason for my compiler error.

And how do I resolve the compiler error... (Argument 8: cannot convert from 'System.Windows.Media.Brushes' to 'System.Windows.Media.Brush')

[NinjaTrader_ChelseaB]

Hello Taddypole,

private Brush myBrush;

myBrush = Brushes.Green;

[Taddypole]

Thanks ChelseaB...
That helped....